https://github.com/vyos/vyos-1x/pull/4386

After deep investigation with @zsdc, we found that the issue can be here https://github.com/FRRouting/frr/blob/f3a7077df01176164c0bb5775ecb886cf233089e/ldpd/neighbor.c#L629

https://github.com/vyos/vyos-1x/pull/4381

Is there anyone else we should tag on this ticket?

Just to add to the argument: Using the build_type to determine if the banner gets shown or not would allow individual/custom builds to have it disabled as well (we know what we are doing). Obviously I can just speak for my use case, where we roll our own builds to get back qemu-guest-agent. I can't tell if this would go against the intention of introducing this banner in the first place.

@treo Could you check the latest rolling to confirm if everything works as expected?

@daniel.arconada can you check this? The latest rolling has these modules.

vyos@vpp-left:~$ zcat /proc/config.gz | grep -i vdpa
CONFIG_VIRTIO_VDPA=m
CONFIG_VDPA=m
# CONFIG_VDPA_USER is not set
# CONFIG_MLX5_VDPA_NET is not set
# CONFIG_MLX5_VDPA_STEERING_DEBUG is not set
# CONFIG_VP_VDPA is not set
# CONFIG_ALIBABA_ENI_VDPA is not set
# CONFIG_SNET_VDPA is not set
CONFIG_VHOST_VDPA=m
vyos@vpp-left:~$ 
vyos@vpp-left:~$ show ver
Version:          VyOS 1.5-rolling-202503020018

Can confim the configuration carried over with vyos-1.5-rolling-202503020018. I need to test things further but at first glance things look good.

This has been implemented in VyOS rolling already as part of T6989.
It will be backported to VyOS 1.5

@sarthurdev I think, conntract should be transferred from input or forward to the global section or used in prerouting. Because now it looks like conntrack is used only in these rules, not for all traffic.