Page MenuHomeVyOS Platform

generate tech-support archive fails if /config/scripts contains directories
Closed, ResolvedPublicBUG

Description

generate tech-support archive fails if /config contains directories

vyos@r14:~$ generate tech-support archive 
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/tech_support.py", line 387, in <module>
    res = vyos.opmode.run(sys.modules[__name__])
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/vyos/opmode.py", line 312, in run
    res = func(**args)
          ^^^^^^^^^^^^
  File "/usr/libexec/vyos/op_mode/tech_support.py", line 379, in show
    data = _get_raw_data()
           ^^^^^^^^^^^^^^^
  File "/usr/libexec/vyos/op_mode/tech_support.py", line 338, in _get_raw_data
    data["vyos"]["config"]["scripts"] = _get_config_scripts()
                                        ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/libexec/vyos/op_mode/tech_support.py", line 110, in _get_config_scripts
    data = read_file(path)
           ^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/vyos/utils/file.py", line 44, in read_file
    raise e
  File "/usr/lib/python3/dist-packages/vyos/utils/file.py", line 38, in read_file
    with open(fname, 'r') as f:
         ^^^^^^^^^^^^^^^^
IsADirectoryError: [Errno 21] Is a directory: '/config/scripts/accel-ppp'
vyos@r14:~$ 
vyos@r14:~$ 
vyos@r14:~$ 
vyos@r14:~$ tree /config/scripts
/config/scripts
├── accel-ppp
│   └── ipoe.lua
├── vyos-postconfig-bootup.script
└── vyos-preconfig-bootup.script

2 directories, 3 files
vyos@r14:~$ 
vyos@r14:~$ 
vyos@r14:~$ 
vyos@r14:~$ cat /config/scripts/accel-ppp/ipoe.lua 
#!lua
  function username_func(pkt)
    local username=pkt:hwaddr()
    return username
end
vyos@r14:~$ 


vyos@r14:~$ ls -la /config/scripts/
total 20
drwxrwsr-x 3 root vyattacfg 4096 Nov 26 13:38 .
drwxrwsr-x 1 root vyattacfg 4096 Dec 18 12:44 ..
drwxrwsr-x 2 root vyattacfg 4096 Nov 26 15:13 accel-ppp
-rwxrwxr-x 1 root vyattacfg  230 Dec 12 11:29 vyos-postconfig-bootup.script
-rwxrwxr-x 1 root vyattacfg  225 Dec 12 11:29 vyos-preconfig-bootup.script
vyos@r14:~$

Details

Version
VyOS 1.5-rolling-202412100007
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

Viacheslav triaged this task as Normal priority.
natali-rs1985 changed the task status from Open to In progress.Dec 27 2024, 4:31 PM
natali-rs1985 claimed this task.
dmbaturin renamed this task from generate tech-support archive fails if /config contains directories to generate tech-support archive fails if /config/scripts contains directories.Jan 29 2025, 7:35 PM
dmbaturin added a project: VyOS 1.5 Circinus.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.