Page MenuHomeVyOS Platform

PPPoE server does not allow listening on physical interfaces if VLANs are present in the configuration
Closed, ResolvedPublicBUG

Description

PPPoE-server does not allow listening to interfaces without tags if tags are present in the configuration.
For example, we want to get PPPoE-server on eth1 (without tags) and on additional VLANS 10-122

I.e., the listen interface should be:
eth1 / eth1.10 / eth1.11 / eth1.xxx / ... / eth1.122

But it is impossible with the current CLI (eth1 without tag)

set service pppoe-server access-concentrator 'ACN'
set service pppoe-server authentication mode 'radius'
set service pppoe-server authentication radius server 127.0.0.1 key 'xxx'
set service pppoe-server client-ip-pool FIRST range '100.64.0.0/24'
set service pppoe-server gateway-address '100.64.0.1'
set service pppoe-server interface eth1 vlan '10-122'
set service pppoe-server interface eth1 vlan-mon

Generated configuration:

vyos@r14# cat /run/accel-pppd/pppoe.conf | grep '\[pppoe\]' -A 5
[pppoe]
...
interface=re:^eth1\.(1\d|[2-9]\d|1[0-1]\d|12[0-2])$
vlan-mon=eth1,10-122

To fix it, I have to add manually to the pppoe.conf the option interface=eth1

vyos@r14# cat /run/accel-pppd/pppoe.conf | grep '\[pppoe\]' -A 5
[pppoe]
...
interface=re:^eth1\.(1\d|[2-9]\d|1[0-1]\d|12[0-2])$
vlan-mon=eth1,10-122
# my manual change here
interface=eth1

One of the possible solutions is adding a CLI option like allow-native-name (Needs to think about option)

set service pppoe-server interface eth1 < allow-native-name >

Details

Version
VyOS 1.5-rolling-202412031443
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Revisions and Commits

Event Timeline

Viacheslav triaged this task as Normal priority.
Viacheslav changed the task status from Open to In progress.Dec 20 2024, 3:55 PM
Viacheslav claimed this task.

PR https://github.com/vyos/vyos-1x/pull/4247
Add combined option

vyos@r14# run show conf com | match "eth1|ppp"
set interfaces ethernet eth1 vif 500
set service pppoe-server access-concentrator 'ACN'
set service pppoe-server authentication mode 'radius'
set service pppoe-server authentication radius server 127.0.0.1 key 'xxx'
set service pppoe-server client-ip-pool FIRST range '100.64.0.0/24'
set service pppoe-server gateway-address '100.64.0.1'
set service pppoe-server interface eth1 combined
set service pppoe-server interface eth1 vlan '10-122'
set service pppoe-server interface eth1 vlan-mon
set service pppoe-server interface eth1.500
[edit]
vyos@r14# 
[edit]
vyos@r14# run show pppoe-server interfaces 
 interface:   connections:    state:
-----------------------------------
     eth1              0    active
 eth1.500              0    active
[edit]
vyos@r14#
Restricted Repository Identity closed this task as Resolved by committing Restricted Diffusion Commit.Jan 22 2025, 7:13 PM
Restricted Repository Identity added a commit: Restricted Diffusion Commit.
dmbaturin renamed this task from PPPoE-server does not allow listening to interfaces without tags if tags in configuration to PPPoE server does not allow listening on physical interfaces if VLANs are present in the configuration.Wed, Mar 12, 3:32 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.