Page MenuHomeVyOS Platform
Create Task
Maniphest T4235

Add config tree diff algorithm
Closed, ResolvedPublic
Actions

Description

The PRs below add a replacement for the legacy config diff algorithm in vyatta-cfg. Immediate applications will include an update to the 'load config' script that does not rely on the legacy 'loadFile'; extensions of that script in line with T3441; and python utils extending those of configdiff.py. In addition this adds a necessary step in the path towards replacing vyatta-cfg.

https://github.com/vyos/vyos1x-config/pull/2
https://github.com/vyos/libvyosconfig/pull/3
https://github.com/vyos/vyos-1x/pull/1213

Details

Version
vyos-1.4
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedjestabroT4235 Add config tree diff algorithm
 ResolvedBUGjestabroT4260 Extend vyos.configdict.node_changed() to support recursiveness
 Not ApplicableFEATURE REQUESTjestabroT4295 Use config_tree instead of legacy loadFile in vyos-load-config.py
 OpenFEATURE REQUESTNoneT3441 More intelligent config loading scripts
 ResolvedFEATURE REQUESTjestabroT5248 Ability to load config via API in JSON format
 ResolvedBUGjestabroT4382 Replacing legacy loadFile exposes missing steps in migration scripts and other errors
 ResolvedENHANCEMENTjestabroT5528 Replace legacy loadFile with config_diff
 ResolvedENHANCEMENTjestabroT5815 Add load_config module
 ResolvedENHANCEMENTjestabroT5400 Move libvyosconfig build out of the Docker image
 ResolvedBUGjestabroT7289 Add libvyosconfig as git submodule of vyos-1x for stream builds
 ResolvedENHANCEMENTjestabroT6717 Add hybrid Cstore manipulation library to replace set/delete/load_config functionality
 ResolvedENHANCEMENTjestabroT6718 Use vyconf daemon for validation of set commands
 ResolvedENHANCEMENTjestabroT6946 Add initial commit algorithm to vyconf
 ResolvedENHANCEMENTjestabroT7121 Set up communication vyconfd <-> vyos-configd
 ResolvedENHANCEMENTjestabroT7272 Vyconf: update in memory config tree on response from vyos-commitd
 OpenENHANCEMENTjestabroT7292 Expose vyconf commit algorithm for CLI and ConfigSession instance
 ResolvedENHANCEMENTjestabroT7302 Implement commit dry-run for vyconfd/vyos-commitd
 ResolvedENHANCEMENTjestabroT7321 Replace legacy operations in configsession.py with vyconf client operations
 OpenENHANCEMENTjestabroT7374 Integrate vyconf config session with CLI config session
 OpenBUGjestabroT6959 Add support for addons after switch to internal reference tree
 ResolvedENHANCEMENTjestabroT7046 Add utilities for update of reference tree
 ResolvedBUGjestabroT4491 Use empty string for internal name of root node of config_tree

Event Timeline

jestabro created this task.Feb 9 2022, 3:04 AM
jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
jestabro updated the task description. (Show Details)Feb 9 2022, 3:20 AM
jestabro added a subtask: T3441: More intelligent config loading scripts.
jestabro changed the task status from Open to Needs testing.Feb 9 2022, 3:27 AM
Restricted Repository Identity mentioned this in rVYOSONEXeacee4a5eac4: Merge pull request #1213 from jestabro/config-diff.Feb 10 2022, 6:12 AM
jestabro mentioned this in rVYOSONEX2ee94418ce24: configtree: T4235: encapsulate config tree diff function.Feb 10 2022, 6:12 AM
jestabro closed this task as Resolved.Feb 10 2022, 3:58 PM
jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
jestabro reopened this task as Open.Feb 23 2022, 2:59 PM

Reopen to add some simplifications to the interface, inspired by T4260.

jestabro added a subtask: T4260: Extend vyos.configdict.node_changed() to support recursiveness.Feb 23 2022, 2:59 PM
pasik subscribed.Feb 23 2022, 3:40 PM
Restricted Repository Identity mentioned this in rVYOSONEXe29c53bc1d66: Merge pull request #1238 from jestabro/delete-tree.Mar 2 2022, 12:56 AM
jestabro mentioned this in rVYOSONEX193cbd15ba39: configtree: T4235: distinguish sub(-tract) tree from delete tree.Mar 2 2022, 12:56 AM
jestabro mentioned this in rVYOSONEX4625fd41f99d: configtree: T4235: allow empty arguments.
jestabro mentioned this in rVYOSONEXff7e2cd622cf: configtree: T4235: add utility get_subtree.
jestabro mentioned this in rVYOSONEX3d28528ff84b: configtree: T4235: simplification of diff_tree class.
jestabro closed this task as Unknown Status.Mar 2 2022, 3:51 PM
jestabro changed the status of subtask T4260: Extend vyos.configdict.node_changed() to support recursiveness from Open to Needs testing.
jestabro closed subtask T4260: Extend vyos.configdict.node_changed() to support recursiveness as Unknown Status.Mar 3 2022, 2:19 PM
jestabro added a project: VyOS 1.3 Equuleus.
jestabro added a subtask: T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py.Mar 9 2022, 5:23 PM
jestabro reopened subtask T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py as Open.Mar 24 2022, 8:06 PM
jestabro mentioned this in T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors.Apr 20 2022, 8:25 PM
Restricted Repository Identity mentioned this in rVYOSONEX8a518ef78780: Merge pull request #1296 from jestabro/equuleus-config-diff.Apr 26 2022, 11:17 AM
jestabro mentioned this in rVYOSONEXa2bbde8f17d2: configtree: T4235: distinguish sub(-tract) tree from delete tree.Apr 26 2022, 11:17 AM
jestabro mentioned this in rVYOSONEX5b1231a05110: configtree: T4235: allow empty arguments.
jestabro mentioned this in rVYOSONEX4102ff9c7ca9: configtree: T4235: simplification of diff_tree class.
jestabro mentioned this in rVYOSONEX5d299e9f9bfb: configtree: T4235: add utility get_subtree.
jestabro mentioned this in rVYOSONEXb0b5654a1f99: configtree: T4235: encapsulate config tree diff function.
jestabro changed the task status from Unknown Status to Resolved.Apr 26 2022, 11:23 AM
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
jestabro changed the status of subtask T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py from Open to On hold.Jun 28 2022, 7:57 PM
jestabro added a subtask: T4491: Use empty string for internal name of root node of config_tree.Jun 28 2022, 8:17 PM
jestabro closed subtask T4491: Use empty string for internal name of root node of config_tree as Unknown Status.Jun 29 2022, 2:47 PM
jestabro changed the status of subtask T4491: Use empty string for internal name of root node of config_tree from Unknown Status to Resolved.Jul 14 2022, 12:55 PM
dmbaturin changed the status of subtask T4260: Extend vyos.configdict.node_changed() to support recursiveness from Unknown Status to Resolved.Aug 14 2022, 6:16 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:15 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.
jestabro closed subtask T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py as Not Applicable.Jan 16 2024, 3:34 AM