The explicit checkout of the libvyosconfig repo from the vyos-1x Makefile (T5400: add local build of libvyosconfig to Makefile) is not easily adapted to the Circinus repos; add libvyosconfig as a git submodule of vyos-1x as an alternative.
Description
Description
Details
Details
- Version
- -
- Is it a breaking change?
- Perfectly compatible
- Issue type
- Internal change (not visible to end users)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| In progress | FEATURE REQUEST | None | T3355 Remove all remaining legacy Vyatta code | ||
| Open | BUG | None | T4316 Update save-config/load-config | ||
| Resolved | jestabro | T4235 Add config tree diff algorithm | |||
| Not Applicable | FEATURE REQUEST | jestabro | T4295 Use config_tree instead of legacy loadFile in vyos-load-config.py | ||
| Resolved | ENHANCEMENT | jestabro | T5316 configtree: use a single pass of the diff algorithm | ||
| Resolved | ENHANCEMENT | jestabro | T5317 configtree: remove mutable references | ||
| In progress | ENHANCEMENT | jestabro | T5528 Replace legacy loadFile with config_diff | ||
| Resolved | ENHANCEMENT | jestabro | T5400 Move libvyosconfig build out of the Docker image | ||
| Open | BUG | jestabro | T7289 Add libvyosconfig as git submodule of vyos-1x for stream builds |
Event Timeline
Comment Actions
Using relative url in .gitmodules will get forked repos difficult to build if not modify .gitmodules manually.
Comment Actions
also failed in PR
cp -r libvyosconfig /tmp && cd /tmp/libvyosconfig && \ eval $(opam env --root=/opt/opam --set-root) && ./build.sh || exit 1 fi Submodule 'libvyosconfig' (https://github.com/sskaje/libvyosconfig.git) registered for path 'libvyosconfig' Cloning into '/__w/vyos-1x/vyos-1x/packages/vyos-1x/libvyosconfig'... fatal: could not read Username for 'https://github.com': No such device or address fatal: clone of 'https://github.com/sskaje/libvyosconfig.git' into submodule path '/__w/vyos-1x/vyos-1x/packages/vyos-1x/libvyosconfig' failed Failed to clone 'libvyosconfig'. Retry scheduled Cloning into '/__w/vyos-1x/vyos-1x/packages/vyos-1x/libvyosconfig'... fatal: could not read Username for 'https://github.com': No such device or address fatal: clone of 'https://github.com/sskaje/libvyosconfig.git' into submodule path '/__w/vyos-1x/vyos-1x/packages/vyos-1x/libvyosconfig' failed Failed to clone 'libvyosconfig' a second time, aborting Warning: Running as root is not recommended
Comment Actions
Regarding the failure of the PR integration tests, this may have been a result of a typo, now corrected in rolling here:
https://github.com/vyos/vyos-1x/pull/4425
or an inconsistent github action (I will check that).
Regarding workflow and forks, that is something to consider: use of the relative path is the recommended way to manage both public and private repos, but we may need to extend the approach.