Page MenuHomeVyOS Platform

Use empty string for internal name of root node of config_tree
Closed, ResolvedPublicBUG

Description

There had been a convention of using 'root' as the internal name of the root node of the config_tree data structure, however, the config diff algorithm does a naive check against node name, which will collide with any actual node named 'root' (for example 'set pki ca root ...'). Instead, we will use the empty string as the name entry of the root node, as no 'actual' node can have an empty name.

Details

Difficulty level
Easy (less than an hour)
Version
vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Revisions and Commits

Event Timeline

jestabro changed the task status from Open to In progress.Jun 28 2022, 7:05 PM
jestabro triaged this task as Normal priority.
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro renamed this task from Use empty string for internal name of root of config_tree to Use empty string for internal name of root node of config_tree.Jun 28 2022, 8:17 PM
jestabro changed the task status from In progress to Backport candidate.Jun 29 2022, 2:47 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.