There had been a convention of using 'root' as the internal name of the root node of the config_tree data structure, however, the config diff algorithm does a naive check against node name, which will collide with any actual node named 'root' (for example 'set pki ca root ...'). Instead, we will use the empty string as the name entry of the root node, as no 'actual' node can have an empty name.
Description
Description
Details
Details
- Difficulty level
- Easy (less than an hour)
- Version
- vyos-1.4
- Why the issue appeared?
- Will be filled on close
- Is it a breaking change?
- Perfectly compatible
- Issue type
- Internal change (not visible to end users)
Revisions and Commits
Revisions and Commits
Restricted Diffusion Commit |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | jestabro | T4235 Add config tree diff algorithm | |||
Resolved | BUG | jestabro | T4491 Use empty string for internal name of root node of config_tree |