Note that this is only a difference in formatting, not a change in error reporting; the formatting will be restored to the original behavior for consistency of parsing.

Wed, Jul 24, 3:35 PM · VyOS 1.4 Sagitta (1.4.1), Restricted Project, VyOS 1.5 Circinus

jestabro triaged T6605: `ConfigError()` behavior is wrong with running `vyos-configd` as Normal priority.

Wed, Jul 24, 3:32 PM · VyOS 1.4 Sagitta (1.4.1), Restricted Project, VyOS 1.5 Circinus

jestabro claimed T6605: `ConfigError()` behavior is wrong with running `vyos-configd`.

This was a result of changes to make error reporting more explicit in case of errors in config dependencies; I will realign with error reporting without vyos-configd.

Wed, Jul 24, 12:56 PM · VyOS 1.4 Sagitta (1.4.1), Restricted Project, VyOS 1.5 Circinus

Mon, Jul 22

jestabro moved T6559: vyos-configd should return commit error on config dependency error from Backport Candidates to Finished on the VyOS 1.4 Sagitta (1.4.1) board.

Mon, Jul 22, 12:24 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

jestabro closed T6559: vyos-configd should return commit error on config dependency error as Resolved.

Mon, Jul 22, 12:23 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

jestabro added a comment to T5528: Replace legacy loadFile with config_diff.

Links for PR in preparation:
https://github.com/vyos/vyos1x-config/compare/current...jestabro:vy-adapter
https://github.com/vyos/vyatta-cfg/compare/current...jestabro:vy-adapter
https://github.com/vyos/vyos-1x/compare/current...jestabro:vy-adapter
https://github.com/vyos/libvyosconfig/compare/current...jestabro:vy-adapter

Mon, Jul 22, 12:09 PM · VyOS 1.5 Circinus

Wed, Jul 17

jestabro moved T6559: vyos-configd should return commit error on config dependency error from Need Triage to Backport Candidates on the VyOS 1.4 Sagitta (1.4.1) board.

Wed, Jul 17, 12:59 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

jestabro moved T6559: vyos-configd should return commit error on config dependency error from Need Triage to Backport Candidates on the VyOS 1.5 Circinus board.

Wed, Jul 17, 12:59 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

Mon, Jul 15

jestabro added a comment to T6559: vyos-configd should return commit error on config dependency error.

PR:
https://github.com/vyos/vyos-1x/pull/3813

Mon, Jul 15, 5:31 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

Fri, Jul 12

jestabro moved T5263: Generalization of REST configure endpoint from Need Triage to Finished on the VyOS 1.4 Sagitta board.

Fri, Jul 12, 7:59 PM · VyOS 1.4 Sagitta

jestabro closed T5263: Generalization of REST configure endpoint as Resolved.

This was completed at the time of T5248.

Fri, Jul 12, 7:59 PM · VyOS 1.4 Sagitta

Thu, Jul 11

jestabro added a comment to T6559: vyos-configd should return commit error on config dependency error.

The solution sketched above will be handled in subtask T6569; in this task we will revert to using only the local redundancy removal in order to provide per-script error reporting.

Thu, Jul 11, 5:21 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

jestabro removed a subtask for T5731: Add ability to call config dependencies by canonical function instead of whole script: T6559: vyos-configd should return commit error on config dependency error.

Thu, Jul 11, 5:18 PM · VyOS 1.5 Circinus

jestabro removed a parent task for T6559: vyos-configd should return commit error on config dependency error: T5731: Add ability to call config dependencies by canonical function instead of whole script.

Thu, Jul 11, 5:18 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

jestabro added a subtask for T5731: Add ability to call config dependencies by canonical function instead of whole script: T6569: Cache results of config script stages under configd, for use by configdep.

Thu, Jul 11, 5:18 PM · VyOS 1.5 Circinus

jestabro added a subtask for T6559: vyos-configd should return commit error on config dependency error: T6569: Cache results of config script stages under configd, for use by configdep.

Thu, Jul 11, 5:18 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

jestabro added parent tasks for T6569: Cache results of config script stages under configd, for use by configdep: T6559: vyos-configd should return commit error on config dependency error, T5731: Add ability to call config dependencies by canonical function instead of whole script.

Thu, Jul 11, 5:18 PM · VyOS 1.5 Circinus

jestabro created T6569: Cache results of config script stages under configd, for use by configdep.

Thu, Jul 11, 5:17 PM · VyOS 1.5 Circinus

Mon, Jul 8

jestabro added a subtask for T5731: Add ability to call config dependencies by canonical function instead of whole script: T6559: vyos-configd should return commit error on config dependency error.

Mon, Jul 8, 12:38 AM · VyOS 1.5 Circinus

jestabro added a parent task for T6559: vyos-configd should return commit error on config dependency error: T5731: Add ability to call config dependencies by canonical function instead of whole script.

Mon, Jul 8, 12:38 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

jestabro added a comment to T6559: vyos-configd should return commit error on config dependency error.

Recovering gracefully and logging an error is a simple fix, and will be committed in the interim while the larger issue is addressed: namely, when running under vyos-configd, a ConfigError in a called dependency script should elicit a commit error in the originating config session. Here, however, we confront again the constraints of operating under the legacy commit algorithm. To address the matter, we will implement a partial solution to T5731 so as to catch verification errors in the (first instance of) sequential processing of the priority queue and cache the data for final processing of the activation stages (generate/apply); errors in the latter stages, as less common, will be logged. The sketch provided summarizes a design that balances the needs of early and correct (verify stage) error reporting with removing redundancy overhead when running under configd.

Mon, Jul 8, 12:38 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

Fri, Jul 5

jestabro created T6559: vyos-configd should return commit error on config dependency error.

Fri, Jul 5, 5:44 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

jestabro added a comment to T6007: Improvements to migration system.

Bug fix in case of empty config file component version string:
https://github.com/vyos/vyos-1x/pull/3788

Fri, Jul 5, 1:01 AM · VyOS 1.5 Circinus

Wed, Jul 3

jestabro added a comment to T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration.

@a.apostoliuk if you accept the explanation above and the workaround suffices (as recently discussed), we will close this task.

Wed, Jul 3, 5:51 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro removed a subtask for T5938: Migration fail root task for 1.4-rc: T5991: 1.4.0-RC3 deleting portions of config in error (migration script).

Wed, Jul 3, 5:46 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro removed a parent task for T5991: 1.4.0-RC3 deleting portions of config in error (migration script): T5938: Migration fail root task for 1.4-rc.

Wed, Jul 3, 5:46 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro added a comment to T5991: 1.4.0-RC3 deleting portions of config in error (migration script).

Adding parent T6543 as contributing factor of issue in comment:
https://vyos.dev/T5991#178786

Wed, Jul 3, 5:45 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro added a subtask for T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error: T5991: 1.4.0-RC3 deleting portions of config in error (migration script).

Wed, Jul 3, 5:43 PM · VyOS 1.5 Circinus

jestabro added a parent task for T5991: 1.4.0-RC3 deleting portions of config in error (migration script): T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error.

Wed, Jul 3, 5:43 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro closed T3875: Known issues with vyatta_net_name/vyatta_interface_rescan as Resolved N/A.

The biosdevname question is a matter for T5603; this task will be closed.

Wed, Jul 3, 5:29 PM

jestabro closed T3875: Known issues with vyatta_net_name/vyatta_interface_rescan, a subtask of T3869: Rewrite vyatta_net_name/vyatta_interface_rescan in Python, as Resolved N/A.

Wed, Jul 3, 5:29 PM · VyOS 1.4 Sagitta

jestabro added a subtask for T5528: Replace legacy loadFile with config_diff: T5400: Move libvyosconfig build out of the Docker image.

Wed, Jul 3, 5:24 PM · VyOS 1.5 Circinus

jestabro added a parent task for T5400: Move libvyosconfig build out of the Docker image: T5528: Replace legacy loadFile with config_diff.

Wed, Jul 3, 5:24 PM · VyOS 1.5 Circinus

jestabro edited projects for T5400: Move libvyosconfig build out of the Docker image, added: VyOS 1.5 Circinus; removed VyOS 1.4 Sagitta (1.4.0-GA).

A version of this change will be part of T5528, only for Circinus initially.

Wed, Jul 3, 5:24 PM · VyOS 1.5 Circinus

jestabro claimed T3441: More intelligent config loading scripts.

Wed, Jul 3, 5:13 PM · VyOS 1.5 Circinus

jestabro created T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error.

Wed, Jul 3, 3:32 PM · VyOS 1.5 Circinus

jestabro added a project to T5366: syslog: remove outdated reference to sysvinit rsyslog file in logrotate template: VyOS 1.5 Circinus.

Wed, Jul 3, 2:31 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta (1.4.1)

jestabro added a comment to T5366: syslog: remove outdated reference to sysvinit rsyslog file in logrotate template.

Spring cleaning PR:
https://github.com/vyos/vyos-1x/pull/3760

Wed, Jul 3, 2:31 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta (1.4.1)

jestabro updated the task description for T5366: syslog: remove outdated reference to sysvinit rsyslog file in logrotate template.

Wed, Jul 3, 2:31 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta (1.4.1)

jestabro moved T5527: Adjust for change in coreutils behavior on overlayfs from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0) board.

Wed, Jul 3, 1:25 PM · VyOS 1.4 Sagitta (1.4.0)

jestabro closed T5527: Adjust for change in coreutils behavior on overlayfs, a subtask of T5520: Likely source of corruption on system update exposed by change in coreutils for Bookworm, as Resolved.

Wed, Jul 3, 1:25 PM · VyOS 1.4 Sagitta

jestabro closed T5527: Adjust for change in coreutils behavior on overlayfs as Resolved.

The critical issue was addressed in T5520, and the matter avoided with the move to revised image tools. No more to do on this at this point, and will close.

Wed, Jul 3, 1:25 PM · VyOS 1.4 Sagitta (1.4.0)

Tue, Jul 2

jestabro closed T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped, a subtask of T5611: Difference in config file after interface MAC changed, as Resolved.

Tue, Jul 2, 8:16 PM · VyOS 1.3 Equuleus (1.3.9)

jestabro closed T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped as Resolved.

Added T5611 as parent task, as it is clearly the root cause from the description above. As mentioned in T5611 the workaround of saving the config on the source system is needed due to incompatibility of the legacy parser.

Tue, Jul 2, 8:16 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro closed T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped, a subtask of T5938: Migration fail root task for 1.4-rc, as Resolved.

Tue, Jul 2, 8:16 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro added a comment to T5611: Difference in config file after interface MAC changed.

Added child/related task T6300; the issue is explained in the above comment and in that task. As has been discussed, the easiest workaround is to save the config on the source image before migrating --- backporting the rewrite of vyatta_net_name/vyatta_interface_rescan to 1.3.x will not resolve the issue for earlier images, so a workaround is needed in those cases.

Tue, Jul 2, 8:14 PM · VyOS 1.3 Equuleus (1.3.9)

jestabro added a subtask for T5611: Difference in config file after interface MAC changed: T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped.

Tue, Jul 2, 8:06 PM · VyOS 1.3 Equuleus (1.3.9)

jestabro added a parent task for T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped: T5611: Difference in config file after interface MAC changed.

Tue, Jul 2, 8:06 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro added a comment to T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration.

Added parent task T5611; the issue is explained in the above comment and in that task. As has been discussed, the easiest workaround is to save the config on the source image before migrating --- backporting the rewrite of vyatta_net_name/vyatta_interface_rescan to 1.3.x, as mentioned in T5611, will not resolve the issue for earlier images, so a workaround is needed in those cases.

Tue, Jul 2, 7:59 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro added a subtask for T5611: Difference in config file after interface MAC changed: T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration.

Tue, Jul 2, 7:53 PM · VyOS 1.3 Equuleus (1.3.9)

jestabro added a parent task for T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration: T5611: Difference in config file after interface MAC changed.

Tue, Jul 2, 7:53 PM · VyOS 1.4 Sagitta (1.4.1)

jestabro moved T6022: set system image default-boot from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0) board.

Tue, Jul 2, 7:49 PM · VyOS 1.4 Sagitta (1.4.0)

jestabro edited projects for T6022: set system image default-boot, added: VyOS 1.4 Sagitta (1.4.0); removed VyOS 1.4 Sagitta (1.4.1).

Tue, Jul 2, 7:48 PM · VyOS 1.4 Sagitta (1.4.0)

jestabro closed T6022: set system image default-boot as Resolved.

As mentioned above, the main regression was fixed; as to the other issue of "‘show system image’ list may not reflect the actual default boot image" I was unable to reproduce originally, but likely fixed as well, as the regression in question corrupted the image list and annotations. Close as fixed; reopen as needed.

Tue, Jul 2, 7:47 PM · VyOS 1.4 Sagitta (1.4.0)

jestabro added a comment to T5528: Replace legacy loadFile with config_diff.

This will be readied for PR without adding the external package vyos1x-adapter; that version has already been completed and will be linked below.

Tue, Jul 2, 6:39 PM · VyOS 1.5 Circinus

jestabro closed T6006: Configure system-specific capabilities independently of migration scripts, a subtask of T3821: Add latest versions to default config files, as Resolved.

Tue, Jul 2, 6:37 PM · VyOS 1.5 Circinus

jestabro closed T6006: Configure system-specific capabilities independently of migration scripts, a subtask of T3275: Disable conntrack helpers by default, as Resolved.

Tue, Jul 2, 6:37 PM · VyOS 1.5 Circinus

jestabro closed T6006: Configure system-specific capabilities independently of migration scripts as Resolved.

Tue, Jul 2, 6:37 PM · VyOS 1.5 Circinus

jestabro closed T6006: Configure system-specific capabilities independently of migration scripts, a subtask of T6007: Improvements to migration system, as Resolved.

Tue, Jul 2, 6:37 PM · VyOS 1.5 Circinus

jestabro closed T6006: Configure system-specific capabilities independently of migration scripts, a subtask of T3824: Ethernet offload options are not populated in new installs, as Resolved.

Tue, Jul 2, 6:37 PM · VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.0-GA), Restricted Project

jestabro closed T6447: Add module for iterating over modifications to a config file as Resolved.

Tue, Jul 2, 6:36 PM · VyOS 1.5 Circinus

jestabro closed T6447: Add module for iterating over modifications to a config file, a subtask of T6006: Configure system-specific capabilities independently of migration scripts, as Resolved.

Tue, Jul 2, 6:36 PM · VyOS 1.5 Circinus

jestabro changed the status of T6447: Add module for iterating over modifications to a config file from Open to Backport candidate.

Tue, Jul 2, 6:34 PM · VyOS 1.5 Circinus

jestabro changed the status of T6447: Add module for iterating over modifications to a config file, a subtask of T6006: Configure system-specific capabilities independently of migration scripts, from Open to Backport candidate.

Tue, Jul 2, 6:34 PM · VyOS 1.5 Circinus

Fri, Jun 28

jestabro added a subtask for T6471: Add an optimized get_config_dict for op-mode: T6531: Extend optimization of op_mode_config_dict to ConfigTreeQuery class.

Fri, Jun 28, 5:14 PM · VyOS 1.5 Circinus

jestabro added a parent task for T6531: Extend optimization of op_mode_config_dict to ConfigTreeQuery class: T6471: Add an optimized get_config_dict for op-mode.

Fri, Jun 28, 5:14 PM · VyOS 1.5 Circinus

jestabro created T6531: Extend optimization of op_mode_config_dict to ConfigTreeQuery class.

Fri, Jun 28, 5:13 PM · VyOS 1.5 Circinus

jestabro changed the status of T6007: Improvements to migration system, a subtask of T6302: The root task for bugs and improvements related to commit time and boot, from In progress to Backport candidate.

Fri, Jun 28, 5:03 PM · VyOS 1.5 Circinus

jestabro changed the status of T6007: Improvements to migration system from In progress to Backport candidate.

PR merged:
https://github.com/vyos/vyos-1x/pull/3692

Fri, Jun 28, 5:03 PM · VyOS 1.5 Circinus

Jun 24 2024

jestabro closed T6504: login: user vyos can not be deleted under vyos-configd as Resolved.

Jun 24 2024, 5:35 PM · VyOS 1.5 Circinus

jestabro closed T6504: login: user vyos can not be deleted under vyos-configd, a subtask of T6489: Add/Improve support for CLI config scripts that change the underlayin actual configuration and make them work with vyos-configd, as Resolved.

Jun 24 2024, 5:35 PM · VyOS 1.5 Circinus

Jun 21 2024

jestabro added a comment to T6504: login: user vyos can not be deleted under vyos-configd.

PR:
https://github.com/vyos/vyos-1x/pull/3701

Jun 21 2024, 7:30 PM · VyOS 1.5 Circinus

jestabro added a comment to T6504: login: user vyos can not be deleted under vyos-configd.

My current understanding, and memory of its introduction, is that the settings os.environ[SUDO_*] were more than needed at the time, with a possible later use in mind: the only critical setting for vyos-configd as a dispatcher of config mode scripts is the preceding line: setgid(cfg_group.gid), allowing the config group access to generated files. Note that the environment variables are not currently used by conf-mode scripts, other than system_login.py, leading to the above bug.

Jun 21 2024, 3:21 AM · VyOS 1.5 Circinus

Jun 20 2024

jestabro changed the status of T6007: Improvements to migration system from Open to In progress.

Draft PR passes configtests; dramatically faster:
https://github.com/vyos/vyos-1x/pull/3692
Minor integration and other testing remain before ready for review.

Jun 20 2024, 1:42 PM · VyOS 1.5 Circinus