Page MenuHomeVyOS Platform

jestabro (John Estabrook)
User

Projects (10)

User Details

User Since
Apr 12 2019, 4:27 PM (301 w, 5 d)

Recent Activity

Yesterday

jestabro closed T7046: Add utilities for update of reference tree, a subtask of T6959: Add support for addons after switch to internal reference tree, as Resolved.
Tue, Jan 21, 11:39 AM · VyOS Rolling
jestabro closed T7046: Add utilities for update of reference tree as Resolved.
Tue, Jan 21, 11:39 AM · VyOS Rolling
jestabro closed T7046: Add utilities for update of reference tree, a subtask of T6946: Add initial commit algorithm to vyconf, as Resolved.
Tue, Jan 21, 11:39 AM · VyOS Rolling
jestabro committed rVYOSONEXdd5f9c19550c: T7046: adjust for distinct reference_tree cache directory.
Tue, Jan 21, 2:15 AM
jestabro committed rVYOSONEXe8d2994adeb6: T7046: normalize formatting.
Tue, Jan 21, 2:15 AM
jestabro committed rVYOSONEXe90a2781f9ea: T7046: add wrappers for reference tree cache utils.
Tue, Jan 21, 2:15 AM

Tue, Jan 14

jestabro added a comment to T7046: Add utilities for update of reference tree.

PRs:
https://github.com/vyos/vyos1x-config/pull/33
https://github.com/vyos/vyconf/pull/13

Tue, Jan 14, 6:46 PM · VyOS Rolling
jestabro added a subtask for T6946: Add initial commit algorithm to vyconf: T7046: Add utilities for update of reference tree.
Tue, Jan 14, 2:08 PM · VyOS Rolling
jestabro added a parent task for T7046: Add utilities for update of reference tree: T6946: Add initial commit algorithm to vyconf.
Tue, Jan 14, 2:08 PM · VyOS Rolling
jestabro added a subtask for T6959: Add support for addons after switch to internal reference tree: T7046: Add utilities for update of reference tree.
Tue, Jan 14, 2:08 PM · VyOS Rolling
jestabro added a parent task for T7046: Add utilities for update of reference tree: T6959: Add support for addons after switch to internal reference tree.
Tue, Jan 14, 2:08 PM · VyOS Rolling
jestabro created T7046: Add utilities for update of reference tree.
Tue, Jan 14, 2:08 PM · VyOS Rolling

Sat, Jan 11

jestabro committed rVYOSONEXd5b1bfc7c900: T7042: drop use of inspect module in favor of ast for source analysis.
Sat, Jan 11, 2:01 PM
jestabro closed T7042: Drop requirement of importing script in build time test test_configd_inspect.py as Resolved.
Sat, Jan 11, 2:00 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a comment to T7042: Drop requirement of importing script in build time test test_configd_inspect.py.

PR:
https://github.com/vyos/vyos-1x/pull/4300

Sat, Jan 11, 4:56 AM · VyOS 1.5 Circinus, VyOS Rolling
jestabro created T7042: Drop requirement of importing script in build time test test_configd_inspect.py.
Sat, Jan 11, 4:27 AM · VyOS 1.5 Circinus, VyOS Rolling

Thu, Jan 9

jestabro closed T7031: Missing 'version' in manifest.json will cause a timeout of 'make test' as Resolved.
Thu, Jan 9, 12:48 PM · VyOS Rolling
jestabro changed Is it a breaking change? from none to compatible on T7031: Missing 'version' in manifest.json will cause a timeout of 'make test'.
Thu, Jan 9, 4:55 AM · VyOS Rolling
jestabro created T7031: Missing 'version' in manifest.json will cause a timeout of 'make test'.
Thu, Jan 9, 4:55 AM · VyOS Rolling

Wed, Jan 8

jestabro moved T7029: Allow wildcard in include directive in interface-definition files from Completed to Backport Candidates on the VyOS Rolling board.
Wed, Jan 8, 11:33 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T7029: Allow wildcard in include directive in interface-definition files as Resolved.
Wed, Jan 8, 11:32 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro committed rVYOSONEX7dfaf94349c1: xml: T7029: allow wildcard in include directive.
Wed, Jan 8, 11:30 PM
jestabro created T7029: Allow wildcard in include directive in interface-definition files.
Wed, Jan 8, 5:27 PM · VyOS 1.5 Circinus, VyOS Rolling

Dec 20 2024

jestabro moved T5976: Allow commit-confirm to use soft-rollback instead of reboot from Need Triage to Completed on the VyOS Rolling board.
Dec 20 2024, 2:27 PM · VyOS Rolling, VyOS 1.5 Circinus
jestabro moved T5976: Allow commit-confirm to use soft-rollback instead of reboot from Backport Candidates to Finished on the VyOS 1.5 Circinus board.
Dec 20 2024, 2:27 PM · VyOS Rolling, VyOS 1.5 Circinus

Dec 19 2024

jestabro claimed T5400: Move libvyosconfig build out of the Docker image.

Discussed and POC to be tested.

Dec 19 2024, 4:58 PM · VyOS Rolling

Dec 18 2024

jestabro added a subtask for T6718: Use vyconf daemon for validation of set commands: T6959: Add support for addons after switch to internal reference tree.
Dec 18 2024, 4:48 PM · VyOS Rolling
jestabro added a parent task for T6959: Add support for addons after switch to internal reference tree: T6718: Use vyconf daemon for validation of set commands.
Dec 18 2024, 4:48 PM · VyOS Rolling
jestabro created T6959: Add support for addons after switch to internal reference tree.
Dec 18 2024, 4:48 PM · VyOS Rolling

Dec 13 2024

jestabro committed rVYOSONEX184e24b7f0a2: vyconf: T6718: start vyconfd from vyos-router.
Dec 13 2024, 2:24 PM
jestabro committed rVYOSONEX40f3a86e697f: vyconf: T6718: set log-file.
Dec 13 2024, 2:24 PM
jestabro committed rVYOSONEX6999f85b2fc1: vyconf: T6718: use vy_set/delete in configsession and util.
Dec 13 2024, 2:24 PM
jestabro committed rVYOSONEX0c4d653fc2db: vyconf: T6718: add boot configs.
Dec 13 2024, 2:24 PM
jestabro committed rVYOSONEXbab186b49314: vyconf: T6718: add reftree internal cache.
Dec 13 2024, 2:24 PM

Dec 11 2024

jestabro added a subtask for T6718: Use vyconf daemon for validation of set commands: T6946: Add initial commit algorithm to vyconf.
Dec 11 2024, 5:51 PM · VyOS Rolling
jestabro added a parent task for T6946: Add initial commit algorithm to vyconf: T6718: Use vyconf daemon for validation of set commands.
Dec 11 2024, 5:51 PM · VyOS Rolling
jestabro created T6946: Add initial commit algorithm to vyconf.
Dec 11 2024, 5:51 PM · VyOS Rolling

Dec 6 2024

jestabro committed rVYOSONEX62edabd26292: vyconf: T6718: add keyword default for change in libvyosconfig binding.
Dec 6 2024, 9:26 PM

Dec 5 2024

jestabro moved T6471: Add an optimized get_config_dict for op-mode from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.1) board.
Dec 5 2024, 3:04 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro closed T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script, a subtask of T6471: Add an optimized get_config_dict for op-mode, as Resolved.
Dec 5 2024, 3:04 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro closed T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script, a subtask of T6797: Root task for remaining 1.4.1 bugs, as Resolved.
Dec 5 2024, 3:04 PM
jestabro closed T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script as Resolved.
Dec 5 2024, 3:04 PM · VyOS 1.4 Sagitta (1.4.1)
jestabro added a subtask for T6471: Add an optimized get_config_dict for op-mode: T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script.
Dec 5 2024, 1:13 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro added a parent task for T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script: T6471: Add an optimized get_config_dict for op-mode.
Dec 5 2024, 1:13 AM · VyOS 1.4 Sagitta (1.4.1)
jestabro added a project to T6471: Add an optimized get_config_dict for op-mode: VyOS 1.4 Sagitta (1.4.1).

Add backport to Sagitta 1.4.1, needed by T6452.

Dec 5 2024, 1:09 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

Dec 4 2024

jestabro added a comment to T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script.

PR:
https://github.com/VyOS-Networks/vyos-1x/pull/142

Dec 4 2024, 8:49 PM · VyOS 1.4 Sagitta (1.4.1)
jestabro added a subtask for T6797: Root task for remaining 1.4.1 bugs: T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script.
Dec 4 2024, 7:57 PM
jestabro added a parent task for T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script: T6797: Root task for remaining 1.4.1 bugs.
Dec 4 2024, 7:57 PM · VyOS 1.4 Sagitta (1.4.1)
jestabro created T6937: Schema generation broken in 1.4.1 due to missing import in op-mode script.
Dec 4 2024, 7:56 PM · VyOS 1.4 Sagitta (1.4.1)
jestabro moved T6929: Update Dockerfile for change in Opam install.sh from Open to Finished on the VyOS 1.4 Sagitta board.
Dec 4 2024, 5:41 PM · VyOS 1.4 Sagitta, VyOS 1.5 Circinus, VyOS Rolling
jestabro moved T6929: Update Dockerfile for change in Opam install.sh from Open to Finished on the VyOS 1.5 Circinus board.
Dec 4 2024, 5:40 PM · VyOS 1.4 Sagitta, VyOS 1.5 Circinus, VyOS Rolling

Dec 3 2024

jestabro added a comment to T6935: Update vyos-http-api-tools for package python-multipart security advisory.

PR:
https://github.com/vyos/vyos-http-api-tools/pull/21
will replace the auto-generated
https://github.com/vyos/vyos-http-api-tools/pull/20

Dec 3 2024, 4:29 PM · VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling
jestabro created T6935: Update vyos-http-api-tools for package python-multipart security advisory.
Dec 3 2024, 4:25 PM · VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling

Dec 2 2024

jestabro moved T6929: Update Dockerfile for change in Opam install.sh from Completed to Backport Candidates on the VyOS Rolling board.
Dec 2 2024, 7:09 PM · VyOS 1.4 Sagitta, VyOS 1.5 Circinus, VyOS Rolling
jestabro moved T6929: Update Dockerfile for change in Opam install.sh from Need Triage to Completed on the VyOS Rolling board.
Dec 2 2024, 7:08 PM · VyOS 1.4 Sagitta, VyOS 1.5 Circinus, VyOS Rolling
jestabro created T6929: Update Dockerfile for change in Opam install.sh.
Dec 2 2024, 5:37 PM · VyOS 1.4 Sagitta, VyOS 1.5 Circinus, VyOS Rolling
jestabro added a subtask for T5976: Allow commit-confirm to use soft-rollback instead of reboot: T6925: Can not remove config-management from config - raises AttributeError.
Dec 2 2024, 2:19 PM · VyOS Rolling, VyOS 1.5 Circinus
jestabro added a parent task for T6925: Can not remove config-management from config - raises AttributeError: T5976: Allow commit-confirm to use soft-rollback instead of reboot.
Dec 2 2024, 2:19 PM · VyOS Rolling, VyOS 1.5 Circinus
jestabro triaged T6925: Can not remove config-management from config - raises AttributeError as Normal priority.

PR:
https://github.com/vyos/vyos-1x/pull/4213

Dec 2 2024, 2:57 AM · VyOS Rolling, VyOS 1.5 Circinus

Nov 30 2024

jestabro claimed T6925: Can not remove config-management from config - raises AttributeError.
Nov 30 2024, 7:56 PM · VyOS Rolling, VyOS 1.5 Circinus

Nov 27 2024

jestabro added a comment to T6902: Commit and Save takes long time when more than 100's ipsec tunnel are already configured.

There is current work that will be replacing the legacy show command, removing this bottleneck; related tasks will link here to keep track of progress.

Nov 27 2024, 4:39 PM · VyOS Rolling

Nov 23 2024

jestabro closed T6811: vyos-configd throws an exception during an image upgrade, a subtask of T6899: Return output from configd in multipart message to maintain resilience on error, as Resolved.
Nov 23 2024, 1:48 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T6811: vyos-configd throws an exception during an image upgrade as Resolved.
Nov 23 2024, 1:48 PM · VyOS Rolling, Bugs

Nov 22 2024

jestabro added a comment to T6811: vyos-configd throws an exception during an image upgrade.

@gadams it may well have been the case that the fragile synchronization before the fix was in fact a cause of the problem, at least in some (all ?) cases. I expected however, that any other config error on boot could also trigger the complaint in vyos-configd, which would consequently drop any useful output. With the original change in T6326 and the fix in T6899, any output (error or otherwise) should now be robust and generally available (notably, through the http-api, which was the motivation to finally fix the output workaround for T6326).

Nov 22 2024, 6:26 PM · VyOS Rolling, Bugs
jestabro added a comment to T6811: vyos-configd throws an exception during an image upgrade.

@gadams I agree with 2, as becomes apparent in the current situation: it is misleading and should be changed so as to avoid confusion. If you want to take it up, that would be great; thanks. Regarding 1, if you are seeing boot hangs on a system with the above fix, we will need to investigate: I have not encountered it, so I can try to reproduce with the following information: rolling version; sanitized config; platform (vm or hardware). I suggest opening as a separate task, as the forum reports so far (unless I'm mistaken) have pointed to this one. Thanks again for the info.

Nov 22 2024, 4:53 PM · VyOS Rolling, Bugs
jestabro added a comment to T6811: vyos-configd throws an exception during an image upgrade.

@opswill I suggest closing this task and opening a separate task focused on the specific continuing issue.

Nov 22 2024, 4:23 PM · VyOS Rolling, Bugs
jestabro closed T6899: Return output from configd in multipart message to maintain resilience on error as Resolved.

This is resolved for rolling, and not applicable to Circinus until backport of T6326.

Nov 22 2024, 4:22 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a comment to T6811: vyos-configd throws an exception during an image upgrade.

@opswill Yes, those debug messages report that vyos-configd is operating correctly: error_code 1 is 'success' in the enum list. Consequently, the obscuring error in vyos-configd has been resolved, and the root cause of your issue can now be investigated ...

Nov 22 2024, 1:00 PM · VyOS Rolling, Bugs

Nov 21 2024

jestabro added a comment to T6907: [op-commands] encrypted/hidden sensible information in 'show configuration'.

So yes, that's the idea, and the tools are there for a simple implementation (done in May, rebased now for comparison):
https://github.com/vyos/vyos-1x/compare/current...jestabro:example-property-secret

Nov 21 2024, 9:38 PM · VyOS 1.4 Sagitta, VyOS 1.5 Circinus
jestabro moved T6900: Remove op-mode 'show configuration files' as misleading from Need Triage to Completed on the VyOS Rolling board.
Nov 21 2024, 11:47 AM · VyOS 1.5 Circinus, VyOS Rolling
jestabro committed rVYOSONEXeceb410fd5e7: op-mode: T6900: remove uninformative 'show configuration files'.
Nov 21 2024, 11:28 AM
jestabro added a comment to T6900: Remove op-mode 'show configuration files' as misleading.

PR:
https://github.com/vyos/vyos-1x/pull/4202

Nov 21 2024, 1:03 AM · VyOS 1.5 Circinus, VyOS Rolling

Nov 20 2024

jestabro added a comment to T6718: Use vyconf daemon for validation of set commands.

The first three PRs above have been merged, and the next in sequence (https://github.com/vyos/libvyosconfig/pull/21) opened for review.

Nov 20 2024, 7:24 PM · VyOS Rolling
jestabro added a comment to T6811: vyos-configd throws an exception during an image upgrade.

T6899 merged; when rolling available, kindly retest. Thanks !

Nov 20 2024, 6:06 PM · VyOS Rolling, Bugs
jestabro added a comment to T6899: Return output from configd in multipart message to maintain resilience on error.

This will be squashed with https://vyos.dev/T6326 for backport to Circinus, after confirmation.

Nov 20 2024, 6:06 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a comment to T6326: Specific error is not returned via the HTTP API during a configuration failure..

This will need the fix in https://vyos.dev/T6899 for backport to Circinus.

Nov 20 2024, 6:04 PM · VyOS Rolling, Bugs, VyOS 1.5 Circinus
jestabro committed rVYOSONEXf38a402f158d: configd: T6899: use multipart message instead of extra exchange.
Nov 20 2024, 6:00 PM

Nov 19 2024

jestabro added a comment to T6811: vyos-configd throws an exception during an image upgrade.

Thanks @gadams , and yes that was also mentioned in the forum discussion here:
https://forum.vyos.io/t/vyos-sometimes-does-not-start-properly/15486
I believe the correction made in the PR for the parent task T6899 should help reveal/resolve the issue.

Nov 19 2024, 5:18 PM · VyOS Rolling, Bugs
jestabro updated the task description for T6900: Remove op-mode 'show configuration files' as misleading.
Nov 19 2024, 2:58 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro claimed T6900: Remove op-mode 'show configuration files' as misleading.
Nov 19 2024, 1:27 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro created T6900: Remove op-mode 'show configuration files' as misleading.
Nov 19 2024, 1:26 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro triaged T6899: Return output from configd in multipart message to maintain resilience on error as High priority.
Nov 19 2024, 12:58 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a comment to T6811: vyos-configd throws an exception during an image upgrade.

The PR for the parent task:
https://vyos.dev/T6899
will avoid obscuring underlying errors. Revisit after merge of above.

Nov 19 2024, 12:57 PM · VyOS Rolling, Bugs
jestabro added a comment to T6899: Return output from configd in multipart message to maintain resilience on error.

PR:
https://github.com/vyos/vyos-1x/pull/4197

Nov 19 2024, 12:55 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a subtask for T6899: Return output from configd in multipart message to maintain resilience on error: T6811: vyos-configd throws an exception during an image upgrade.
Nov 19 2024, 12:50 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a parent task for T6811: vyos-configd throws an exception during an image upgrade: T6899: Return output from configd in multipart message to maintain resilience on error.
Nov 19 2024, 12:50 PM · VyOS Rolling, Bugs
jestabro created T6899: Return output from configd in multipart message to maintain resilience on error.
Nov 19 2024, 12:45 PM · VyOS 1.5 Circinus, VyOS Rolling

Nov 15 2024

jestabro moved T6076: [1.3.3->1.4.0-epa1 Migration] Most of config missing from Open to Finished on the VyOS 1.5 Circinus board.
Nov 15 2024, 8:44 PM · Bugs, VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro closed T6076: [1.3.3->1.4.0-epa1 Migration] Most of config missing as Resolved.

As covered in last comment, all matters have been addressed, but for (then) open question re firewall migration. If that recurs, or still present, we will open a specific task.

Nov 15 2024, 8:43 PM · Bugs, VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro closed T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration, a subtask of T5611: Difference in config file after interface MAC changed, as Resolved.
Nov 15 2024, 8:40 PM · VyOS Rolling, Bugs
jestabro closed T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration, a subtask of T5938: Migration fail root task for 1.4-rc, as Resolved.
Nov 15 2024, 8:40 PM · VyOS Rolling, Bugs
jestabro closed T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration as Resolved.

As discussed a workaround is available, and preferable to the danger over usefulness of backporting to 1.3.x.

Nov 15 2024, 8:40 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro added a comment to T5991: 1.4.0-RC3 deleting portions of config in error (migration script).

Adding that the long standing issue in T6543 is being addressed in the work of T6718, which provides a replacement to legacy loadConfig; the legacy code will not be corrected.

Nov 15 2024, 8:35 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro added a comment to T6783: Update vyos-http-api-tools for package Starlette security advisory.

The only piece remaining here is a backport for Equuleus.

Nov 15 2024, 8:29 PM · Bugs, VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T5991: 1.4.0-RC3 deleting portions of config in error (migration script), a subtask of T6131: Disabling openvpn interface(s) causes OSPF to fail to load on reboot, as Resolved.
Nov 15 2024, 8:28 PM · VyOS 1.4 Sagitta (1.4.0-epa3)
jestabro closed T5991: 1.4.0-RC3 deleting portions of config in error (migration script) as Resolved.

The specific high priority issue here was addressed in T6131; the general question of support for ZeroTier is in T6455. Closing this task as stated.

Nov 15 2024, 8:28 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro closed T5991: 1.4.0-RC3 deleting portions of config in error (migration script), a subtask of T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error, as Resolved.
Nov 15 2024, 8:28 PM · VyOS Rolling, Bugs
jestabro changed the status of T6531: Extend optimization of op_mode_config_dict to ConfigTreeQuery class, a subtask of T6471: Add an optimized get_config_dict for op-mode, from Open to On hold.
Nov 15 2024, 8:11 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro changed the status of T6531: Extend optimization of op_mode_config_dict to ConfigTreeQuery class from Open to On hold.

This will have a simple solution as a corollary of the work T6718: put on hold for now, pending restatement in terms of that work.

Nov 15 2024, 8:11 PM · VyOS Rolling
jestabro raised the priority of T6811: vyos-configd throws an exception during an image upgrade from Normal to High.
Nov 15 2024, 7:49 PM · VyOS Rolling, Bugs