Page MenuHomeVyOS Platform

jestabro (John Estabrook)
User

Projects (9)

User Details

User Since
Apr 12 2019, 4:27 PM (289 w, 14 h)

Recent Activity

Today

jestabro added a comment to T6718: Use vyconf daemon for validation of set commands.

PR list below; after the first two are reviewed/merged, the others can be moved out of draft, in order of dependencies.
https://github.com/vyos/vyconf/pull/11
https://github.com/vyos/vyos1x-config/pull/31
https://github.com/vyos/vyatta-cfg/pull/94
https://github.com/vyos/libvyosconfig/pull/21
https://github.com/vyos/vyos-1x/pull/4176
https://github.com/vyos/vyos-build/pull/824

Sat, Oct 26, 4:46 AM · VyOS 1.5 Circinus, VyOS Rolling

Yesterday

jestabro claimed T6811: vyos-configd throws an exception during an image upgrade.
Fri, Oct 25, 6:11 PM · Restricted Project, VyOS 1.5 Circinus

Thu, Oct 24

jestabro added a comment to T6718: Use vyconf daemon for validation of set commands.

Updated repos below; one minor change needed for replacements to my_set/my_delete before PR:

Thu, Oct 24, 5:12 PM · VyOS 1.5 Circinus, VyOS Rolling

Tue, Oct 22

jestabro lowered the priority of T6608: configd should report exceptions uncaught by conf_mode scripts as commit error from High to Normal.
Tue, Oct 22, 7:06 PM · Restricted Project, VyOS 1.5 Circinus, VyOS Rolling
jestabro reopened T6608: configd should report exceptions uncaught by conf_mode scripts as commit error as "Open".
Tue, Oct 22, 7:04 PM · Restricted Project, VyOS 1.5 Circinus, VyOS Rolling
jestabro moved T6783: Update vyos-http-api-tools for package Starlette security advisory from Need Triage to Completed on the VyOS Rolling board.
Tue, Oct 22, 3:47 PM · Restricted Project, VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling
jestabro moved T6783: Update vyos-http-api-tools for package Starlette security advisory from Open to Finished on the VyOS 1.5 Circinus board.
Tue, Oct 22, 3:47 PM · Restricted Project, VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling
jestabro moved T6783: Update vyos-http-api-tools for package Starlette security advisory from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.1) board.
Tue, Oct 22, 3:47 PM · Restricted Project, VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling

Tue, Oct 15

jestabro renamed T6783: Update vyos-http-api-tools for package Starlette security advisory from Update vyos-http-api-tools for packages Starlette security advisory to Update vyos-http-api-tools for package Starlette security advisory.
Tue, Oct 15, 11:57 PM · Restricted Project, VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling
jestabro added a comment to T6783: Update vyos-http-api-tools for package Starlette security advisory.

PR for current/Circinus/Sagitta:
https://github.com/vyos/vyos-http-api-tools/pull/19

Tue, Oct 15, 11:50 PM · Restricted Project, VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling
jestabro created T6783: Update vyos-http-api-tools for package Starlette security advisory.
Tue, Oct 15, 11:22 PM · Restricted Project, VyOS 1.3 Equuleus (1.3.9), VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling

Mon, Oct 14

jestabro added a comment to T6718: Use vyconf daemon for validation of set commands.

Vyconfd running all validators in links above; integration with T6717 remaining to complete before PR.

Mon, Oct 14, 1:41 PM · VyOS 1.5 Circinus, VyOS Rolling

Tue, Oct 8

jestabro closed T5976: Allow commit-confirm to use soft-rollback instead of reboot, a subtask of T5249: Add rollback-soft feature to rollback without a reboot, as Unknown Status.
Tue, Oct 8, 9:58 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta
jestabro closed T5976: Allow commit-confirm to use soft-rollback instead of reboot as Unknown Status.
Tue, Oct 8, 9:58 PM · VyOS Rolling, VyOS 1.5 Circinus
jestabro closed T5976: Allow commit-confirm to use soft-rollback instead of reboot, a subtask of T5843: Rollback refactoring, as Unknown Status.
Tue, Oct 8, 9:58 PM · VyOS Rolling, VyOS 1.5 Circinus
jestabro committed rVYOSONEX4d5f2a58bbf5: config-mgmt: T5976: add option for commit-confirm to use 'soft' rollback.
Tue, Oct 8, 9:57 PM
jestabro committed rVYOSONEXf9c81b121b14: config-mgmt: T5976: normalize formatting.
Tue, Oct 8, 9:57 PM
jestabro committed rVYOSONEX64196ec5fd90: config-mgmt: T5976: move commit-confirm revert action to subnode.
Tue, Oct 8, 9:57 PM
jestabro committed rVYOSONEXdfba19b3e89f: config-mgmt: T5976: display message when reverting to previous config.
Tue, Oct 8, 9:57 PM

Mon, Oct 7

jestabro assigned T4318: Add ability to mark nodes as non-tag nodes to natali-rs1985.
Mon, Oct 7, 8:37 PM · Restricted Project, VyOS 1.5 Circinus, Restricted Project
jestabro committed rVYOSONEXd979117ff998: vyos.configtree: T4318: Allow set tag flag to true or false (authored by natali-rs1985).
Mon, Oct 7, 8:35 PM

Fri, Oct 4

jestabro changed the status of T3955: Allow commit-confirm through http API, a subtask of T5263: Generalization of REST configure endpoint, from In progress to Open.
Fri, Oct 4, 5:36 PM · VyOS 1.4 Sagitta
jestabro changed the status of T3955: Allow commit-confirm through http API, a subtask of T4942: Rewrite vyatta-config-mgmt to Python/XML, from In progress to Open.
Fri, Oct 4, 5:36 PM · VyOS 1.4 Sagitta
jestabro changed the status of T3955: Allow commit-confirm through http API from In progress to Open.
Fri, Oct 4, 5:36 PM · VyOS 1.5 Circinus
jestabro changed the status of T3955: Allow commit-confirm through http API, a subtask of T5976: Allow commit-confirm to use soft-rollback instead of reboot, from In progress to Open.
Fri, Oct 4, 5:36 PM · VyOS Rolling, VyOS 1.5 Circinus
jestabro claimed T3955: Allow commit-confirm through http API.
Fri, Oct 4, 5:36 PM · VyOS 1.5 Circinus
jestabro added a subtask for T5976: Allow commit-confirm to use soft-rollback instead of reboot: T3955: Allow commit-confirm through http API.
Fri, Oct 4, 5:36 PM · VyOS Rolling, VyOS 1.5 Circinus
jestabro added a parent task for T3955: Allow commit-confirm through http API: T5976: Allow commit-confirm to use soft-rollback instead of reboot.
Fri, Oct 4, 5:36 PM · VyOS 1.5 Circinus
jestabro added a comment to T5976: Allow commit-confirm to use soft-rollback instead of reboot.

PR:
https://github.com/vyos/vyos-1x/pull/4128

Fri, Oct 4, 5:23 PM · VyOS Rolling, VyOS 1.5 Circinus
jestabro closed T6736: Make REST api and GraphQL api distinct nodes as Unknown Status.
Fri, Oct 4, 4:15 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro committed rVYOSONEX3ad911a20620: http-api: T6736: update for deprecated/renamed in Pydantic V2.
Fri, Oct 4, 11:45 AM
jestabro committed rVYOSONEX954be34bc938: http-api: T6736: remove routes on config delete.
Fri, Oct 4, 11:45 AM
jestabro committed rVYOSONEXfc9885f85961: http-api: T6736: separate REST API and GraphQL API activation.
Fri, Oct 4, 11:45 AM
jestabro committed rVYOSONEX9f7767c8022f: http-api: T6736: regenerate openapi docs.
Fri, Oct 4, 11:45 AM
jestabro committed rVYOSONEX8322cc4d8206: http-api: T6736: update smoketest for syntax change.
Fri, Oct 4, 11:45 AM
jestabro committed rVYOSONEX8183e2cc8178: http-api: T6736: add distinct XML path for REST API.
Fri, Oct 4, 11:45 AM
jestabro committed rVYOSONEX40d966310cb5: http-api: T6736: add migration script and update version.
Fri, Oct 4, 11:45 AM
jestabro committed rVYOSONEX7e23fd9da028: http-api: T6736: normalize formatting.
Fri, Oct 4, 11:45 AM
jestabro committed rVYOSONEXc21fa1fb7726: http-api: T6736: sanitize error message containing user input.
Fri, Oct 4, 11:45 AM

Mon, Sep 30

jestabro added a comment to T6736: Make REST api and GraphQL api distinct nodes.

PR:
https://github.com/vyos/vyos-1x/pull/4110

Mon, Sep 30, 3:47 AM · VyOS 1.5 Circinus, VyOS Rolling

Fri, Sep 27

jestabro updated subscribers of T6716: Offload settings are being automatically updated to reflect kernel settings.

@doctorpangloss I see from the other forum thread:
https://forum.vyos.io/t/something-keeps-adding-offloads-back-to-my-interface-breaking-my-wan/15282/7
that @n.fort has confirmed the persistence of the fix.

Fri, Sep 27, 3:45 PM · Restricted Project, VyOS 1.5 Circinus

Sep 25 2024

jestabro changed the status of T6736: Make REST api and GraphQL api distinct nodes from Open to In progress.

PR to follow tests and migration script:
https://github.com/vyos/vyos-1x/compare/current...jestabro:distinct-api

Sep 25 2024, 2:00 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T6608: configd should report exceptions uncaught by conf_mode scripts as commit error as Unknown Status.
Sep 25 2024, 1:32 PM · Restricted Project, VyOS 1.5 Circinus, VyOS Rolling
jestabro committed rVYOSONEX5034db86b8c4: configd: T6608: report uncaught config script exceptions as commit error.
Sep 25 2024, 1:31 PM
jestabro created T6736: Make REST api and GraphQL api distinct nodes.
Sep 25 2024, 3:47 AM · VyOS 1.5 Circinus, VyOS Rolling

Sep 22 2024

jestabro added a comment to T6608: configd should report exceptions uncaught by conf_mode scripts as commit error.

PR ready for review:
https://github.com/vyos/vyos-1x/pull/3876

Sep 22 2024, 7:57 PM · Restricted Project, VyOS 1.5 Circinus, VyOS Rolling

Sep 21 2024

jestabro closed T6326: Specific error is not returned via the HTTP API during a configuration failure. as Unknown Status.
Sep 21 2024, 12:12 AM · VyOS Rolling, Restricted Project, VyOS 1.5 Circinus

Sep 20 2024

jestabro committed rVYOSONEX8e902ffa7019: http-api: T6326: return full warning/error output through api.
Sep 20 2024, 8:29 PM
jestabro added a comment to T6326: Specific error is not returned via the HTTP API during a configuration failure..

PR:
https://github.com/vyos/vyos-1x/pull/4090

Sep 20 2024, 4:39 PM · VyOS Rolling, Restricted Project, VyOS 1.5 Circinus

Sep 19 2024

jestabro changed the status of T6326: Specific error is not returned via the HTTP API during a configuration failure. from Open to In progress.

Running smoketests before PR:
https://github.com/jestabro/vyos-1x/tree/configd-err-out

Sep 19 2024, 5:43 PM · VyOS Rolling, Restricted Project, VyOS 1.5 Circinus

Sep 18 2024

jestabro changed the status of T6716: Offload settings are being automatically updated to reflect kernel settings from Unknown Status to Resolved.
Sep 18 2024, 3:51 AM · Restricted Project, VyOS 1.5 Circinus
jestabro changed the status of T6716: Offload settings are being automatically updated to reflect kernel settings, a subtask of T6006: Configure system-specific capabilities independently of migration scripts, from Unknown Status to Resolved.
Sep 18 2024, 3:51 AM · VyOS 1.5 Circinus

Sep 17 2024

jestabro closed T6716: Offload settings are being automatically updated to reflect kernel settings, a subtask of T6006: Configure system-specific capabilities independently of migration scripts, as Unknown Status.
Sep 17 2024, 8:23 PM · VyOS 1.5 Circinus
jestabro closed T6716: Offload settings are being automatically updated to reflect kernel settings as Unknown Status.
Sep 17 2024, 8:23 PM · Restricted Project, VyOS 1.5 Circinus
jestabro added a comment to T6688: SNMPv3 set by HTTP API failed.

I am not yet able to reproduce this in either case. @c-po suggestion of an interaction with the introduction of vyos.utils.configfs is quite reasonable, but I have not reproduced in current rolling or an image earlier than the recent changes (T6633, T6640) to resolve T6639. I've asked the forum user of the second report for further information.

Sep 17 2024, 8:19 PM · Restricted Project, VyOS Rolling, VyOS 1.5 Circinus
jestabro claimed T6326: Specific error is not returned via the HTTP API during a configuration failure..
Sep 17 2024, 7:51 PM · VyOS Rolling, Restricted Project, VyOS 1.5 Circinus
jestabro added a comment to T6688: SNMPv3 set by HTTP API failed.

Also reported:
https://forum.vyos.io/t/container-set-by-http-api-failed/15248/2

Sep 17 2024, 6:22 PM · Restricted Project, VyOS Rolling, VyOS 1.5 Circinus
jestabro added a comment to T6716: Offload settings are being automatically updated to reflect kernel settings.

Yes this is a known, annoying, bug that had not yet been addressed following T6006. One suggestion I have added to your PR is to only set in config in the case of live boot: after installation, activation will not enable against user settings; it will still disable if say, hardware capabilities disappear.

Sep 17 2024, 2:09 PM · Restricted Project, VyOS 1.5 Circinus
jestabro added a parent task for T6716: Offload settings are being automatically updated to reflect kernel settings: T6006: Configure system-specific capabilities independently of migration scripts.
Sep 17 2024, 2:02 PM · Restricted Project, VyOS 1.5 Circinus
jestabro added a subtask for T6006: Configure system-specific capabilities independently of migration scripts: T6716: Offload settings are being automatically updated to reflect kernel settings.
Sep 17 2024, 2:02 PM · VyOS 1.5 Circinus

Sep 16 2024

jestabro updated the task description for T6717: Add hybrid Cstore manipulation library to replace set/delete/load_config functionality.
Sep 16 2024, 12:21 AM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a comment to T6718: Use vyconf daemon for validation of set commands.

WIP:
https://github.com/jestabro/vyconf/tree/minimal-with-validators
https://github.com/vyos/vyconf/compare/master...jestabro:vyconf:minimal-with-validators

Sep 16 2024, 12:21 AM · VyOS 1.5 Circinus, VyOS Rolling

Sep 15 2024

jestabro created T6718: Use vyconf daemon for validation of set commands.
Sep 15 2024, 11:31 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a comment to T5528: Replace legacy loadFile with config_diff.

This work has been generalized and simplified for use with the minimal vyconf daemon:
https://vyos.dev/T6717

Sep 15 2024, 11:11 PM · VyOS 1.5 Circinus
jestabro added a comment to T6717: Add hybrid Cstore manipulation library to replace set/delete/load_config functionality.

https://github.com/jestabro/vyatta-cfg/tree/vy-adapter-external-ctypes
https://github.com/vyos/vyatta-cfg/compare/current...jestabro:vyatta-cfg:vy-adapter-external-ctypes

Sep 15 2024, 11:09 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro created T6717: Add hybrid Cstore manipulation library to replace set/delete/load_config functionality.
Sep 15 2024, 11:09 PM · VyOS 1.5 Circinus, VyOS Rolling

Sep 13 2024

jestabro changed the status of T6007: Improvements to migration system, a subtask of T6302: The root task for bugs and improvements related to commit time and boot, from Unknown Status to Resolved.
Sep 13 2024, 3:27 PM · Restricted Project, VyOS 1.5 Circinus
jestabro changed the status of T6007: Improvements to migration system from Unknown Status to Resolved.
Sep 13 2024, 3:27 PM · VyOS 1.5 Circinus
jestabro closed T6710: Migration scripts fails for the circinus as Resolved.
Sep 13 2024, 3:26 PM · VyOS 1.5 Circinus
jestabro closed T6710: Migration scripts fails for the circinus, a subtask of T6007: Improvements to migration system, as Resolved.
Sep 13 2024, 3:26 PM · VyOS 1.5 Circinus

Sep 12 2024

jestabro committed rVYOSONEX461195c5046d: vyos.utils.dict: T5195: fix syntax warning.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX03fdc2302531: migration: T6447: add traceback on error.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXccff9ffdd8e3: migration: T6007: update migration class.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXb5db9395ed57: migration: T6007: convert all migration scripts to load as module.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX4091432eb99f: migration: T6007: add version object for config file and system.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX98314d5c7513: migration: T6447: fix missing check before reset to checkpoint.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXa79237bb168e: migration: T6007: use load_as_module_source for files without extension.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX309260f7eeb6: migration: T6007: add exception in base for use by migration files.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXfe810a0fe316: migration: T6007: write configtree operations to log.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXd17304ba5e93: migration: T6007: update vyos-load-config.py.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXefe2508f8912: migration: T6007: update vyos-merge-config.py.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX9ed150798a83: migration: T6007: update load_config.py.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXb82cd064b0fc: migration: T6007: update vyos_net_name.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX0f5001de97f4: migration: T6007: update run-config-migration script.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX70720e5f3d86: migration: T6007: add util add_system_version to replace *_system_footer.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX34e3eda93b4b: migration: T6007: remove obsoleted.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEX6bc1aff55e29: migration: T6007: fix cosmetic issue of extra newline.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXf7f51060f38b: migration: T6007: drop restrictive perms, already set on config.boot.
Sep 12 2024, 12:59 PM
jestabro committed rVYOSONEXeaa9c82670fa: migration: T6007: add missing check for None in utility function.
Sep 12 2024, 12:59 PM
jestabro added a comment to T6007: Improvements to migration system.

PR for backport to circinus:
https://github.com/vyos/vyos-1x/pull/4050

Sep 12 2024, 12:49 AM · VyOS 1.5 Circinus
jestabro added a comment to T6710: Migration scripts fails for the circinus.

PR for circinus:
https://github.com/vyos/vyos-1x/pull/4050

Sep 12 2024, 12:48 AM · VyOS 1.5 Circinus

Sep 11 2024

jestabro added a parent task for T6710: Migration scripts fails for the circinus: T6007: Improvements to migration system.
Sep 11 2024, 6:02 PM · VyOS 1.5 Circinus
jestabro added a subtask for T6007: Improvements to migration system: T6710: Migration scripts fails for the circinus.
Sep 11 2024, 6:02 PM · VyOS 1.5 Circinus
jestabro changed the status of T6710: Migration scripts fails for the circinus from Open to In progress.

Backport of https://github.com/vyos/vyos-1x/pull/3692 in progress.

Sep 11 2024, 4:12 PM · VyOS 1.5 Circinus
jestabro claimed T6710: Migration scripts fails for the circinus.
Sep 11 2024, 1:20 PM · VyOS 1.5 Circinus

Sep 7 2024

jestabro triaged T6704: [vyos-1x] unlimited _noteworthy in vyos.airbag cause memory leak as High priority.
Sep 7 2024, 11:40 PM · Restricted Project, VyOS 1.3 Equuleus, VyOS 1.4 Sagitta, VyOS 1.5 Circinus
jestabro claimed T6704: [vyos-1x] unlimited _noteworthy in vyos.airbag cause memory leak.
Sep 7 2024, 6:37 PM · Restricted Project, VyOS 1.3 Equuleus, VyOS 1.4 Sagitta, VyOS 1.5 Circinus

Sep 3 2024

jestabro added a comment to T6697: "force commit-archive" doesn't work anymore.

The script exists, under the same name, iff configured:
https://github.com/vyos/vyos-1x/blob/current/python/vyos/config_mgmt.py#L52-L53
https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/system_config-management.py#L52-L64

Sep 3 2024, 3:10 PM · Restricted Project, VyOS 1.5 Circinus

Aug 26 2024

jestabro moved T5666: Provide list of config-mode scripts scheduled for proposed commit from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.1) board.
Aug 26 2024, 4:47 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro closed T5666: Provide list of config-mode scripts scheduled for proposed commit, a subtask of T5492: CLI node priority is not inversed on node deletion, as Resolved.
Aug 26 2024, 4:47 PM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta