Page MenuHomeVyOS Platform

jestabro (John Estabrook)
User

Projects

User Details

User Since
Apr 12 2019, 4:27 PM (207 w, 22 h)

Recent Activity

Yesterday

jestabro closed T5126: http-api: add 'allow-client' to restrict IP address of client connections as Resolved.
Fri, Mar 31, 9:03 PM · VyOS 1.4 Sagitta

Thu, Mar 30

jestabro closed T4866: Rewrite show_interfaces to standardized form as Resolved.
Thu, Mar 30, 7:55 PM · VyOS 1.4 Sagitta
jestabro closed T4866: Rewrite show_interfaces to standardized form, a subtask of T4564: Root task for rewriting [op-mode] to vyos.opmode format, as Resolved.
Thu, Mar 30, 7:55 PM · VyOS 1.4 Sagitta
jestabro closed T5130: op-mode: drop remaining reference to obsoleted 'show_interfaces.py', a subtask of T4866: Rewrite show_interfaces to standardized form, as Resolved.
Thu, Mar 30, 7:54 PM · VyOS 1.4 Sagitta
jestabro closed T5130: op-mode: drop remaining reference to obsoleted 'show_interfaces.py', a subtask of T4885: Rewrite 'clear interfaces counters' from Perl to Python, as Resolved.
Thu, Mar 30, 7:54 PM · VyOS 1.4 Sagitta
jestabro closed T5130: op-mode: drop remaining reference to obsoleted 'show_interfaces.py' as Resolved.
Thu, Mar 30, 7:54 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5130: op-mode: drop remaining reference to obsoleted 'show_interfaces.py'.

PR's:
https://github.com/vyos/vyatta-op/pull/60
https://github.com/vyos/vyos-1x/pull/1923

Thu, Mar 30, 7:41 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T4866: Rewrite show_interfaces to standardized form: T5130: op-mode: drop remaining reference to obsoleted 'show_interfaces.py'.
Thu, Mar 30, 7:10 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T4885: Rewrite 'clear interfaces counters' from Perl to Python: T5130: op-mode: drop remaining reference to obsoleted 'show_interfaces.py'.
Thu, Mar 30, 7:10 PM · VyOS 1.4 Sagitta
jestabro added parent tasks for T5130: op-mode: drop remaining reference to obsoleted 'show_interfaces.py': T4866: Rewrite show_interfaces to standardized form, T4885: Rewrite 'clear interfaces counters' from Perl to Python.
Thu, Mar 30, 7:10 PM · VyOS 1.4 Sagitta
jestabro triaged T5130: op-mode: drop remaining reference to obsoleted 'show_interfaces.py' as Normal priority.
Thu, Mar 30, 7:09 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5126: http-api: add 'allow-client' to restrict IP address of client connections.

PR:
https://github.com/vyos/vyos-1x/pull/1920

Thu, Mar 30, 1:00 AM · VyOS 1.4 Sagitta
jestabro triaged T5126: http-api: add 'allow-client' to restrict IP address of client connections as Normal priority.
Thu, Mar 30, 12:56 AM · VyOS 1.4 Sagitta

Wed, Mar 29

jestabro closed T5089: Add unit test of config_diff, a subtask of T5087: Add support for lexical ordering of nodes in config_tree, as Resolved.
Wed, Mar 29, 7:17 PM · VyOS 1.4 Sagitta
jestabro closed T5089: Add unit test of config_diff as Resolved.
Wed, Mar 29, 7:17 PM · VyOS 1.4 Sagitta
jestabro moved T5097: the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters' from Need Triage to Finished on the VyOS 1.3 Equuleus board.
Wed, Mar 29, 7:16 PM · VyOS 1.4 Sagitta, VyOS 1.3 Equuleus
jestabro closed T5097: the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters' as Resolved.
Wed, Mar 29, 7:16 PM · VyOS 1.4 Sagitta, VyOS 1.3 Equuleus
jestabro closed T5088: Add lexicographical-numeric compare function for vytree/configtree, a subtask of T5087: Add support for lexical ordering of nodes in config_tree, as Resolved.
Wed, Mar 29, 3:48 PM · VyOS 1.4 Sagitta
jestabro closed T5088: Add lexicographical-numeric compare function for vytree/configtree as Resolved.
Wed, Mar 29, 3:48 PM · VyOS 1.4 Sagitta
jestabro closed T5087: Add support for lexical ordering of nodes in config_tree as Resolved.
Wed, Mar 29, 3:48 PM · VyOS 1.4 Sagitta
jestabro closed T4885: Rewrite 'clear interfaces counters' from Perl to Python, a subtask of T4866: Rewrite show_interfaces to standardized form, as Resolved.
Wed, Mar 29, 1:53 PM · VyOS 1.4 Sagitta
jestabro closed T4885: Rewrite 'clear interfaces counters' from Perl to Python as Resolved.
Wed, Mar 29, 1:53 PM · VyOS 1.4 Sagitta

Tue, Mar 28

jestabro added a comment to T4885: Rewrite 'clear interfaces counters' from Perl to Python.

PR's:
https://github.com/vyos/vyatta-op/pull/59
https://github.com/vyos/vyos-1x/pull/1916

Tue, Mar 28, 7:18 PM · VyOS 1.4 Sagitta

Mon, Mar 27

jestabro added a comment to T4770: Rewrite OpenVPN op-mode to vyos.opmode format.

Fix pushed to current:
f8522f323
and updated on test server.

Mon, Mar 27, 5:08 PM · VyOS 1.4 Sagitta
jestabro closed T5106: Extend generation of API client requests to configsession native functions and composite requests as Resolved.
Mon, Mar 27, 2:11 PM · VyOS 1.4 Sagitta
jestabro closed T5106: Extend generation of API client requests to configsession native functions and composite requests, a subtask of T5068: Generate op-mode API client requests along with schema generation, as Resolved.
Mon, Mar 27, 2:11 PM · VyOS 1.4 Sagitta

Fri, Mar 24

jestabro renamed T5097: the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters' from the operational command "show interfaces ethernet ethx" doesn't show when clears counts to the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters'.
Fri, Mar 24, 12:37 AM · VyOS 1.4 Sagitta, VyOS 1.3 Equuleus
jestabro changed the status of T5097: the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters' from Open to In progress.
Fri, Mar 24, 12:37 AM · VyOS 1.4 Sagitta, VyOS 1.3 Equuleus
jestabro added a comment to T5097: the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters'.

PR for 1.4:
https://github.com/vyos/vyos-1x/pull/1911
PR for 1.3:
https://github.com/vyos/vyos-1x/pull/1912

Fri, Mar 24, 12:35 AM · VyOS 1.4 Sagitta, VyOS 1.3 Equuleus

Thu, Mar 23

jestabro closed T5107: Raise error in op-mode dns.py instead of calling exit as Resolved.
Thu, Mar 23, 1:33 PM · VyOS 1.4 Sagitta
jestabro renamed T5107: Raise error in op-mode dns.py instead of calling exit from Raise error in op-mode dns.py instead of exit to Raise error in op-mode dns.py instead of calling exit.
Thu, Mar 23, 1:29 PM · VyOS 1.4 Sagitta
jestabro triaged T5107: Raise error in op-mode dns.py instead of calling exit as Normal priority.
Thu, Mar 23, 1:27 PM · VyOS 1.4 Sagitta

Wed, Mar 22

jestabro changed Difficulty level from hard to normal on T5097: the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters'.
Wed, Mar 22, 9:16 PM · VyOS 1.4 Sagitta, VyOS 1.3 Equuleus
jestabro added a project to T5097: the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters': VyOS 1.4 Sagitta.
Wed, Mar 22, 7:52 PM · VyOS 1.4 Sagitta, VyOS 1.3 Equuleus
jestabro claimed T5097: the operational command "show interfaces ethernet ethx" doesn't reflect a call to 'clear counters'.
Wed, Mar 22, 7:52 PM · VyOS 1.4 Sagitta, VyOS 1.3 Equuleus
jestabro added a comment to T5106: Extend generation of API client requests to configsession native functions and composite requests.

PR:
https://github.com/vyos/vyos-1x/pull/1906

Wed, Mar 22, 6:46 PM · VyOS 1.4 Sagitta
jestabro edited projects for T5106: Extend generation of API client requests to configsession native functions and composite requests, added: VyOS 1.4 Sagitta; removed VyOS 1.2 Crux.
Wed, Mar 22, 5:34 PM · VyOS 1.4 Sagitta
jestabro closed T5068: Generate op-mode API client requests along with schema generation as Resolved.
Wed, Mar 22, 2:59 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5068: Generate op-mode API client requests along with schema generation: T5106: Extend generation of API client requests to configsession native functions and composite requests.
Wed, Mar 22, 2:59 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5106: Extend generation of API client requests to configsession native functions and composite requests: T5068: Generate op-mode API client requests along with schema generation.
Wed, Mar 22, 2:59 PM · VyOS 1.4 Sagitta
jestabro triaged T5106: Extend generation of API client requests to configsession native functions and composite requests as Normal priority.
Wed, Mar 22, 2:58 PM · VyOS 1.4 Sagitta
jestabro renamed T5068: Generate op-mode API client requests along with schema generation from Generate API client requests along with schema generation to Generate op-mode API client requests along with schema generation.
Wed, Mar 22, 2:53 PM · VyOS 1.4 Sagitta

Mon, Mar 20

jestabro added a comment to T5089: Add unit test of config_diff.

Draft PR:
https://github.com/vyos/vyos-1x/pull/1900

Mon, Mar 20, 7:55 PM · VyOS 1.4 Sagitta
jestabro closed T5095: Return list instead of dict for 'raw' output of op-mode openvpn as Resolved.
Mon, Mar 20, 2:21 PM · VyOS 1.4 Sagitta

Thu, Mar 16

jestabro added a comment to T5095: Return list instead of dict for 'raw' output of op-mode openvpn.

PR:
https://github.com/vyos/vyos-1x/pull/1896

Thu, Mar 16, 5:42 PM · VyOS 1.4 Sagitta
jestabro triaged T5095: Return list instead of dict for 'raw' output of op-mode openvpn as Normal priority.
Thu, Mar 16, 4:36 PM · VyOS 1.4 Sagitta

Tue, Mar 14

jestabro added a comment to T5089: Add unit test of config_diff.

PR for vyos1x-config:
https://github.com/vyos/vyos1x-config/pull/15

Tue, Mar 14, 7:35 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5087: Add support for lexical ordering of nodes in config_tree.

PR:
https://github.com/vyos/vyos1x-config/pull/15

Tue, Mar 14, 7:35 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5087: Add support for lexical ordering of nodes in config_tree: T5089: Add unit test of config_diff.
Tue, Mar 14, 6:18 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5089: Add unit test of config_diff: T5087: Add support for lexical ordering of nodes in config_tree.
Tue, Mar 14, 6:18 PM · VyOS 1.4 Sagitta
jestabro triaged T5089: Add unit test of config_diff as Normal priority.
Tue, Mar 14, 6:17 PM · VyOS 1.4 Sagitta
jestabro renamed T5088: Add lexicographical-numeric compare function for vytree/configtree from Add lexicographical-numerical compare function for vytree/configtree to Add lexicographical-numeric compare function for vytree/configtree.
Tue, Mar 14, 4:57 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5088: Add lexicographical-numeric compare function for vytree/configtree.

Draft PR for testing:
https://github.com/vyos/vyos1x-config/pull/14

Tue, Mar 14, 4:57 PM · VyOS 1.4 Sagitta
jestabro updated the task description for T5088: Add lexicographical-numeric compare function for vytree/configtree.
Tue, Mar 14, 4:39 PM · VyOS 1.4 Sagitta
jestabro renamed T5088: Add lexicographical-numeric compare function for vytree/configtree from Add lexicographic-numerical compare function for vytree/configtree to Add lexicographical-numerical compare function for vytree/configtree.
Tue, Mar 14, 4:39 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5088: Add lexicographical-numeric compare function for vytree/configtree: T5087: Add support for lexical ordering of nodes in config_tree.
Tue, Mar 14, 4:38 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5087: Add support for lexical ordering of nodes in config_tree: T5088: Add lexicographical-numeric compare function for vytree/configtree.
Tue, Mar 14, 4:38 PM · VyOS 1.4 Sagitta
jestabro triaged T5088: Add lexicographical-numeric compare function for vytree/configtree as Normal priority.
Tue, Mar 14, 4:38 PM · VyOS 1.4 Sagitta
jestabro triaged T5087: Add support for lexical ordering of nodes in config_tree as Normal priority.
Tue, Mar 14, 4:32 PM · VyOS 1.4 Sagitta

Wed, Mar 8

jestabro triaged T5068: Generate op-mode API client requests along with schema generation as Normal priority.
Wed, Mar 8, 7:39 PM · VyOS 1.4 Sagitta
jestabro edited projects for T4396: HTTP API no response after several days restarted, added: VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus (1.3.3).
Wed, Mar 8, 7:16 PM · VyOS 1.4 Sagitta
jestabro closed T4396: HTTP API no response after several days restarted as Resolved N/A.

This was never reproduced; user will report if recurrence and we will reopen as needed.

Wed, Mar 8, 7:15 PM · VyOS 1.4 Sagitta
jestabro edited projects for T4318: Add delete_tag to configtree.py, added: VyOS 1.4 Sagitta, VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).

Lower priority and will need testing when implemented.

Wed, Mar 8, 7:10 PM · VyOS 1.3 Equuleus (1.3.4), VyOS 1.4 Sagitta
jestabro closed T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command as Resolved.
Wed, Mar 8, 3:17 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T4872: Op-mode show openvpn misses a case when parsing for tunnel IP, a subtask of T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command, as Resolved.
Wed, Mar 8, 3:16 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T4872: Op-mode show openvpn misses a case when parsing for tunnel IP as Resolved.
Wed, Mar 8, 3:16 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta

Tue, Mar 7

jestabro closed T4900: Cache intermediary results of get_config_diff in Config instance as Resolved.
Tue, Mar 7, 8:55 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T5051: Use Literal types to provide op-mode CLI choices and API enums as Resolved.
Tue, Mar 7, 8:47 PM · VyOS 1.4 Sagitta
jestabro moved T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command from Need Triage to Backport Candidates on the VyOS 1.3 Equuleus (1.3.3) board.
Tue, Mar 7, 8:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro moved T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command from Need Triage to Finished on the VyOS 1.4 Sagitta board.
Tue, Mar 7, 8:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro moved T4872: Op-mode show openvpn misses a case when parsing for tunnel IP from Need Triage to Backport Candidates on the VyOS 1.3 Equuleus (1.3.3) board.
Tue, Mar 7, 8:02 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro added a comment to T4872: Op-mode show openvpn misses a case when parsing for tunnel IP.

Backport PR:
https://github.com/vyos/vyos-1x/pull/1874

Tue, Mar 7, 8:02 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro changed the status of T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command from Needs testing to Backport pending.

Backport PR for this and T4872:
https://github.com/vyos/vyos-1x/pull/1874

Tue, Mar 7, 8:01 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro moved T2649: Ensure configration mode scripts conform to coding guidelines from Need Triage to Finished on the VyOS 1.3 Equuleus board.
Tue, Mar 7, 6:36 PM · VyOS 1.3 Equuleus
jestabro closed T2649: Ensure configration mode scripts conform to coding guidelines, a subtask of T2582: Script daemon to offload processing during commit, as Resolved.
Tue, Mar 7, 6:36 PM · VyOS 1.3 Equuleus (1.3.0)
jestabro closed T2649: Ensure configration mode scripts conform to coding guidelines as Resolved.
Tue, Mar 7, 6:36 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2649: Ensure configration mode scripts conform to coding guidelines.

This was a meta-task for conformance to coding guidelines for inclusion of scripts in vyos-configd. Those guidelines are documented and checked in the smoketest test_configd_inspect.py for both Sagitta and Equuleus, and will be closed.

Tue, Mar 7, 6:35 PM · VyOS 1.3 Equuleus
jestabro edited projects for T3574: Add constraintGroup for combining validators with logical AND, added: VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).

This is potentially a useful feature, but has no current use, so there is no reason to backport it for 1.3.3. I wil add a 1.3.4 tag to keep it in mind in case it is needed for a future backport.

Tue, Mar 7, 5:15 PM · VyOS 1.3 Equuleus (1.3.4), VyOS 1.4 Sagitta
jestabro moved T2838: Ethernet device names changing, multiple hw-id being added from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.3) board.
Tue, Mar 7, 5:04 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T2838: Ethernet device names changing, multiple hw-id being added as Resolved.
Tue, Mar 7, 5:04 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro added a comment to T2838: Ethernet device names changing, multiple hw-id being added.

As mentioned above, there were two separate issues here:
(1) the issue of quoting of hw-id values is resolved in this task, for both Sagitta and Equuleus

Tue, Mar 7, 5:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta

Sun, Mar 5

jestabro added a comment to T5051: Use Literal types to provide op-mode CLI choices and API enums.

PR:
https://github.com/vyos/vyos-1x/pull/1868

Sun, Mar 5, 9:08 PM · VyOS 1.4 Sagitta
jestabro closed T5040: Generate API GraphQL schema on installation, rather than dynamically as Resolved.
Sun, Mar 5, 8:14 PM · VyOS 1.4 Sagitta

Fri, Mar 3

jestabro added a comment to T5051: Use Literal types to provide op-mode CLI choices and API enums.

https://github.com/vyos/vyos-1x/compare/current...jestabro:literal

Fri, Mar 3, 9:20 PM · VyOS 1.4 Sagitta
jestabro updated the task description for T5051: Use Literal types to provide op-mode CLI choices and API enums.
Fri, Mar 3, 4:56 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5051: Use Literal types to provide op-mode CLI choices and API enums from Open to In progress.
Fri, Mar 3, 4:54 PM · VyOS 1.4 Sagitta
jestabro triaged T5051: Use Literal types to provide op-mode CLI choices and API enums as Normal priority.
Fri, Mar 3, 4:54 PM · VyOS 1.4 Sagitta
jestabro created T5051: Use Literal types to provide op-mode CLI choices and API enums.
Fri, Mar 3, 4:54 PM · VyOS 1.4 Sagitta

Mar 1 2023

jestabro added a comment to T5040: Generate API GraphQL schema on installation, rather than dynamically.

PR:
https://github.com/vyos/vyos-1x/pull/1862

Mar 1 2023, 5:19 PM · VyOS 1.4 Sagitta
jestabro triaged T5040: Generate API GraphQL schema on installation, rather than dynamically as Normal priority.
Mar 1 2023, 2:14 PM · VyOS 1.4 Sagitta

Feb 27 2023

jestabro added a comment to T4952: Improve interface completion helper CLI experience.

PR using list_interfaces from vyos-utils:

Feb 27 2023, 5:58 PM · VyOS 1.4 Sagitta

Feb 26 2023

jestabro closed T4979: Add API request 'show_user_info' for UI as Resolved.
Feb 26 2023, 9:31 PM · VyOS 1.4 Sagitta

Feb 24 2023

jestabro closed T5030: HTTPS-API delete key without id error as Resolved.
Feb 24 2023, 8:15 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5030: HTTPS-API delete key without id error.

https://github.com/vyos/vyos-1x/pull/1850

Feb 24 2023, 3:53 PM · VyOS 1.4 Sagitta
jestabro changed Difficulty level from unknown to easy on T5030: HTTPS-API delete key without id error.
Feb 24 2023, 3:32 PM · VyOS 1.4 Sagitta
jestabro claimed T5030: HTTPS-API delete key without id error.
Feb 24 2023, 2:33 PM · VyOS 1.4 Sagitta
jestabro closed T5006: Http api segfault with concurrent requests as Resolved.
Feb 24 2023, 2:00 PM · VyOS 1.4 Sagitta

Feb 23 2023

jestabro added a comment to T3871: Resolve unexpected interface name reordering.

The above repos are suitable for testing: basic tests in vm's and a Protecli device look fine. Note that the vyos-1x repo artificially disables the potential config mode reordering in order to confirm tests of vyos-interface-monitor.:
https://github.com/vyos/vyos-1x/commit/02d874e65262cbd53b413b3eef659b8e7d78bf31

Feb 23 2023, 7:58 PM · VyOS 1.4 Sagitta

Feb 15 2023

jestabro closed T4991: Restore path level information to compare output, a subtask of T4942: Rewrite vyatta-config-mgmt to Python/XML, as Resolved.
Feb 15 2023, 6:09 PM · VyOS 1.4 Sagitta
jestabro closed T4991: Restore path level information to compare output as Resolved.
Feb 15 2023, 6:09 PM · VyOS 1.4 Sagitta