Maniphest T7637

Fix typo in commit algorithm
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	jestabro
	Jul 17 2025, 1:12 PM

Tags

Referenced Files

None

Subscribers

Description

Fix the missed inclusion of tag value to the paths updated in the commit algorithm result trees. This is caught by smoketests, notably test_interfaces_vxlan.py when adding/deleting paths of several tag node values.

Details

Version: -
Is it a breaking change?: Perfectly compatible
Issue type: Bug (incorrect behavior)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		In progress	FEATURE REQUEST	None	T3355 Remove all remaining legacy Vyatta code
		Open	BUG	None	T4316 Update save-config/load-config
		Resolved		jestabro	T4235 Add config tree diff algorithm
		Not Applicable	FEATURE REQUEST	jestabro	T4295 Use config_tree instead of legacy loadFile in vyos-load-config.py
		Resolved	ENHANCEMENT	jestabro	T5316 configtree: use a single pass of the diff algorithm
		Resolved	ENHANCEMENT	jestabro	T5317 configtree: remove mutable references
		Open	BUG	jestabro	T6543 Legacy load config ignores validation errors on set, leading to removal of config sections under commit error
		Resolved	ENHANCEMENT	jestabro	T5528 Replace legacy loadFile with config_diff
		Resolved	ENHANCEMENT	jestabro	T6717 Add hybrid Cstore manipulation library to replace set/delete/load_config functionality
		Resolved	ENHANCEMENT	jestabro	T6718 Use vyconf daemon for validation of set commands
		Resolved	ENHANCEMENT	jestabro	T6946 Add initial commit algorithm to vyconf
		Resolved	BUG	jestabro	T7637 Fix typo in commit algorithm

Event Timeline

jestabro created this task.Jul 17 2025, 1:12 PM

jestabro triaged this task as Normal priority.

jestabro added a parent task: T6946: Add initial commit algorithm to vyconf.

PR:
https://github.com/vyos/vyconf/pull/27

pasik subscribed.Jul 18 2025, 6:44 PM

jestabro mentioned this in rVYOSONEX515080bdfd3a: T7637: T7605: update git submodule for typo and escape backslash.Jul 22 2025, 2:23 PM

Restricted Repository Identity mentioned this in rVYOSONEX7a88b0b5b3af: Merge pull request #4614 from jestabro/debug-smoketests.Jul 22 2025, 2:23 PM

jestabro closed this task as Resolved.Jul 30 2025, 3:47 PM

jestabro moved this task from Need Triage to Completed on the VyOS Rolling board.

jestabro mentioned this in rVYOSONEX88bfc47e7bf8: T7637: T7605: update commit hashes for typo and escape backslash.Sep 10 2025, 1:16 PM

Restricted Repository Identity mentioned this in rVYOSONEX6da131348730: Merge pull request #45 from jestabro/debug-smoketests.Sep 10 2025, 1:16 PM

c-po mentioned this in rVYOSONEX6ad118257738: Merge https://github.com/vyos/libvyosconfig into integrate-libvyosconfig.Sep 10 2025, 1:16 PM