Page MenuHomeVyOS Platform
Create Task
Maniphest T6007

Improvements to migration system
Closed, ResolvedPublicENHANCEMENT
Actions

Description

This is a root task for improvements to the migration system, generally, for 1.5, and to the migration script runner, specifically. The latter was written as a more or less direct translation into Python of the legacy version at a time when interoperability was still necessary. Goals are an improved design, better error reporting, and the distinction of syntax changes from system capabilities.

Details

Difficulty level
Hard (possibly days)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Improvement (missing useful functionality)

Related Objects
Search...

Event Timeline

jestabro created this task.Feb 1 2024, 8:19 PM
jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
jestabro added a subtask: T6006: Configure system-specific capabilities independently of migration scripts.
jestabro mentioned this in T6447: Add module for iterating over modifications to a config file.Jun 5 2024, 8:57 PM
jestabro changed the task status from Open to In progress.Jun 20 2024, 1:42 PM

Draft PR passes configtests; dramatically faster:
https://github.com/vyos/vyos-1x/pull/3692
Minor integration and other testing remain before ready for review.

pasik subscribed.Jun 20 2024, 5:16 PM
aga subscribed.Jun 20 2024, 6:32 PM
GurliGebis subscribed.Jun 22 2024, 9:10 PM
Restricted Repository Identity mentioned this in rVYOSONEXda1515c704e5: Merge pull request #3692 from jestabro/revise-migration.Jun 27 2024, 1:40 PM
jestabro mentioned this in rVYOSONEX5502a75b1747: migration: T6007: fix cosmetic issue of extra newline.Jun 27 2024, 1:40 PM
jestabro mentioned this in rVYOSONEX8b4c2fcba2fe: migration: T6007: drop restrictive perms, already set on config.boot.
jestabro mentioned this in rVYOSONEXed0cb7ffc2c6: migration: T6007: remove obsoleted.
jestabro mentioned this in rVYOSONEX08d4fcbc6243: migration: T6007: update run-config-migration script.
jestabro mentioned this in rVYOSONEX51865448599e: migration: T6007: add util add_system_version to replace *_system_footer.
jestabro mentioned this in rVYOSONEX403f1d2f2159: migration: T6007: update load_config.py.
jestabro mentioned this in rVYOSONEXcd347713196c: migration: T6007: update vyos_net_name.
jestabro mentioned this in rVYOSONEXf67753bf10ac: migration: T6007: update vyos-merge-config.py.
jestabro mentioned this in rVYOSONEX271fcff986c1: migration: T6007: update vyos-load-config.py.
jestabro mentioned this in rVYOSONEX9388f6278384: migration: T6007: write configtree operations to log.
jestabro mentioned this in rVYOSONEXad4f8312f6a3: migration: T6007: drop check for executable scripts, as now modules.
jestabro mentioned this in rVYOSONEXea714891a0d6: migration: T6007: update migration class.
jestabro mentioned this in rVYOSONEX26740a8d583f: migration: T6007: convert all migration scripts to load as module.
jestabro mentioned this in rVYOSONEX601e07c34205: migration: T6007: add version object for config file and system.
jestabro mentioned this in rVYOSONEX83ca4a5a6ed0: migration: T6007: add exception in base for use by migration files.
jestabro mentioned this in rVYOSONEX8a57e7b14c81: migration: T6007: use load_as_module_source for files without extension.
Viacheslav added a parent task: T6302: The root task for bugs and improvements related to commit time and boot.Jun 28 2024, 12:08 PM
jestabro closed this task as Unknown Status.Jun 28 2024, 5:03 PM
jestabro moved this task from Open to Backport Candidates on the VyOS 1.5 Circinus board.

PR merged:
https://github.com/vyos/vyos-1x/pull/3692

jestabro closed subtask T6006: Configure system-specific capabilities independently of migration scripts as Resolved.Jul 2 2024, 6:37 PM
jestabro added a comment.EditedJul 5 2024, 1:01 AM

Bug fix in case of config file without component version string:
https://github.com/vyos/vyos-1x/pull/3788

Restricted Repository Identity mentioned this in rVYOSONEX9cddfd9fde55: Merge pull request #3788 from jestabro/check-component-version.Jul 5 2024, 6:28 AM
jestabro mentioned this in rVYOSONEXbd42f131ea2c: migration: T6007: add missing check for None in utility function.Jul 5 2024, 6:28 AM
jestabro mentioned this in T6658: Fix typo in write_file util.Aug 15 2024, 6:29 PM
jestabro added a subtask: T6710: Migration scripts fails for the circinus.Sep 11 2024, 6:02 PM
jestabro added a comment.Sep 12 2024, 12:49 AM

PR for backport to circinus:
https://github.com/vyos/vyos-1x/pull/4050

Restricted Repository Identity mentioned this in rVYOSONEX205d957d092a: Merge pull request #4050 from jestabro/revise-migration-circinus.Sep 12 2024, 12:59 PM
jestabro mentioned this in rVYOSONEXeaa9c82670fa: migration: T6007: add missing check for None in utility function.Sep 12 2024, 12:59 PM
jestabro mentioned this in rVYOSONEX6bc1aff55e29: migration: T6007: fix cosmetic issue of extra newline.
jestabro mentioned this in rVYOSONEXf7f51060f38b: migration: T6007: drop restrictive perms, already set on config.boot.
jestabro mentioned this in rVYOSONEX34e3eda93b4b: migration: T6007: remove obsoleted.
jestabro mentioned this in rVYOSONEX0f5001de97f4: migration: T6007: update run-config-migration script.
jestabro mentioned this in rVYOSONEX70720e5f3d86: migration: T6007: add util add_system_version to replace *_system_footer.
jestabro mentioned this in rVYOSONEX9ed150798a83: migration: T6007: update load_config.py.
jestabro mentioned this in rVYOSONEXb82cd064b0fc: migration: T6007: update vyos_net_name.
jestabro mentioned this in rVYOSONEXefe2508f8912: migration: T6007: update vyos-merge-config.py.
jestabro mentioned this in rVYOSONEXd17304ba5e93: migration: T6007: update vyos-load-config.py.
jestabro mentioned this in rVYOSONEXfe810a0fe316: migration: T6007: write configtree operations to log.
jestabro mentioned this in rVYOSONEXb5db9395ed57: migration: T6007: convert all migration scripts to load as module.
jestabro mentioned this in rVYOSONEX4091432eb99f: migration: T6007: add version object for config file and system.
jestabro mentioned this in rVYOSONEXccff9ffdd8e3: migration: T6007: update migration class.
jestabro mentioned this in rVYOSONEX309260f7eeb6: migration: T6007: add exception in base for use by migration files.
jestabro mentioned this in rVYOSONEXa79237bb168e: migration: T6007: use load_as_module_source for files without extension.
jestabro changed the task status from Unknown Status to Resolved.Sep 13 2024, 3:26 PM
jestabro closed subtask T6710: Migration scripts fails for the circinus as Resolved.
jestabro moved this task from Backport Candidates to Finished on the VyOS 1.5 Circinus board.