Page MenuHomeVyOS Platform

Provide list of config-mode scripts scheduled for proposed commit
Closed, ResolvedPublicENHANCEMENT

Description

This is a simple function for returning the list of config-mode scripts, ordered by priority, that will be called for the proposed commit. As it may have general use it is added here, with motivation from the need to prune scheduled config dependency scripts (T5660).

Note also that in reasoning about priorities and script execution order, one needs to keep in mind the analysis in T5492 while we are still in the situation of the legacy commit-algorithm; conversely, the reference tree data will allow correcting this in the future algorithm, similar to the (simple) construction in the first commit below.

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Event Timeline

jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.

Implementation; this may be slightly revised before PR, to provide extra data ...
https://github.com/vyos/vyos-1x/compare/current...jestabro:commit-schedule

jestabro changed the task status from Open to On hold.Mar 1 2024, 2:49 PM

The motivation here was from T5660, for which it was not needed. However, a version of the constructions in the branch above will be useful for development of the modern commit algorithm and comparison with the idiosyncrasies of legacy (T5492). Put on hold for now.

Note that the work in the link above, but for the get_commit_schedule function itself, has already been added in subtasks T6319/T6146. As mentioned above, the get_commit_schedule function is not useful (and potentially misleading) until we replace the legacy commit algorithm in 1.5. Remove 1.4.0 tag.

jestabro changed the task status from On hold to In progress.Fri, Aug 23, 7:35 PM

A simple version of get_commit_scripts (nee get_commit_schedule) has been added to the resolution of T6671. After that PR is merged, this task will be closed, as that version suffices for current needs.

jestabro moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.1) board.