Page MenuHomeVyOS Platform
Create Task
Maniphest T6736

Make REST api and GraphQL api distinct nodes
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

The GraphQL API was added as a sub-node of 'service https api', though it is, in practice and implementation, a distinct entity. Refactor the http-api server into distinct configuration nodes.

Details

Version
-
Is it a breaking change?
Config syntax change (migratable)
Issue type
Cosmetic issue (typos etc.)

Related Objects

Event Timeline

jestabro created this task.Sep 25 2024, 3:47 AM
jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
pasik subscribed.Sep 25 2024, 6:16 AM
jestabro changed the task status from Open to In progress.Sep 25 2024, 2:00 PM

PR to follow tests and migration script:
https://github.com/vyos/vyos-1x/compare/current...jestabro:distinct-api

jestabro added a comment.Sep 30 2024, 3:47 AM

PR:
https://github.com/vyos/vyos-1x/pull/4110

Restricted Repository Identity mentioned this in rVYOSONEX5a59d8529c56: Merge pull request #4110 from jestabro/distinct-api.Oct 4 2024, 11:45 AM
jestabro mentioned this in rVYOSONEXc21fa1fb7726: http-api: T6736: sanitize error message containing user input.Oct 4 2024, 11:45 AM
jestabro mentioned this in rVYOSONEX7e23fd9da028: http-api: T6736: normalize formatting.
jestabro mentioned this in rVYOSONEX40d966310cb5: http-api: T6736: add migration script and update version.
jestabro mentioned this in rVYOSONEX8322cc4d8206: http-api: T6736: update smoketest for syntax change.
jestabro mentioned this in rVYOSONEX8183e2cc8178: http-api: T6736: add distinct XML path for REST API.
jestabro mentioned this in rVYOSONEX9f7767c8022f: http-api: T6736: regenerate openapi docs.
jestabro mentioned this in rVYOSONEX954be34bc938: http-api: T6736: remove routes on config delete.
jestabro mentioned this in rVYOSONEXfc9885f85961: http-api: T6736: separate REST API and GraphQL API activation.
jestabro mentioned this in rVYOSONEX3ad911a20620: http-api: T6736: update for deprecated/renamed in Pydantic V2.
jestabro closed this task as Unknown Status.Oct 4 2024, 4:15 PM
jestabro moved this task from Open to Backport Candidates on the VyOS 1.5 Circinus board.
dmbaturin changed the task status from Unknown Status to Resolved.Oct 12 2024, 7:15 AM
dmbaturin edited projects, added VyOS 1.5 Circinus (1.5-stream-2025-Q2); removed VyOS 1.5 Circinus.Jul 9 2025, 12:29 PM
dmbaturin changed Is it a breaking change? from Perfectly compatible to Config syntax change (migratable).
dmbaturin changed Issue type from improvement to Cosmetic issue (typos etc.).
jestabro moved this task from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q2) board.Jul 9 2025, 6:40 PM
jestabro moved this task from Need Triage to Completed on the VyOS Rolling board.