Page MenuHomeVyOS Platform

Offload settings are being automatically updated to reflect kernel settings
Closed, ResolvedPublicBUG

Description

Each time VyOS boots, it is setting the offload settings to "enabled" if the kernel has them enabled at boot. This occurs even if the config explicitly has them removed. (See discussion https://forum.vyos.io/t/disable-interface-offloading-permanently/15230)

The culprit are the lines in ethernet offload activation scripts (example these lines)

Is there a reason this is being done or is this a bug?

Details

Difficulty level
Easy (less than an hour)
Version
1.5
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Behavior change
Issue type
Bug (incorrect behavior)
Forum thread
https://forum.vyos.io/t/disable-interface-offloading-permanently/15230

Event Timeline

This is a valid point!

Looks like offload options need explicit options:

  • on โ€” enable, unless not possible.
  • off โ€” disable, even if possible.

I wonder if auto should be a separate value for "enable when possible" and "on" should try to enable the option no matter what. Probably not.

syncer triaged this task as Normal priority.Mon, Sep 16, 7:02 PM

Yes this is a known, annoying, bug that had not yet been addressed following T6006. One suggestion I have added to your PR is to only set in config in the case of live boot: after installation, activation will not enable against user settings; it will still disable if say, hardware capabilities disappear.

jestabro changed the task status from Open to Backport pending.Tue, Sep 17, 8:23 PM
jestabro claimed this task.
jestabro moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.