Each time VyOS boots, it is setting the offload settings to "enabled" if the kernel has them enabled at boot. This occurs even if the config explicitly has them removed. (See discussion https://forum.vyos.io/t/disable-interface-offloading-permanently/15230)
The culprit are the lines in ethernet offload activation scripts (example these lines)
Is there a reason this is being done or is this a bug?
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | BUG | None | T6302 The root task for bugs and improvements related to commit time and boot | ||
| Resolved | ENHANCEMENT | jestabro | T6007 Improvements to migration system | ||
| Resolved | jestabro | T3275 Disable conntrack helpers by default | |||
| Resolved | jestabro | T3821 Add latest versions to default config files | |||
| Open | BUG | dmbaturin | T3824 Ethernet offload options are not populated in new installs | ||
| Resolved | FEATURE REQUEST | jestabro | T6006 Configure system-specific capabilities independently of migration scripts | ||
| Resolved | BUG | jestabro | T6716 Offload settings are being automatically updated to reflect kernel settings |
This is a valid point!
Looks like offload options need explicit options:
I wonder if auto should be a separate value for "enable when possible" and "on" should try to enable the option no matter what. Probably not.
Yes this is a known, annoying, bug that had not yet been addressed following T6006. One suggestion I have added to your PR is to only set in config in the case of live boot: after installation, activation will not enable against user settings; it will still disable if say, hardware capabilities disappear.
What is the approach for preventing offloads from being added back in after boot? I deleting them before upgrading, upgraded to a nightly with this patch, but I observed the offloads returned:
$ ssh [email protected] Welcome to VyOS! ┌── ┐ . VyOS 1.5-rolling-202409250007 └ ──┘ current * Support portal: https://support.vyos.io * Documentation: https://docs.vyos.io/en/latest * Project news: https://blog.vyos.io * Bug reports: https://vyos.dev You can change this banner using "set system login banner post-login" command. VyOS is a free software distribution that includes multiple components, you can check individual component licenses under /usr/share/doc/*/copyright vyos@vyos:~$ show configuration commands | grep offload set interfaces ethernet eth2 offload gro
@doctorpangloss I see from the other forum thread:
https://forum.vyos.io/t/something-keeps-adding-offloads-back-to-my-interface-breaking-my-wan/15282/7
that @n.fort has confirmed the persistence of the fix.