Marked this as resolved since the fix was merged and backported.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feb 15 2024
Feb 14 2024
Moving to systemd-networkd on the long run seems like a very nice idea that I also had. For no and the 1.4 LTS release we will stick with a custom isc-dhcp-client package build
The examples in T5939 reveal a general issue that, although uncommon, needs to be rationalized. The modern parser requires single backslashes to be escaped, if in quoted strings, however (1) the legacy parser (unlike the modern parser) is inconsistent in quoting values (2) the existing solution escapes all single backslashes not a part of control sequences and makes no attempt to restore single backslashes when possible --- this is safe, but leads to redundant escaping of backslashes as revealed in the examples in T5939.
This bug was fixed in https://vyos.dev/T5688
Feb 13 2024
The patch is btw here, in case anyone want to use it as inspiration: https://github.com/vyos/vyos-1x/compare/current...ichdasich:vyos-1x:bgp_large_community_validator_new
PR for 1.5 https://github.com/vyos/vyos-1x/pull/2988
PRs for VyOS 1.3
Smoketest conntrack fix https://github.com/vyos/vyos-1x/pull/3005
@dberlin Can you recheck?
@JonD Have you figured out what the problem is?
@pjeevarathinam Could you re-check wiht 1.4-rc3 or the latest rolling?
You can play with descriptions
vyos@r4# set system frr descriptors Possible completions: <1024-8192> Number of file descriptors
Honestly? Rather not. Even though i have been testing this extensively, there needs to be some discussion re: old-config-impact (+some testing); Similarly, _ideally_ this would not just go for standard python regex, but instead try to figure out what frr _acutally_ uses. So, while a poc, i think this needs a bit more work.
@tfiebig Could you add a PR?
Feb 12 2024
This turns out to be non-trivial, due to the interaction between legacy and modern behavior; nonetheless, a simple preliminary fix is in testing, and the task will be updated with the details when the PR is complete.
It cannot be backported to 1.3 as there are no config-mode-dependencies
PR for fix in vyos-build: https://github.com/vyos/vyos-build/pull/501
PR for smoketest (modified because of change in build): https://github.com/vyos/vyos-1x/pull/2991
PR for fix in vyos-build: https://github.com/vyos/vyos-build/pull/501
PR for smoketest (modified because of change in build): https://github.com/vyos/vyos-1x/pull/2991