Page MenuHomeVyOS Platform
Create Task
Maniphest T6010

Support setting multiple values in BGP path-attribute
Closed, ResolvedPublicBUG
Actions

Description

Sometimes multple attributes need to be discarded. Currently only one value can be set.

Doing something like:

set protocols bgp peer-group some-peer path-attribute discard 7
set protocols bgp peer-group some-peer path-attribute discard 18

produces

set protocols bgp peer-group some-peer path-attribute discard 18

in the config. While the following

set protocols bgp peer-group some-peer path-attribute discard 7,18

is not allowed. Please support either syntax.

The end config in FRR should like something like:

neighbor some-peer path-attribute discard 7,18

or

neighbor x.x.x.x path-attribute discard 7,18

Details

Difficulty level
Easy (less than an hour)
Version
1.4.0-rc1
Why the issue appeared?
Design mistake
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Event Timeline

roedie created this task.Feb 2 2024, 7:52 PM
pasik added a subscriber: pasik.Feb 2 2024, 8:27 PM
Viacheslav triaged this task as Wishlist priority.Feb 5 2024, 8:34 AM
Viacheslav added a subscriber: Viacheslav.

FRR does not support it

r4# conf t
r4(config)# router bgp 65001
r4(config-router)#  no bgp ebgp-requires-policy
r4(config-router)#  no bgp default ipv4-unicast
r4(config-router)#  no bgp network import-check
r4(config-router)#  neighbor foo peer-group
r4(config-router)#  neighbor foo path-attribute discard 24
r4(config-router)#  neighbor foo path-attribute discard 23,24
% Unknown command:  neighbor foo path-attribute discard 23,24
r4(config-router)#
Viacheslav added a comment.Feb 5 2024, 8:36 AM

Update supports via whitespace

r4(config-router)#  neighbor foo path-attribute discard 23 24
c-po claimed this task.Feb 5 2024, 4:33 PM
c-po added a comment.Feb 10 2024, 2:44 PM

https://github.com/vyos/vyos-1x/pull/2986

c-po changed the task status from Open to In progress.Feb 10 2024, 2:45 PM
c-po raised the priority of this task from Wishlist to Normal.
c-po added projects: VyOS 1.4 Sagitta, VyOS 1.5 Circinus.
c-po changed Version from 1.4RC3 to 1.4.0-rc1.
c-po changed Why the issue appeared? from Will be filled on close to Design mistake.
c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
c-po moved this task from Need Triage to In Progress on the VyOS 1.4 Sagitta board.
c-po closed this task as Resolved.Feb 12 2024, 8:44 PM
c-po moved this task from In Progress to Finished on the VyOS 1.4 Sagitta board.