The patch is btw here, in case anyone want to use it as inspiration: https://github.com/vyos/vyos-1x/compare/current...ichdasich:vyos-1x:bgp_large_community_validator_new

Honestly? Rather not. Even though i have been testing this extensively, there needs to be some discussion re: old-config-impact (+some testing); Similarly, _ideally_ this would not just go for standard python regex, but instead try to figure out what frr _acutally_ uses. So, while a poc, i think this needs a bit more work.

kk, will try to remember to setup a box for that; Usually rolling my own images. ;-)

What is meant with testing? Writing the unit tests? Or seeing whether it actually works? If it is the latter, this is in prod on my boxes for roughly a month ;-)

done

Wanted to have the ticketid to write the right commit message right away. Diff is here: https://github.com/vyos/vyos-1x/compare/current...ichdasich:vyos-1x:filtered_routes

Just put this on a live system, and it behaves as intended (so far). Special meaning of _ would certainly have to be added to the check, i guess, but that needs further delving into bgp-regex syntax.

https://github.com/vyos/vyos-1x/pull/1880

Let me give it another test-run in a bit and then i'll issue a PR.