Cannot pass smoketest

vyos@r4:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_dhcp-server.py
test_dhcp_exclude_in_range (__main__.TestServiceDHCPServer.test_dhcp_exclude_in_range) ... ok
test_dhcp_exclude_not_in_range (__main__.TestServiceDHCPServer.test_dhcp_exclude_not_in_range) ... ok
test_dhcp_failover (__main__.TestServiceDHCPServer.test_dhcp_failover) ... FAIL
test_dhcp_multiple_pools (__main__.TestServiceDHCPServer.test_dhcp_multiple_pools) ... ok
test_dhcp_relay_server (__main__.TestServiceDHCPServer.test_dhcp_relay_server) ... ok
test_dhcp_single_pool_options (__main__.TestServiceDHCPServer.test_dhcp_single_pool_options) ... ok
test_dhcp_single_pool_range (__main__.TestServiceDHCPServer.test_dhcp_single_pool_range) ... ok
test_dhcp_single_pool_static_mapping (__main__.TestServiceDHCPServer.test_dhcp_single_pool_static_mapping) ... ok

@danielpo marking IPv6 packet is possible

set policy route6 PBR6 interface 'eth1'
set policy route6 PBR6 rule 100 set mark '4'
set policy route6 PBR6 rule 100 source address '2001:db8::/64'

Some users have issues https://forum.vyos.io/t/grub-menu-fails-to-load-on-serial-only-devices-with-no-kvm/

Not reproduced in 1.3.5

vyos@r1# set service https vrf foo
[edit]
vyos@r1# commit
[edit]
vyos@r1# del service https vrf foo
[edit]
vyos@r1# commit
[edit]
vyos@r1# curl -k --location --request POST 'https://localhost/retrieve'   --form data='{"op": "showConfig", "path": ["system", "ip"]}'   --form key='foo'
{"success": true, "data": {"arp": {"table-size": "32768"}}, "error": null}[edit]
vyos@r1# 
[edit]
vyos@r1# run show ver

@SrividyaA could you re-check and close it?

@zsdc Can we backport it?

It won't be implemented for 1.3.x due to old backend

Implemented in 1.4-1.5 T5248

Implemented

vyos@r1# set system option root-partition-auto-resize
[edit]
vyos@r1# run show ver

You can use policy local-route to archive your goals
There is no way to use eth1v1 for the policy route (rewritten for 1.4/1.5)

Fixed

vyos@r1# set interfaces ethernet eth2 description foo
[edit]
vyos@r1# set interfaces ethernet eth2 mtu 1200
[edit]
vyos@r1# commit
[ interfaces ethernet eth2 ]
link-local IPv6 address will be configured on interface "eth2", the
required minimum MTU is 1280!

Close it, as it is not bug/feature

@zsdc Can we close it?

Fq_codel was added for 1.4/1.5 in T5489
Not planning to do it for 1.3 now

Not sure if Jool supports it.
As I understand, it is better to have a separate address for translations, otherwise, you should define ports for 64 translations. If you set 1-65535 for the "main" address, you will lose connections and can't use those ports for the system (they will be available only for translations)
Jool uses its own bib table instead of conntrack to manage nat mappings.
So you should add a separate pool only for translations.

@w4 could you provide some links or retest? Which patches?
The bug is not clear.

Close it due to https://github.com/vyos/vyos-1x/pull/2183#issuecomment-1696022296

Should be fixed in T5817
Could you re-check?

Done for 1.4/1.5 https://github.com/vyos/vyos-1x/tree/current/python/vyos/utils
It won't be implemented for 1.3 as we risk breaking something.

Firstly, this bug should be fixed T5837

@zsdc Can we close it?

It won't fix due the old backend
Fixed in 1.4/1.5

We agree not to use raw options anymore.
If some options are required, it should be a separate PR per configured option.

Most of the changes are not supported by reload accel-cmd/systemctl unit.
Accel-ppp cannot apply some features/changes without the daemon restarting. In other words, there are only several features that could be applied by reload.

The current FRR 7.5
There are no reports with this bug.
Close it. Re-open if you still have issues or create a new bug report.

Yes it should trigger to recreate container but it doesn’t get a dictionary key for recreating

Could you point out some documentation/examples on which scripts are missing?
It seems it has never been tested since @jack9603301 implemented it in task T3420. It seems he also didn't test it.

Adding a new container with both addresses and networks in one commit works fine.

set container name alp01 image 'alpine'
set container name alp01 network NET01 address '10.0.0.12'
set container name alp01 network NET01 address '2001:db8::12'
set container network NET01 prefix '10.0.0.0/24'
set container network NET01 prefix '2001:db8::/64'

We don't use /usr/libexec/vyos/validate-value.py anymore
There should be a separates tasks if required.

There is nothing to do there, all checks for linter Jinja included to vyos-build.
Close it.

It was changed for 1.4/1.5 and won't be changed for 1.3 LTS (old backend)
If someone wants it for 1.3

set protocols bgp 65001 parameters default no-ipv4-unicast

We are using sshguard

set service ssh dynamic-protection

@thomas-mangin Do you have a PoC?

Comparing boot time for now 1.3 and 1.1.8 is not actual
There are 2 different systems :)
Also, some validators were rewritten on 1.2 to Python and for 1.3 to sh, OCAML and so on (python validators could be cause of the issue)
In my internal test VM loads ~40 sec tested in VyOS 1.3.5
We always can improve something, but lets find what we can improve in separate tasks.

@mb300sd could you re-check?

The main issue is synchronization between all routing daemons and zebra, especially with "policy".
So you are getting strange things like a policy configured for zebra but the same policy not exists/applied for other daemons.
It is impossible to integrate it the correct way.
Reopen for 1.5, 2.0 if required and if it will be possible in the future with correct syncing between all daemons.

We can't do more due to old backend on the 1.3
If there will be a specific options to improve it should be a separate task
Close it.

Refactored in 1.4/1.5
Let's avoid the firewall migrations for the stable branch.

It won't be implemented for 1.3

Configs weren't provided, so closed the task as invalid. Works with internal tetts.
Re-open it or add steps to reproduce.

Implemented in 1.4
Wontfix for 1.3 due to old backend.

Is it possible with native podman commands?

Try to delete MAC before cloning in /config/config.boot

PR https://github.com/vyos/vyos-1x/pull/2637