Page MenuHomeVyOS Platform
Create Task
Maniphest T2655

ConfigError formatting issue
Resolved (N/A)PublicBUG
Actions

Description

Currently ConfigError is called everywhere as such:

raise ConfigError((
                f'static-host-mapping "{host}" address "{hostprops["address"]}"'
                f'already used in another static-host-mapping'))

This results in output looking like:

static-host-mapping "test2" address "10.0.10.100"already used in another static-host-mapping

[[system static-host-mapping]] failed

Given that there's a lot of code with the first pattern, the extra space probably needs to be inserted in the ConfigError object.

Details

Difficulty level
Easy (less than an hour)
Version
1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Event Timeline

kroy created this task.Jun 27 2020, 3:26 AM
kroy updated the task description. (Show Details)
kroy updated the task description. (Show Details)
jjakob added a subscriber: jjakob.Jun 27 2020, 6:59 AM

No, the string concatenation is done by Python (these are not multiple arguments but one argument) so there's nothing ConfigError can do. It's simply a mistake (typo) on my part.

jjakob added a comment.Jun 27 2020, 7:02 AM

The reason I do it this way is to comply with the 80-column limit. Any strings separated by whitespace will be transparently concatenated by Python to one string, it requires adding extra braces around the multi-line string.

erkin set Issue type to Internal change (not visible to end users).Aug 29 2021, 2:01 PM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Nov 6 2021, 11:24 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.0).Aug 29 2022, 7:05 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:41 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:30 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:37 PM
Viacheslav closed this task as Resolved N/A.Dec 21 2023, 8:46 AM