Page MenuHomeVyOS Platform
Create Task
Maniphest T5793

mdns-repeater: Cleanup avahi-daemon configuration in /etc
Closed, ResolvedPublic
Actions

Description

/etc/avahi can be deleted since we operate with avahi-daemon configuration in /run/avahi-daemon

Details

Version
1.4, 1.5
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects

Event Timeline

indrajitr created this task.Dec 1 2023, 7:41 AM
indrajitr renamed this task from mdns: Cleanup avahi-daemon configuration in /etc to mdns-repeater: Cleanup avahi-daemon configuration in /etc.
indrajitr created this object in space S1 VyOS Public.
pasik subscribed.Dec 1 2023, 9:13 AM
Restricted Repository Identity mentioned this in rVYOSONEX115c106bfbf7: Merge pull request #2559 from indrajitr/avahi-cleanup.Dec 1 2023, 12:11 PM
indrajitr mentioned this in rVYOSONEX33c96654f485: mdns: T5793: Cleanup avahi-daemon configuration in `/etc`.Dec 1 2023, 12:11 PM
Restricted Repository Identity mentioned this in rVYOSONEX68d416185886: mdns: T5793: Cleanup avahi-daemon configuration in `/etc`.Dec 1 2023, 12:11 PM
Restricted Repository Identity mentioned this in rVYOSONEX883ab5d1c450: Merge pull request #2560 from vyos/mergify/bp/sagitta/pr-2559.Dec 1 2023, 8:25 PM
Viacheslav subscribed.Dec 2 2023, 1:36 AM

Cannot pass smoketest, @indrajitr could you re-check?

DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_service_mdns-repeater.py
DEBUG - test_service_dual_stack (__main__.TestServiceMDNSrepeater.test_service_dual_stack) ... FAIL
DEBUG - test_service_ipv4 (__main__.TestServiceMDNSrepeater.test_service_ipv4) ... FAIL
DEBUG - test_service_ipv6 (__main__.TestServiceMDNSrepeater.test_service_ipv6) ... FAIL
DEBUG - 
DEBUG - ======================================================================
DEBUG - FAIL: test_service_dual_stack (__main__.TestServiceMDNSrepeater.test_service_dual_stack)
DEBUG - ----------------------------------------------------------------------
DEBUG - Traceback (most recent call last):
DEBUG -   File "/usr/libexec/vyos/tests/smoke/cli/test_service_mdns-repeater.py", line 47, in tearDown
DEBUG -     self.assertTrue(process_named_running('avahi-daemon'))
DEBUG - AssertionError: None is not true
DEBUG - 
DEBUG - ======================================================================
DEBUG - FAIL: test_service_ipv4 (__main__.TestServiceMDNSrepeater.test_service_ipv4)
DEBUG - ----------------------------------------------------------------------
DEBUG - Traceback (most recent call last):
DEBUG -   File "/usr/libexec/vyos/tests/smoke/cli/test_service_mdns-repeater.py", line 47, in tearDown
DEBUG -     self.assertTrue(process_named_running('avahi-daemon'))
DEBUG - AssertionError: None is not true
DEBUG - 
DEBUG - ======================================================================
DEBUG - FAIL: test_service_ipv6 (__main__.TestServiceMDNSrepeater.test_service_ipv6)
DEBUG - ----------------------------------------------------------------------
DEBUG - Traceback (most recent call last):
DEBUG -   File "/usr/libexec/vyos/tests/smoke/cli/test_service_mdns-repeater.py", line 47, in tearDown
DEBUG -     self.assertTrue(process_named_running('avahi-daemon'))
DEBUG - AssertionError: None is not true
DEBUG - 
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 3 tests in 11.145s
DEBUG - 
DEBUG - FAILED (failures=3)
indrajitr added a comment.Dec 2 2023, 3:08 AM

Looks like, we still need to keep /etc/avahi/services because avahi-daemon chroot to that location at startup. This is set up at build time via AVAHI_CONFIG_DIR and there is no way to change it at runtime.

Oddly this worked for me locally because I had a stray /etc/avahi/services directory lying around.

Fix coming up.

indrajitr added a comment.Dec 2 2023, 3:12 AM

@Viacheslav, updated PR https://github.com/vyos/vyos-1x/pull/2562

Restricted Repository Identity mentioned this in rVYOSONEXcc11f6756e3c: Merge pull request #2562 from indrajitr/avahi-cleanup-2.Dec 2 2023, 7:43 AM
indrajitr mentioned this in rVYOSONEX2b57ca6c3f9f: mdns: T5793: Cleanup avahi-daemon configuration in `/etc`.Dec 2 2023, 7:43 AM
Restricted Repository Identity mentioned this in rVYOSONEX6c42dbfd9473: mdns: T5793: Cleanup avahi-daemon configuration in `/etc`.Dec 2 2023, 7:44 AM
Restricted Repository Identity mentioned this in rVYOSONEXe0a6f8fa7ef1: Merge pull request #2563 from vyos/mergify/bp/sagitta/pr-2562.Dec 2 2023, 7:54 AM
Viacheslav closed this task as Resolved.Dec 14 2023, 8:00 PM
Viacheslav claimed this task.
Viacheslav reassigned this task from Viacheslav to indrajitr.