found the bug in ospf_interfaces bug. This code (both for 1.3- and 1.4+) does not cut it:

https://github.com/vyos/vyos.vyos/pull/387

https://github.com/vyos/vyos.vyos/pull/379

Working on this one. The changes are more significant than I expected, partially due to address being plural now.

PR submitted

I've got a patch nearly ready

should be fixed by https://github.com/vyos/vyos.vyos/pull/382

https://github.com/vyos/vyos.vyos/pull/381

https://github.com/vyos/vyos.vyos/pull/380

• Raised https://github.com/vyos/vyos.vyos/pull/379
• Completed integration tests for 1.3- but 1.4+ fails - need to workaround unsupported commands in tests setup (e..g 'config-trap' and look into module code as new stanzas are not handled correctly (e.g. log vs log 'enable')
• Unit tests are failing after the parser regex change - need to fix them too

https://github.com/vyos/vyos.vyos/pull/378

Confirmed - 1.2-1.5 are failing

Confirmed that 1.4 and 1.5 is no cigar

Confirmed - integration tests are failing for the 1.2-1.5 version

This issue should have been resolved by a number of already implemented PRs - e.g. https://github.com/vyos/vyos.vyos/pull/354 or https://github.com/vyos/vyos.vyos/pull/368, therefore I am closing this ticket now. Please feel free to re-open if I am wrong

L3 tests working

Working in the branch, prepared for merge

https://github.com/vyos/vyos.vyos/pull/373

I can see the tests are NOK for all the versions - working in a separate branch to fix

Are we closing this? Or we have some glowing example of the wrong processing?

Almost done - just looking at failing overriden before dict issue - other integration tests seem to be working now

Started to put the patches together in https://github.com/vyos/vyos.vyos/pull/368

The recent updates to vyos_user should support updating encrypted passwords, including appropriately understanding if there was a change.

@sdwilsh Unless you have an objection, I'm going to close this out as fixed by the current version in Main.

@sever should we move this to VyOS project instead of VyOS Ansible Collection, since the problem here was with 1.4.0?

Essential for release.

Essential for release

Important release test

1.4 and 1.5 working

Changes appear trivial enough I'm going to make them now

Going to need to fix testing for fw_rules as a part of my current work - so picking this up...

Needed before 6.0.0 release

vyos_config Integration tests under 1.4 and 1.5+ pass when run against each machine singly, so these changes may not be necessary to get integration tests running before the 6.0.0 release.

This was an error on my part, I needed to update the ansible.netcommon collection