Page MenuHomeVyOS Platform

vyos_config integration tests fail when run in parallel
Closed, ResolvedPublicBUG

Description

Running the vyos_config tests is not very reliable under versions after v1.2

v1.4.1 and 1.5-rolling are capable of completing when run alone, but fail when run on multiple hosts at the same time.

Failure occurs during START cli_config/cli_comment.yaml on connection=ansible.netcommon.network_cli at vyos_config : delete configurable backup file path), which is a local file operation/

Setting ignore_errors: true for these delete commands seems to fix the problem, although that may cause some inaccuracy in the tests.

The actual problem here is that the tests aren't intended to be run on more than one host at a time and local filesystem changes do not anticipate multiple threads.

Note: 1.3.8 failures are not accounted for here because they have a separate cause. These may need to be disabled for running in batch.

Details

Version
6.0.0
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

gaige triaged this task as Normal priority.

vyos_config Integration tests under 1.4 and 1.5+ pass when run against each machine singly, so these changes may not be necessary to get integration tests running before the 6.0.0 release.

This turns out to be a simple fix. The problem is an issue with deleting directories on separate threads when running with multiple targets. Simple fix is to run_once: true the two places where this happens. Not surprisingly, this fix works.

Preparing PR.

gaige changed the task status from Open to In progress.Feb 9 2025, 6:47 PM