Page MenuHomeVyOS Platform

Fix integration tests for firewall-global
Closed, ResolvedPublicBUG

Description

Firewall-global integration tests fail on 1.2 and above due mostly to changes in the configuration mechanism.

These tests fail almost immediately and faster in 1.4 and above due to the global configuration changes moving things in the hierarchy.

Likely will require breaking up 1.3 and before from 1.4+ and adding new tests similar to what we've done in vyos_bgp_global.

Details

Version
6.0.0
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)
Story points
2

Event Timeline

gaige triaged this task as High priority.

Confirmed - integration tests are failing for the 1.2-1.5 version

evgmol changed the task status from Open to Confirmed.Sun, Jan 26, 11:41 PM
  • Raised https://github.com/vyos/vyos.vyos/pull/379
  • Completed integration tests for 1.3- but 1.4+ fails - need to workaround unsupported commands in tests setup (e..g 'config-trap' and look into module code as new stanzas are not handled correctly (e.g. log vs log 'enable')
  • Unit tests are failing after the parser regex change - need to fix them too