Page MenuHomeVyOS Platform
Create Task
Maniphest T7004

vyos_firewall_rules integration tests fail
Open, HighPublicBUG
Actions

Description

Firewall-rules integration tests fail on 1.2 and above due mostly to changes in the configuration mechanism.

These tests fail almost immediately and faster in 1.4 and above due to the global configuration changes moving things in the hierarchy.

Likely will require breaking up 1.3 and before from 1.4+ and adding new tests similar to what we've done in vyos_bgp_global.

Details

Version
6.0.0
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)
Story points
2

Event Timeline

gaige created this task.Sat, Jan 4, 9:38 AM
gaige triaged this task as High priority.
pasik subscribed.Sat, Jan 4, 10:29 AM
evgmol claimed this task.Sat, Jan 4, 10:38 AM

Going to need to fix testing for fw_rules as a part of my current work - so picking this up...

gaige renamed this task from Fix vyos_firewall_rules integration tests to vyos_firewall_rules integration tests fail.Sat, Jan 4, 11:50 AM
evgmol added a comment.Thu, Jan 9, 11:46 AM

Started to put the patches together in https://github.com/vyos/vyos.vyos/pull/368

evgmol added a comment.Tue, Jan 14, 8:46 PM

Almost done - just looking at failing overriden before dict issue - other integration tests seem to be working now