https://github.com/vyos/vyos.vyos/pull/413

https://github.com/vyos/vyos.vyos/pull/412 to fix it

There was no a change - I tested with the existing code in truck and could not replicate the issue - hence the question, given this is a pretty old bug report

This seems to be implemented:

https://github.com/vyos/vyos.vyos/pull/404

https://github.com/vyos/vyos.vyos/pull/402

https://github.com/vyos/vyos.vyos/pull/402

Hi,
I tested with 520-700+ character long strings and the bug is not evident in 1.3- or1.4+ versions
Can you please re-rest and advise this issue still persist

Are we happy with the above patch (fixing the terminal)?

After some investigation, it can be advised, that the described issue is to do with netcomm_cli module implementation used by VyOS Ansible Galaxy - namely, the ansible_net_version is set for a connection and stays so until reconnects and re-reads the modified hostname.
As such, this is currently outside of the collection's control.
That said, the issue can be easily avoided by reading ansible_facts mid-playbook:
Example Playbook:

https://github.com/vyos/vyos.vyos/pull/400

@pasik Hi mate! Were you the original reporter of this bug please?
If so, can you clarify a few questions I asked above?
thank you

Can we close it?

I cannot see the virtual interface names are supported in 1.3-1.5 -

Just a single one to go https://github.com/vyos/vyos.vyos/pull/395

PR399 is ready for review

Attempting to re-init work here https://github.com/vyos/vyos.vyos/pull/399

https://github.com/vyos/vyos.vyos/pull/398 - Ready

I will look into after https://github.com/vyos/vyos.vyos/pull/387

I can look into this after https://github.com/vyos/vyos.vyos/pull/387 is actioned

https://github.com/vyos/vyos.vyos/pull/395 for OSPFv2 fixes - both unit and integration

Follow-up https://github.com/vyos/vyos.vyos/pull/394 is for ospfv3 integration tests

found the bug in ospf_interfaces bug. This code (both for 1.3- and 1.4+) does not cut it:

https://github.com/vyos/vyos.vyos/pull/387

https://github.com/vyos/vyos.vyos/pull/379

should be fixed by https://github.com/vyos/vyos.vyos/pull/382

https://github.com/vyos/vyos.vyos/pull/381

https://github.com/vyos/vyos.vyos/pull/380

• Raised https://github.com/vyos/vyos.vyos/pull/379
• Completed integration tests for 1.3- but 1.4+ fails - need to workaround unsupported commands in tests setup (e..g 'config-trap' and look into module code as new stanzas are not handled correctly (e.g. log vs log 'enable')
• Unit tests are failing after the parser regex change - need to fix them too

https://github.com/vyos/vyos.vyos/pull/378

Confirmed - 1.2-1.5 are failing

Confirmed that 1.4 and 1.5 is no cigar

Confirmed - integration tests are failing for the 1.2-1.5 version

This issue should have been resolved by a number of already implemented PRs - e.g. https://github.com/vyos/vyos.vyos/pull/354 or https://github.com/vyos/vyos.vyos/pull/368, therefore I am closing this ticket now. Please feel free to re-open if I am wrong

https://github.com/vyos/vyos.vyos/pull/373

I can see the tests are NOK for all the versions - working in a separate branch to fix

Are we closing this? Or we have some glowing example of the wrong processing?

Almost done - just looking at failing overriden before dict issue - other integration tests seem to be working now

Started to put the patches together in https://github.com/vyos/vyos.vyos/pull/368

Going to need to fix testing for fw_rules as a part of my current work - so picking this up...

Raised a Draft PR https://github.com/vyos/vyos.vyos/pull/368

The fix is now a part of https://github.com/vyos/vyos.vyos/pull/367

the PR to fix this is https://github.com/vyos/vyos.vyos/pull/367

The PR tp fix this https://github.com/vyos/vyos.vyos/pull/367

The PR# is re-submitted for review and testing

Raised https://github.com/vyos/vyos.vyos/pull/365

It appears that path-limit GBP network options is deprecated

I did some investigation - apparently the plugin cannot match the full command pattern (including optional attributes) and silently refuses to generate a resultant set of commands - I will be looking into this - most likely the issue is related to rm_templates regex patterns for getval

Update - I cloned the current vyo.vyos changes, created a branch and made the changes that Maxime proposed.

sure, ok - I will do needful for it to be tests ready
It does not appear a huge change to me