Page MenuHomeVyOS Platform
Create Task
Maniphest T7012

vyos_ospf_interfaces, vyos_ospfv2 and vyos_ospfv3 fail integration tests
Closed, ResolvedPublicBUG
Actions

Description

These modules were modified for compatibility with 1.3+, but did nto have integration test changes made. Some tests succeed in 1.3, but there will need to be adjustments for the multi-pronged tests, similar to what we did with BGP when using get_version in order to handle the parameter differences and config schema differences

Details

Version
6.0.0
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Revisions and Commits

R52 VyOS Ansible Collection
R52:8f7cc603d7f6 T7012 OSPFv3 integration tests fixes (#394)

Event Timeline

gaige created this task.Jan 4 2025, 10:13 PM
gaige triaged this task as High priority.

Important release test

pasik subscribed.Jan 5 2025, 9:49 AM
evgmol claimed this task.Feb 4 2025, 8:48 AM
evgmol added a comment.Feb 5 2025, 2:15 AM

https://github.com/vyos/vyos.vyos/pull/387

evgmol added a comment.EditedFeb 6 2025, 9:46 PM

found the bug in ospf_interfaces bug. This code (both for 1.3- and 1.4+) does not cut it:

def get_config_set_1_4(self, data):
    """To classify the configurations beased on interface"""
    interface_list = []
    config_set = []
    int_string = ""
    for config_line in data.splitlines():
        ospf_int = re.search(r"set protocols (?:ospf|ospfv3) interface (\S+) .*", config_line)
        if ospf_int:
            if ospf_int.group(1) not in interface_list:
                if int_string:
                    config_set.append(int_string)
                interface_list.append(ospf_int.group(1))
                int_string = ""
            int_string = int_string + config_line + "\n"
    if int_string:
        config_set.append(int_string)
    return config_set

We are lucky for 1.3- as the conf set from a device comes pretty ordered:

set interfaces bonding bond2 ip ospf transmit-delay '45'
set interfaces bonding bond2 ipv6 ospfv3 passive
set interfaces ethernet eth0 address '192.168.122.84/24'
set interfaces ethernet eth0 ip ospf cost '50'
set interfaces ethernet eth0 ip ospf priority '26'
set interfaces ethernet eth0 ipv6 ospfv3 instance-id '33'
set interfaces ethernet eth0 ipv6 ospfv3 mtu-ignore

and the config_set gets pretty solid:

"set interfaces bonding bond2 ip ospf transmit-delay '45'\nset interfaces bonding bond2 ipv6 ospfv3 passive\n",
"set interfaces ethernet eth0 address '192.168.122.84/24'\nset interfaces ethernet eth0 hw-id '52:54:00:cd:4f:e5'\nset interfaces ethernet eth0 ip ospf cost '50'\nset interfaces ethernet eth0 ip ospf priority '26'\nset interfaces ethernet eth0 ipv6 ospfv3 instance-id '33'\nset interfaces ethernet eth0 ipv6 ospfv3 mtu-ignore\n",

unlike 1.4+ (unordered and concatenation breaks):

set protocols ospf interface bond2 transmit-delay '45'
set protocols ospf interface eth0 cost '50'
set protocols ospf interface eth0 priority '26'
set protocols ospfv3 interface bond2 passive
set protocols ospfv3 interface eth0 instance-id '33'
set protocols ospfv3 interface eth0 mtu-ignore

"set protocols ospf interface bond2 transmit-delay '45'\n",
"set protocols ospf interface eth0 cost '50'\nset protocols ospf interface eth0 priority '26'\nset protocols ospfv3 interface bond2 passive\nset protocols ospfv3 interface eth0 instance-id '33'\nset protocols ospfv3 interface eth0 mtu-ignore\n"

This results in bond2 ospfv3 parameter ('passive') appear in eth0

evgmol added a comment.EditedFeb 12 2025, 7:02 AM

Follow-up https://github.com/vyos/vyos.vyos/pull/394 is for ospfv3 integration tests

gaige added a commit: R52:8f7cc603d7f6: T7012 OSPFv3 integration tests fixes (#394).Feb 12 2025, 10:57 PM
evgmol added a comment.Feb 17 2025, 5:49 AM

https://github.com/vyos/vyos.vyos/pull/395 for OSPFv2 fixes - both unit and integration

evgmol added a comment.Mar 2 2025, 11:21 PM

Just a single one to go https://github.com/vyos/vyos.vyos/pull/395

evgmol closed this task as Resolved.Apr 2 2025, 11:19 PM