Page MenuHomeVyOS Platform
Create Task
Maniphest T4316

Update save-config/load-config
Open, NormalPublicBUG
Actions

Description

The two tasks T4292 (Rewrite vyatta-save-config.pl to Python) and T4295 (Use config_tree instead of legacy loadFile in vyos-load-config.py) go together in the sense of removing legacy code; they have a common dependency T4291 (Consolidate component version read/write functions).

They are gathered here to present one PR; all complete, but for a trivial bug and testing.

Update: as discussed in T4295, this PR will be replaced with a PR covering just the component version IO clean up and the rewrite of save-config.

Details

Version
vyos-1.4, vyos-1.3
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

StatusSubtypeAssignedTask
 In progressFEATURE REQUESTNoneT3355 Remove all remaining legacy Vyatta code
 OpenBUGNoneT4316 Update save-config/load-config
 Not ApplicableFEATURE REQUESTjestabroT4295 Use config_tree instead of legacy loadFile in vyos-load-config.py
 OpenFEATURE REQUESTNoneT3441 More intelligent config loading scripts
 ResolvedFEATURE REQUESTjestabroT5248 Ability to load config via API in JSON format
 ResolvedBUGjestabroT4382 Replacing legacy loadFile exposes missing steps in migration scripts and other errors
 ResolvedENHANCEMENTjestabroT5528 Replace legacy loadFile with config_diff
 ResolvedENHANCEMENTjestabroT5815 Add load_config module
 ResolvedENHANCEMENTjestabroT5400 Move libvyosconfig build out of the Docker image
 ResolvedBUGjestabroT7289 Add libvyosconfig as git submodule of vyos-1x for stream builds
 ResolvedENHANCEMENTjestabroT6717 Add hybrid Cstore manipulation library to replace set/delete/load_config functionality
 ResolvedENHANCEMENTjestabroT6718 Use vyconf daemon for validation of set commands
 ResolvedENHANCEMENTjestabroT6946 Add initial commit algorithm to vyconf
 ResolvedENHANCEMENTjestabroT7121 Set up communication vyconfd <-> vyos-configd
 ResolvedENHANCEMENTjestabroT7272 Vyconf: update in memory config tree on response from vyos-commitd
 OpenENHANCEMENTjestabroT7292 Expose vyconf commit algorithm for CLI and ConfigSession instance
 ResolvedENHANCEMENTjestabroT7302 Implement commit dry-run for vyconfd/vyos-commitd
 ResolvedENHANCEMENTjestabroT7321 Replace legacy operations in configsession.py with vyconf client operations
 OpenENHANCEMENTjestabroT7374 Integrate vyconf config session with CLI config session
 ResolvedENHANCEMENTjestabroT7910 Standardize vyconf session resource management across Python config modules
 ResolvedBUGjestabroT7637 Fix typo in commit algorithm
 ResolvedBUGjestabroT7688 Correct the management of delete paths on vyconfd delete and commit requests
 OpenBUGjestabroT6959 Add support for addons after switch to internal reference tree
 ResolvedENHANCEMENTjestabroT7046 Add utilities for update of reference tree
 ResolvedjestabroT4291 Consolidate component version read/write functions
 ResolvedFEATURE REQUESTjestabroT4292 Rewrite vyatta-save-config.pl to Python
 ResolvedFEATURE REQUESTjestabroT5500 Minor fixes to configtree render

Event Timeline

jestabro created this task.Mar 24 2022, 12:25 PM
jestabro created this object in space S1 VyOS Public.
jestabro updated the task description. (Show Details)Mar 24 2022, 12:27 PM
erkin edited subscribers, added: erkin; removed: Global Notifications.Mar 24 2022, 2:09 PM
erkin added a parent task: T3355: Remove all remaining legacy Vyatta code.Mar 24 2022, 2:13 PM
jestabro added a subtask: T4292: Rewrite vyatta-save-config.pl to Python.Mar 24 2022, 8:04 PM
jestabro added a subtask: T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py.
jestabro reopened subtask T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py as Open.Mar 24 2022, 8:06 PM
jestabro added a subtask: T4291: Consolidate component version read/write functions.
jestabro reopened subtask T4291: Consolidate component version read/write functions as Open.Mar 24 2022, 8:09 PM
pasik subscribed.Mar 24 2022, 8:17 PM
jestabro added a comment.May 18 2022, 8:51 PM

Draft PR here:
https://github.com/vyos/vyos-1x/pull/1328

jestabro updated the task description. (Show Details)Jun 28 2022, 7:56 PM
jestabro changed the status of subtask T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py from Open to On hold.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.2); removed VyOS 1.3 Equuleus, VyOS 1.4 Sagitta.Aug 14 2022, 1:05 PM
dmbaturin edited projects, added VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus (1.3.2).Aug 14 2022, 6:10 PM
jestabro added a comment.Sep 5 2022, 11:25 AM

PR https://github.com/vyos/vyos-1x/pull/1328 replaced by:
https://github.com/vyos/vyos-1x/pull/1515

jestabro closed subtask T4291: Consolidate component version read/write functions as Resolved.Oct 28 2022, 7:26 PM
jestabro reopened subtask T4292: Rewrite vyatta-save-config.pl to Python as In progress.Aug 22 2023, 11:36 PM
jestabro closed subtask T4292: Rewrite vyatta-save-config.pl to Python as Resolved.Aug 24 2023, 7:32 PM
jestabro closed subtask T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py as Not Applicable.Jan 16 2024, 3:34 AM
Viacheslav triaged this task as Normal priority.Jan 20 2024, 10:56 AM
olofl subscribed.Feb 26 2024, 11:14 AM

On 1.4.0-epa1, there is no longer an indication that configuration file actually has been saved.

olofl@vyos01# commit
[edit]
olofl@vyos01# save
[edit]
syncer edited projects, added VyOS 1.4 Sagitta (1.4.0-GA); removed VyOS 1.4 Sagitta.May 7 2024, 8:03 AM
vyosbot removed jestabro as the assignee of this task.Aug 6 2024, 6:02 AM
syncer edited projects, added VyOS Rolling; removed VyOS 1.4 Sagitta (1.4.0-GA).Oct 30 2024, 12:50 PM
syncer subscribed.

@jestabro can you tell what we should do with this
Thanks!

syncer changed the subtype of this task from "Task" to "Bug".Oct 30 2024, 12:51 PM
syncer moved this task from Need Triage to Backlog - Bug on the VyOS Rolling board.
syncer added a subscriber: Global Notifications.Nov 1 2024, 9:19 PM