I think this was resolved at some point, but I ended up removing it (the accept-protocol stuff) from my config since it didn't appear necessary and was causing issues, so I'm not certain.

For 1.4 also fixed

vyos@r1-right:~$ show version all | match "GNU C L"
ii  libc-bin                             2.36-9+deb12u7                   amd64        GNU C Library: Binaries
ii  libc-l10n                            2.36-9+deb12u7                   all          GNU C Library: localization files
ii  libc6:amd64                          2.36-9+deb12u7                   amd64        GNU C Library: Shared libraries
ii  locales                              2.36-9+deb12u7                   all          GNU C Library: National Language (locale) data [support]
vyos@r1-right:~$ 
vyos@r1-right:~$ show ver
Version:          VyOS 1.4-stable-202405090309
Release train:    sagitta

Fixed

vyos@r1-right:~$ show version all | match "GNU C L"
ii  libc-bin                             2.28-10+deb10u3                amd64        GNU C Library: Binaries
ii  libc-l10n                            2.28-10+deb10u3                all          GNU C Library: localization files
ii  libc6:amd64                          2.28-10+deb10u3                amd64        GNU C Library: Shared libraries
ii  locales                              2.28-10+deb10u3                all          GNU C Library: National Language (locale) data [support]
vyos@r1-right:~$ 
vyos@r1-right:~$ show version

there is some issue https://github.com/vyos/vyos-1x/actions/runs/9013844673/job/24765384018?pr=3431

Please approve https://github.com/vyos/vyos-1x/pull/3431

Added codeowner file and basis pr templates and checks
https://github.com/vyos/.github/pull/1
Please review the PR

set policy local-route doesn't make sense to me to have a geoip network group, however geoip in set policy route allows for greater flexibility while performing routing to ensure traffic traverse through specific destination for compliance and regulatory purposes.

@alainlamar can you check my PR https://github.com/vyos/vyos-1x/pull/3430 ?

Ok, Sure.

Added access to organization's .github repository
we probably want to keep PR templates and what else there too(will create separate task)

Sure, let's do it that way
Thanks @Vijayakumar

@syncer Just want to know whether we considered using the CODEOWNERS file to achieve this
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Behavior change for this issue was fix some month ago in migration scripts, in order to remain action "return" when upgrading from older versions to new syntax.

Note that the work in the link above, but for the get_commit_schedule function itself, has already been added in subtasks T6319/T6146. As mentioned above, the get_commit_schedule function is not useful (and potentially misleading) until we replace the legacy commit algorithm in 1.5. Remove 1.4.0 tag.

speed test info:

looks like the problem doesn't reproduce on the newest VyOS version (1.5 and 1.4)

Should be fixed in https://github.com/vyos/vyos-build/pull/600

Please review and approve/merge https://github.com/vyos/vyos-github-actions/pull/2

Mostly impossible for policy local-route
I'm not expecting that it will be implemented at all.

with the fix n.fort put in this feature is greatly sort after, definitely a thump up from me.

Yes this is indeed resolved after switching to 1.5-rolling-202405070019, thank you so much @n.fort and @Viacheslav

https://github.com/vyos/vyos-1x/pull/3421 Merged