Maniphest T6310

Change branches for CodeQL on push
Closed, ResolvedPublicFEATURE REQUEST
Actions

Assigned To

Authored By

	Viacheslav
	May 7 2024, 7:53 AM

Tags

Referenced Files

None

Subscribers

Description

Currently, we have crux and do not have sagitta in the branches https://github.com/vyos/vyos-1x/blob/5b2436fbec8e5279c8b27c03819b1607c1eca0af/.github/workflows/codeql-caller.yml#L17
It needs to fix it.
The crux is EOL and should be removed from the checking code.
Check branch names, some with double quotes, others without quotes.

Details

Version: -
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Unspecified (please specify)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Vijayakumar	T6707 Implement a new build and release workflow based on GitHub Actions
		Resolved	FEATURE REQUEST	Vijayakumar	T6309 Check code quality with CodeQL
		Resolved	FEATURE REQUEST	Vijayakumar	T6310 Change branches for CodeQL on push

Event Timeline

Viacheslav created this task.May 7 2024, 7:53 AM

Viacheslav assigned this task to Vijayakumar.

Viacheslav updated the task description. (Show Details)May 7 2024, 7:56 AM

Viacheslav updated the task description. (Show Details)

Vijayakumar mentioned this in rVYOSONEX2aa8428866fc: feat: T6310 updated codeql caller workflow branch list.May 7 2024, 8:33 AM

Added reusable workflow for codeql
Please review and approve
https://github.com/vyos/vyos-github-actions/pull/2

pasik subscribed.May 7 2024, 10:06 AM

Vijayakumar mentioned this in rVYOSONEX79b9eff95bf6: feat: added codeql caller workflow - added permissions.May 7 2024, 11:00 AM

Vijayakumar mentioned this in rVYOSONEX48bc5cfac4cd: feat: T6310 updated codeql caller version.

Vijayakumar mentioned this in rVYOSONEXbe51800ba390: feat: added codeql caller workflow - added permissions.May 7 2024, 11:02 AM

Used codeql reusable workflow in a reference repo.
Please review and merge
https://github.com/vyos/vyos-1x/pull/3420

Vijayakumar mentioned this in rVYOSONEX42bfaf9ebd1a: T6310: using codeql reusable workflow.May 7 2024, 12:27 PM

Few PR checks failing, i will check and fix

Vijayakumar mentioned this in rVYOSONEX3b4e1acbd30c: T6310: added codeql workflow.May 7 2024, 1:15 PM

Vijayakumar mentioned this in rVYOSONEXa9bb2388a1db: T6310: added codeql workflow and removed old codeql workflow.May 7 2024, 1:25 PM

Viacheslav triaged this task as Normal priority.May 7 2024, 3:34 PM

Restricted Repository Identity mentioned this in rVYOSONEX996f9af72d41: Merge pull request #3421 from vyos/feature/codeql.May 7 2024, 6:03 PM

https://github.com/vyos/vyos-1x/pull/3421 Merged

Vijayakumar closed this task as Resolved.May 7 2024, 6:26 PM

Viacheslav moved this task from Open to Finished on the VyOS 1.5 Circinus board.May 8 2024, 6:17 AM

syncer edited projects, added GitHub Infrastructure; removed VyOS 1.5 Circinus.May 8 2024, 11:50 AM