Page MenuHomeVyOS Platform

Add unicode support to configtree backend
Closed, ResolvedPublic

Description

The root cause of the error in T2941 is lack of support for unicode in the configtree backend: a direct translation of the utf-8 encoding from Python strings is overwritten by the String.escaped function in the output.

Details

Version
vyos-1.4
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

jestabro raised the priority of this task from Low to Normal.Sep 23 2021, 2:54 PM

https://github.com/vyos/vyos1x-config/pull/1

relaxes the condition to escape non-ascii bytes. Updating the commit id in the Dockerfile and relaxing the ascii restriction in configsource.py will allow unicode chars in config.

jestabro closed this task as Unknown Status.Jan 6 2022, 1:55 PM
jestabro updated the task description. (Show Details)
jestabro added a project: VyOS 1.3 Equuleus.
jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.

Backported to equuleus branch of vyos1x-config:
https://github.com/vyos/vyos1x-config/commit/8ad21f6c7e6f37edeca137b2a7dc7c3f7ffc6a20

Pin will be updated in docker image after other pending backports, at which point
config: T3785: drop restriction to ascii in decode (above)
will be cherry-picked to equuleus.

dmbaturin changed the task status from Unknown Status to Resolved.Aug 14 2022, 6:44 PM