Page MenuHomeVyOS Platform

Description doesnt seem to allow for non international characters
Closed, ResolvedPublicBUG

Description

As observed in: https://forum.vyos.io/t/upgrade-from-1-3-6-to-1-4-0-epa1-looses-complete-dhcp-configuration/13935

l0crian@R86S# set service dhcp-server shared-network-name TEST description 'Gäste' 
  
  Description too long (limit 256 characters)
  Value validation failed
  Set failed

The above gives catastrophic failure where the whole DHCP section vanishes during upgrade from 1.3.6 to 1.4.0-epa1 according to above post.

Proper fix if its not possible to support international characters to include some kind of transformation so "ä" becomes "ae" or "a". Same with "ö" who should become "oe" or "o" and "å" who should become "aa" or "a".

Another quick and dirty method would be to replace anything that isnt a-z, A-Z, 0-9, "-" and "_" with a "." (dot) or such when migrationscripts are running.

Sidenote, the error claiming that the description is longer than 256 characters is incorrect in this case since the description is just 5 characters long.

Details

Version
1.4.0-epa1
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Simple unicode support was allowed in
https://vyos.dev/T3785
however, the constraint on description, above, restricts to ascii.

Moreover, this constraint was enforced for all interface descriptions in
https://github.com/vyos/vyos-1x/commit/662bae181cdff07a2472d7121d18ae37d380e062

Finally, if we are to restore simple unicode support in descriptions, the PR (https://github.com/vyos/vyos-1x/pull/3035) for fixing the corner case of single backslashes in values will need to be fixed for a resulting bug in the case of a value containing both unicode and single backslashes: unlikely but not prohibited in that case.

jestabro triaged this task as High priority.Mar 5 2024, 3:05 PM

Note that the PR https://github.com/vyos/vyos-1x/pull/3035 is only for 1.5 at this point: the critical question for this task is whether or not to restore the simple support for unicode.

jestabro added a project: VyOS 1.5 Circinus.
jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
jestabro moved this task from Open to Finished on the VyOS 1.5 Circinus board.