Page MenuHomeVyOS Platform
Create Task
Maniphest T2175

Rewriting all FRR processes allow for reloading and to XML/Python style
Closed, ResolvedPublic
Actions

Description

Currently most FRR processes are following the old bash/perl guidelines and needs to be rewritten to XML/Python.

One of the biggest issues with the current implementation is that each process is configured separately with vtysh and the configuration is not saved to frr.conf.
This means that then a FRR process crashes the configuration is not saved and on restart it is not in sync with the configuration inside vyos.
In the current implementation i cant se a good way of fixing this issue.

During this work configuration for each FRR process needs to be moved into their respective protocol sub-config modes (eg. move ospf interface config from interface X ip ospf into protocols ospf interface X

An alternative is to make vyos-1x generate the process config for each frr process and merge each process config into frr.conf.
for this Danos could be used as an inspiration: https://github.com/danos/vyatta-protocols-frr/tree/master/scripts/frr

As for now there are no decision on what path to take on this restructuring.

This ticket is supposed to be used as a top level for all tickets related to FRR rewriting and bugs related to these.

Details

Difficulty level
Unknown (require assessment)
Version
1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)

Related Objects
Search...

StatusSubtypeAssignedTask
 In progressFEATURE REQUESTNoneT3355 Remove all remaining legacy Vyatta code
 Resolvedc-poT2175 Rewriting all FRR processes allow for reloading and to XML/Python style
 ResolvedFEATURE REQUESTc-poT2174 Rewrite protocol BGP to new XML/Python style
 ResolvedFEATURE REQUESTc-poT1315 Allow BGP to use address-family l2vpn evpn
 ResolvedFEATURE REQUESTc-poT2172 Enable conf VXLAN without remote address
 ResolvedFEATURE REQUESTc-poT3391 Add CLI support for specifying maximum-paths per address family ipv4 unicast and ipv6 unicast
 ResolvedFEATURE REQUESTViacheslavT2201 Rewrite protocol BGP [op-mode] to new XML/Python style
 ResolvedFEATURE REQUESTzsdcT1875 Add the ability to use network address as BGP neighbor (bgp listen range)
 ResolvedFEATURE REQUESTViacheslavT2315 Ability to have right address-family for BGP peers.
 ResolvedFEATURE REQUESTViacheslavT2387 Create XML scheme for [conf_mode] BGP
ResolvedBUGdmbaturinT2844 BGP conf_mode errors disable-send-community
 ResolvedBUGViacheslavT2828 BGP conf_mode error enforce-first-as
 ResolvedBUGdmbaturinT2845 BGP conf_mode unable to delete configuration with peer-group
 ResolvedFEATURE REQUESTc-poT2848 bgp-add-path configuration options
 ResolvedFEATURE REQUESTViacheslavT2850 Add BGP template for FRR
 WontfixzsdcT1941 Config mismatch with FRR on misconfiguration of V6 peer
 ResolvedFEATURE REQUESTViacheslavT3085 IPv6 BGP Neighbor Weight
 ResolvedjpbedeT3158 Rewrite protocol BGP IPv6 [op-mode] to new XML/Python style
 ResolvedFEATURE REQUESTViacheslavT3184 Add correct desctiptions for BGP neighbors
 Resolved N/ANoneT3203 BGP unnumbered - commit fails when route-reflector-client is set
 ResolvedBUGViacheslavT3222 Typo in BGP dampening description
 ResolvedBUGrunarT3227 Latest releases don't work with RPKI (crash)
 ResolvedBUGViacheslavT3225 Adding a BGP neighbor with an address on a local interface throws a vyos.frr.CommitError: Configuration FRR failed while committing code: ''
 ResolvedFEATURE REQUESTc-poT3308 BGP: add gracefull shutdown support
 ResolvedBUGViacheslavT3320 Bgp neighbor peer-group without peer-group fail
 DuplicateBUGNoneT3321 Bgp not possible to use internal|external remote as
 ResolvedBUGViacheslavT3322 Bgp neighbor timers not applyed to FRR config
 ResolvedBUGViacheslavT3323 Bgp ttl-security and ebgp-multihop fail
 ResolvedBUGViacheslavT3324 Bgp space in the password
 ResolvedBUGc-poT3325 Bgp listen-range wrong commit message
 ResolvedBUGc-poT3328 Bgp not possible to delete bgp route-map
ResolvedBUGViacheslavT3330 Bgp capability orf prefix-list fail
 ResolvedBUGViacheslavT3331 Bgp unsuppress-map should be as "value leafNode"
 ResolvedBUGc-poT3332 BGP unnumbered - UnboundLocalError: local variable 'peer_group' referenced before assignment
 ResolvedBUGViacheslavT3365 Bgp neighbor interface ordering for remote-as
 ResolvedFEATURE REQUESTc-poT3590 bgp: add option for limiting maximum number of prefixes to be sent to a peer
 ResolvedViacheslavT1514 Add ability to restart frr processes
 Resolvedc-poT3776 Rename FRR daemon restart op-mode commands
 ResolvedViacheslavT2547 Rewrite protocol RIP [conf-mode] to new XML/Python style
 ResolvedrunarT2638 FRR: New framework for configuring FRR
Resolvedc-poT3235 Rewrite protocol OSPF to new XML/Python style
 ResolvedViacheslavT3236 Add XML for [conf-mode] OSPF
 ResolvedFEATURE REQUESTc-poT3263 OSPF Hello subsecond timer
 Resolvedc-poT3244 Rewrite protocol OSPFv3 to new XML/Python style
 ResolvedViacheslavT3245 Add XML for protocol ospfv3 [conf-mode]
 Resolvedc-poT3255 Rewrite protocol RPKI to new XML/Python style
 ResolvedViacheslavT3256 Add XML for protocol RPKI [conf-mode]
 ResolvedrunarT3266 Deleting RPKI does not remove entire FRR configuration.
 ResolvedBUGc-poT3293 RPKI migration script errors out after CLI rewrite
 Resolvedc-poT3267 OSPF: move "interface ip ospf" configuration to "protocols ospf interface" tree
 Resolvedc-poT3272 OSPF: interface config is not removed
 ResolvedFEATURE REQUESTc-poT2450 Rewrite "protocols vrf" tree in XML and Python
 WontfixBUGc-poT2446 VRF IPv6 static routes subnet deletion
 ResolvedBUGc-poT2338 Can't delete static IPv6 route on vrf
 ResolvedFEATURE REQUESTViacheslavT3278 Add XML for "protocols vrf" [conf-mode]
 ResolvedNoneT3279 Rewrite protocol STATIC [op-mode] to new XML/Python style
 ResolvedViacheslavT3280 Add XML for [conf-mode] STATIC
 Resolvedc-poT3281 Rewrite protocol RIPng [conf-mode] to new XML/Python style
 ResolvedViacheslavT3282 Add XML for [conf-mode] RIPng
 Resolvedc-poT3310 BFD: migrate to get_config_dict() and FRR reload
 Resolvedc-poT3344 Per VRF dynamic routing support
 ResolvedFEATURE REQUESTc-poT2271 OSPF: add per VRF instance support
 Resolvedc-poT3345 BGP: add per VRF instance support
 DuplicateFEATURE REQUESTNoneT2257 BGP does not work with VRF
 Resolvedc-poT3417 ISIS: provide per VRF instance support
 ResolvedFEATURE REQUESTc-poT1711 BGP - migrate from tagNode to node (remove ASN from tagNode)
 Resolved N/ABUGdmbaturinT3479 route-maps containing "aggregator as" can not be deleted
 ResolvedBUGc-poT3523 VRF BGP daemon route-map command missing
 ConfirmedBUGrunarT3529 vyos.frr class has no support for multi-line modify_section
 ResolvedBUGc-poT3530 BGP peer-group can't contain a hyphen
 ResolvedBUGc-poT3531 policy: prefix-list and route-map names do not allow underscores in names (FRR does)
 Resolvedc-poT3757 OSPF: add support to configure the area at an interface level

Event Timeline

runar created this task.Mar 29 2020, 12:38 PM
runar created this object in space S1 VyOS Public.
Viacheslav added a subscriber: Viacheslav.Mar 29 2020, 12:46 PM
runar added a subtask: T2174: Rewrite protocol BGP to new XML/Python style.Mar 29 2020, 2:53 PM
runar mentioned this in T1579: Rewrite all interface types in new XML/Python style.Apr 2 2020, 12:20 PM
runar added a subtask: T2271: OSPF: add per VRF instance support.Apr 11 2020, 5:10 PM
runar added a subtask: T1514: Add ability to restart frr processes.Apr 13 2020, 10:18 AM
mpueschel added a subscriber: mpueschel.Apr 20 2020, 10:11 AM
Unknown Object (User) added a subscriber: Unknown Object (User).May 25 2020, 2:32 PM
Viacheslav changed the status of subtask T2547: Rewrite protocol RIP [conf-mode] to new XML/Python style from Open to Needs testing.Jun 24 2020, 9:49 AM
Unknown Object (User) added a subscriber: Unknown Object (User).Aug 17 2020, 11:33 AM
Magnum added a subscriber: Magnum.Sep 5 2020, 10:40 AM
tuxnet added a subscriber: tuxnet.Nov 19 2020, 7:02 PM
c-po changed the status of subtask T3235: Rewrite protocol OSPF to new XML/Python style from Open to Needs testing.Jan 23 2021, 12:03 PM
c-po changed the status of subtask T2174: Rewrite protocol BGP to new XML/Python style from Open to Needs testing.
c-po changed the status of subtask T2638: FRR: New framework for configuring FRR from Open to Needs testing.
pasik added a subscriber: pasik.Jan 23 2021, 1:19 PM
c-po changed the status of subtask T3244: Rewrite protocol OSPFv3 to new XML/Python style from Open to Needs testing.Jan 24 2021, 1:44 PM
c-po changed the status of subtask T3255: Rewrite protocol RPKI to new XML/Python style from Open to In progress.Jan 26 2021, 7:13 PM
c-po closed subtask T3235: Rewrite protocol OSPF to new XML/Python style as Resolved.Jan 27 2021, 5:36 PM
c-po closed subtask T3244: Rewrite protocol OSPFv3 to new XML/Python style as Resolved.
c-po changed the status of subtask T3255: Rewrite protocol RPKI to new XML/Python style from In progress to Needs testing.Jan 29 2021, 10:04 AM
c-po closed subtask T3267: OSPF: move "interface ip ospf" configuration to "protocols ospf interface" tree as Resolved.Jan 29 2021, 2:01 PM
c-po closed subtask T3272: OSPF: interface config is not removed as Resolved.Jan 29 2021, 4:29 PM
c-po added a subtask: T2450: Rewrite "protocols vrf" tree in XML and Python.Jan 30 2021, 12:27 PM
c-po closed subtask T3255: Rewrite protocol RPKI to new XML/Python style as Resolved.Jan 31 2021, 12:42 PM
c-po reopened subtask T3255: Rewrite protocol RPKI to new XML/Python style as Backport pending.
c-po closed subtask T3255: Rewrite protocol RPKI to new XML/Python style as Resolved.Feb 2 2021, 9:08 PM
c-po closed subtask T2450: Rewrite "protocols vrf" tree in XML and Python as Resolved.Feb 5 2021, 10:17 PM
c-po closed subtask T2547: Rewrite protocol RIP [conf-mode] to new XML/Python style as Resolved.Feb 6 2021, 9:09 AM
c-po closed subtask T3281: Rewrite protocol RIPng [conf-mode] to new XML/Python style as Resolved.Feb 11 2021, 6:55 PM
c-po closed subtask T3279: Rewrite protocol STATIC [op-mode] to new XML/Python style as Resolved.Feb 11 2021, 7:01 PM
c-po closed subtask T2638: FRR: New framework for configuring FRR as Resolved.
c-po closed subtask T2174: Rewrite protocol BGP to new XML/Python style as Resolved.Feb 13 2021, 8:50 PM
c-po closed subtask T3310: BFD: migrate to get_config_dict() and FRR reload as Resolved.Feb 16 2021, 6:26 PM
c-po created subtask T3344: Per VRF dynamic routing support.Feb 21 2021, 8:46 AM
c-po changed the status of subtask T2271: OSPF: add per VRF instance support from Open to Blocked.Feb 21 2021, 8:49 AM
c-po added a parent task: T3355: Remove all remaining legacy Vyatta code.Feb 25 2021, 3:17 PM
c-po changed the status of subtask T2271: OSPF: add per VRF instance support from Blocked to In progress.Mar 11 2021, 6:28 PM
c-po added a subtask: T1711: BGP - migrate from tagNode to node (remove ASN from tagNode).Mar 14 2021, 9:55 AM
c-po closed subtask T3344: Per VRF dynamic routing support as Resolved.Mar 14 2021, 2:02 PM
c-po closed subtask T2271: OSPF: add per VRF instance support as Resolved.
c-po changed the status of subtask T1711: BGP - migrate from tagNode to node (remove ASN from tagNode) from Open to In progress.Mar 29 2021, 4:30 PM
c-po closed subtask T1711: BGP - migrate from tagNode to node (remove ASN from tagNode) as Resolved.Mar 29 2021, 6:17 PM
c-po added a subtask: T3479: route-maps containing "aggregator as" can not be deleted.Apr 17 2021, 7:01 PM
c-po added a subtask: T3523: VRF BGP daemon route-map command missing.May 8 2021, 7:33 PM
c-po added a subtask: T3530: BGP peer-group can't contain a hyphen.May 9 2021, 9:17 AM
c-po added a subtask: T3531: policy: prefix-list and route-map names do not allow underscores in names (FRR does).
c-po closed subtask T3531: policy: prefix-list and route-map names do not allow underscores in names (FRR does) as Resolved.May 9 2021, 5:00 PM
c-po closed this task as Resolved.May 9 2021, 6:24 PM
c-po claimed this task.
c-po triaged this task as Normal priority.
c-po created subtask T3757: OSPF: add support to configure the area at an interface level.Aug 15 2021, 10:41 AM
c-po closed subtask T3757: OSPF: add support to configure the area at an interface level as Resolved.Aug 15 2021, 11:02 AM
c-po closed subtask T1514: Add ability to restart frr processes as Resolved.Aug 25 2021, 12:28 PM
dmbaturin closed subtask T3479: route-maps containing "aggregator as" can not be deleted as Resolved N/A.Jan 9 2024, 8:48 PM