Maniphest T3222

Typo in BGP dampening description
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	craterman
	Jan 16 2021, 9:16 AM

Tags

Referenced Files

	F1118188: dampening.PNG
	Jan 16 2021, 9:16 AM

Subscribers

Global Notifications

Description

There is a few mistakes in BGP dampening description

dampening.PNG (675×990 px, 43 KB)

Details

Version: 1.4-rolling-202101110217
Is it a breaking change?: Perfectly compatible
Issue type: Cosmetic issue (typos etc.)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		In progress	FEATURE REQUEST	None	T3355 Remove all remaining legacy Vyatta code
		Resolved		c-po	T2175 Rewriting all FRR processes allow for reloading and to XML/Python style
		Resolved	FEATURE REQUEST	c-po	T2174 Rewrite protocol BGP to new XML/Python style
		Resolved	BUG	Viacheslav	T3222 Typo in BGP dampening description

Event Timeline

craterman created this task.Jan 16 2021, 9:16 AM

Viacheslav added a parent task: T2174: Rewrite protocol BGP to new XML/Python style.Jan 16 2021, 10:52 AM

PR https://github.com/vyos/vyos-1x/pull/685

Restricted Repository Identity mentioned this in rVYOSONEX29e8af4dd839: Merge pull request #685 from sever-sever/T3222.Jan 16 2021, 1:50 PM

Restricted Repository Identity mentioned this in rVYOSONEX26d78796b099: bgp: T3222: Fix help descriptions for dampening.Jan 16 2021, 1:50 PM

Viacheslav changed the task status from Open to Needs testing.Jan 16 2021, 3:03 PM

Viacheslav claimed this task.

Thank you @craterman for starting testing of our new BGP implementation.

pasik subscribed.Jan 17 2021, 10:37 AM

Fixed in VyOS 1.4-rolling-202101171022

c-po closed this task as Resolved.Jan 17 2021, 5:42 PM

Looks good. But maybe it is reasonable to change argument start-suppress-time to start-suppress because it is not a time, but penalty points

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Mar 18 2021, 4:27 PM

c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.May 24 2021, 7:41 PM

SrividyaA renamed this task from BGP dampening description to Typo in BGP dampening description.Aug 30 2021, 5:22 PM

SrividyaA set Issue type to Cosmetic issue (typos etc.).

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:26 PM

syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.