Page MenuHomeVyOS Platform
Create Task
Maniphest T2845

BGP conf_mode unable to delete configuration with peer-group
Closed, ResolvedPublicBUG
Actions

Description

Unable to delete protocol bgp configuration if it uses "peer-group".
To reproduce.

set protocols bgp 65001 neighbor 10.0.0.2 interface peer-group 'foo'
set protocols bgp 65001 neighbor 10.0.0.2 interface remote-as '65002'
set protocols bgp 65001 peer-group foo
commit

vyos@r4-roll# delete protocols bgp 
[edit]
vyos@r4-roll# commit
[ protocols bgp 65001 ]
% Create the bgp interface first
Error configuring routing subsystem.  See log for more detailed information

[edit]
vyos@r4-roll#

Vtysh

!
router bgp 65001
 neighbor foo peer-group
!

Or 'internal' or 'external' param

set protocols bgp 65001 neighbor 10.0.0.2 interface peer-group 'foo'
set protocols bgp 65001 neighbor 10.0.0.2 interface remote-as 'internal'
set protocols bgp 65001 peer-group foo
commit

vyos@r4-roll# commit
[ protocols bgp 65001 ]
% Create the bgp interface first
Error configuring routing subsystem.  See log for more detailed information

[edit]
vyos@r4-roll#

Vtysh

!
router bgp 65001
 neighbor foo peer-group
!

Details

Version
VyOS 1.3-rolling-202008260118
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

Viacheslav created this task.Aug 31 2020, 9:19 AM
Viacheslav added a parent task: T2174: Rewrite protocol BGP to new XML/Python style.
pasik subscribed.Aug 31 2020, 11:40 AM
c-po added a project: VyOS 1.4 Sagitta.Feb 14 2021, 11:12 AM
c-po subscribed.

Issue no longer persists in VyOS 1.4. Tested using: 1.4-rolling-20210214

c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.Feb 14 2021, 11:13 AM
Viacheslav added a comment.Apr 29 2021, 10:06 AM

A possible reason it tried to remove " neighbor 10.0.0.2 remote-as 65002" after " neighbor 10.0.0.2 interface peer-group foo"
But if we delete " neighbor 10.0.0.2 interface peer-group foo" it also delete and "" neighbor 10.0.0.2 remote-as 65002"
So it can't delete this string

!
router bgp 65001
 neighbor foo peer-group
 neighbor 10.0.0.2 interface peer-group foo
 neighbor 10.0.0.2 remote-as 65002
!

Delete manual

r4-1.3# conf t
r4-1.3(config)# router bgp 
r4-1.3(config-router)# no  neighbor 10.0.0.2 interface peer-group foo
r4-1.3(config-router)# 
r4-1.3(config-router)# do show run
!
router bgp 65001
 neighbor foo peer-group
!
line vty
!
end
r4-1.3(config-router)#

Trying to delete the second line (which already deleted)

[email protected]# vtysh -c "configure terminal" -c "router bgp 65001" -c "no neighbor 10.0.0.2 interface remote-as internal"
% Create the bgp interface first
[edit]
[email protected]#
erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 1:15 PM
erkin removed a subscriber: Global Notifications.
olofl subscribed.Aug 30 2021, 8:21 PM
Viacheslav mentioned this in T3887: Removal of IPv6 BGP-peer with peer-group may trigger problems.Oct 4 2021, 1:39 PM
syncer merged a task: T3887: Removal of IPv6 BGP-peer with peer-group may trigger problems.Oct 17 2021, 1:23 PM
syncer added subscribers: rcit, Unknown Object (User).
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Nov 6 2021, 11:24 AM
TMA subscribed.Aug 8 2022, 7:45 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.0).Aug 29 2022, 7:05 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:40 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM
a.hajiyev subscribed.EditedNov 22 2023, 4:47 AM

Tested in VyOS 1.4-rolling-202311100309
The configuration:
VyOS:

set protocols bgp address-family ipv4-unicast network 10.0.11.0/24
set protocols bgp neighbor 10.55.8.242 address-family ipv4-unicast soft-reconfiguration inbound
set protocols bgp neighbor 10.55.8.242 peer-group 'foo'
set protocols bgp neighbor 10.55.8.242 remote-as '65002'
set protocols bgp parameters router-id '10.55.8.241'
set protocols bgp peer-group foo
set protocols bgp system-as '65001'

FRR

router bgp 65001
 bgp router-id 10.55.8.241
 no bgp ebgp-requires-policy
 no bgp default ipv4-unicast
 no bgp network import-check
 neighbor foo peer-group
 neighbor 10.55.8.242 remote-as 65002
 neighbor 10.55.8.242 peer-group foo 
!
 address-family ipv4 unicast
  network 10.0.11.0/24
  neighbor 10.55.8.242 activate
  neighbor 10.55.8.242 soft-reconfiguration inbound
 exit-address-family

Deleting the peer-group from the neighbor:

vyos@vyos# delete protocols bgp neighbor 10.55.8.242 peer-group
[edit]
vyos@vyos# commit
[edit]

FRR:

router bgp 65001
 bgp router-id 10.55.8.241
 no bgp ebgp-requires-policy
 no bgp default ipv4-unicast
 no bgp network import-check
 neighbor foo peer-group
 neighbor 10.55.8.242 remote-as 65002
 !
 address-family ipv4 unicast
  network 10.0.11.0/24
  neighbor 10.55.8.242 activate
  neighbor 10.55.8.242 soft-reconfiguration inbound
 exit-address-family

Works as expected

a.hajiyev removed a project: VyOS 1.4 Sagitta.Nov 22 2023, 6:15 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:37 PM
dmbaturin closed this task as Resolved.Jan 9 2024, 8:17 PM
dmbaturin claimed this task.
dmbaturin edited projects, added VyOS 1.3 Equuleus; removed VyOS 1.3 Equuleus (1.3.6).
dmbaturin edited projects, added VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus.Jan 10 2024, 9:32 PM