Page MenuHomeVyOS Platform
People jestabro

jestabro (John Estabrook)
User

Projects (11)
View All

User Details

User Since
Apr 12 2019, 4:27 PM (347 w, 13 h)

Recent Activity
View All

Yesterday

jestabro created T8074: Redistribute options from vyconf_cli to vyconf_cli_compat.
Fri, Dec 5, 6:51 PM · VyOS Rolling

Thu, Dec 4

jestabro closed T7319: Add warning message for unsaved changes in the dialog before initiating an upgrade as Resolved.
Thu, Dec 4, 3:10 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro closed T8032: Add analogue of cli-shell-api sessionUnsaved as Resolved.
Thu, Dec 4, 3:09 PM · VyOS Rolling
jestabro reopened T8032: Add analogue of cli-shell-api sessionUnsaved as "Open".
Thu, Dec 4, 2:32 PM · VyOS Rolling
jestabro closed T8031: Use a smarter file comparison in boolean test unsaved_commits() as Resolved.
Thu, Dec 4, 2:31 PM · VyOS Rolling
jestabro closed T8032: Add analogue of cli-shell-api sessionUnsaved as Resolved.
Thu, Dec 4, 2:30 PM · VyOS Rolling

Wed, Dec 3

jestabro committed rVYOSONEX9c850218b663: T8032: add protobuf files for analogue of sessionUnsaved.
Wed, Dec 3, 12:07 AM
jestabro committed rVYOSONEXe71c5909cb98: T8032: update commit hashes for analogue of sessionUnsaved.
Wed, Dec 3, 12:07 AM

Tue, Dec 2

jestabro created T8062: Set default value for commit-revisions, making the commit archive mandatory.
Tue, Dec 2, 7:01 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro updated the task description for T8032: Add analogue of cli-shell-api sessionUnsaved.
Tue, Dec 2, 2:43 PM · VyOS Rolling
jestabro created T8061: Add analogue of cli-shell-api getCompletionEnv.
Tue, Dec 2, 2:43 PM · VyOS Rolling

Thu, Nov 27

jestabro committed rVYOSONEXaca852eb53dd: T8009: update commit hashes for vyconf edit-level aware session.
Thu, Nov 27, 1:06 AM

Wed, Nov 26

jestabro committed rVYOSONEX6943bdc5fc27: T8009: add vyconf_cli_compat for retained options of cli-shell-api.
Wed, Nov 26, 7:52 PM
jestabro committed rVYOSONEXfd0104e0a48d: T8009: add generated protobuf files for edit_level.
Wed, Nov 26, 7:52 PM
jestabro committed rVYOSONEX7ed7e7acf4f7: T7319: check unsaved_commits before upgrade.
Wed, Nov 26, 7:34 PM
jestabro committed rVYOSONEX671210b3c0b8: T8041: update comments referring to deprecated priority.pl.
Wed, Nov 26, 7:24 PM

Mon, Nov 24

jestabro committed rVYOSONEX0bc7898a9651: T8031: use util file_compare for check unsaved_commits.
Mon, Nov 24, 2:23 PM
jestabro committed rVYOSONEXb80bba65567c: T8031: add file comparison utility for comparison modulo empty lines.
Mon, Nov 24, 2:23 PM
jestabro created T8032: Add analogue of cli-shell-api sessionUnsaved.
Mon, Nov 24, 1:19 AM · VyOS Rolling
jestabro closed T7992: Remove references to OPAM in skel/.bashrc as Resolved.
Mon, Nov 24, 1:14 AM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro closed T7988: Extend vyconf show command for parity with legacy show command as Resolved.
Mon, Nov 24, 1:10 AM · VyOS Rolling

Fri, Nov 21

jestabro updated the task description for T8031: Use a smarter file comparison in boolean test unsaved_commits().
Fri, Nov 21, 7:31 PM · VyOS Rolling
jestabro created T8031: Use a smarter file comparison in boolean test unsaved_commits().
Fri, Nov 21, 6:37 PM · VyOS Rolling

Thu, Nov 20

jestabro committed rVYOSONEXf26f737f0c58: T7988: adjust function name to distinguish compare from show config.
Thu, Nov 20, 2:51 PM
jestabro committed rVYOSONEXe74b9a1b4d9d: T7988: update commit hashes for show config.
Thu, Nov 20, 2:51 PM
jestabro triaged T8026: HTTPS API for /generate not working properly for wireguard interface as Normal priority.

A related issue is here: https://vyos.dev/T8000.

Thu, Nov 20, 1:20 AM

Wed, Nov 19

jestabro added a subtask for T7836: The /config bind mount does not respect inode updates: T7994: Image installer doesn't detect previous installation.
Wed, Nov 19, 4:50 PM · VyOS 1.5 Circinus (2025.11)
jestabro added a parent task for T7994: Image installer doesn't detect previous installation: T7836: The /config bind mount does not respect inode updates.
Wed, Nov 19, 4:50 PM · VyOS Rolling
jestabro closed T7994: Image installer doesn't detect previous installation as Resolved.
Wed, Nov 19, 4:43 PM · VyOS Rolling

Tue, Nov 18

jestabro committed rVYOSONEX6e7c62022a2a: T7992: remove unneeded references to OPAM in skel/.bashrc.
Tue, Nov 18, 3:51 PM

Mon, Nov 17

jestabro committed rVYOSONEXcf8f89262583: T7994: fix regression in check for previous installations on install.
Mon, Nov 17, 3:25 PM

Fri, Nov 14

jestabro added a comment to T7994: Image installer doesn't detect previous installation.

PR:
https://github.com/vyos/vyos-1x/pull/4849

Fri, Nov 14, 3:50 PM · VyOS Rolling
jestabro claimed T7994: Image installer doesn't detect previous installation.
Fri, Nov 14, 3:28 PM · VyOS Rolling

Thu, Nov 13

jestabro created T8009: Extend vyconf session to be edit-level aware.
Thu, Nov 13, 1:55 AM · VyOS Rolling

Wed, Nov 12

jestabro closed T7711: config-sync: TypeError: 'coroutine' object is not iterable as Resolved.
Wed, Nov 12, 6:31 PM · VyOS 1.5 Circinus (2025.11)
jestabro edited projects for T7321: Replace legacy operations in configsession.py with vyconf client operations, added: VyOS Rolling; removed VyOS 1.5 Circinus (2025.11).
Wed, Nov 12, 5:54 PM · VyOS Rolling

Tue, Nov 11

jestabro lowered the priority of T7307: Data added via vyos.utils.configfs.add_cli_node() not available when script is called via call_depends() from High to Wishlist.

Based on the comments above, I am moving this to 'wishlist' for consideration after the legacy backend is retired. My expectation is that we will not want to drop the invariant as such, however, we will be in a position to consider refinements of the model, radical or conservative, once freed from the legacy constraints.

Tue, Nov 11, 5:05 PM · VyOS Rolling, VyOS 1.5 Circinus

Thu, Nov 6

jestabro closed T7946: Log redirected stdout from FRRender under vyos-configd, a subtask of T7855: Redirect stdout and catch exceptions from FRRender under vyos-configd, as Resolved.
Thu, Nov 6, 3:58 PM · VyOS 1.5 Circinus (2025.11)
jestabro closed T7946: Log redirected stdout from FRRender under vyos-configd as Resolved.
Thu, Nov 6, 3:58 PM · VyOS 1.5 Circinus (2025.11)
jestabro moved T7946: Log redirected stdout from FRRender under vyos-configd from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.
Thu, Nov 6, 3:57 PM · VyOS 1.5 Circinus (2025.11)
jestabro edited projects for T7946: Log redirected stdout from FRRender under vyos-configd, added: VyOS 1.5 Circinus (1.5-stream-2025-Q3); removed VyOS 1.5 Circinus (1.5-stream-2025-Q4).
Thu, Nov 6, 3:57 PM · VyOS 1.5 Circinus (2025.11)
jestabro closed T7910: Standardize vyconf session resource management across Python config modules, a subtask of T7374: Integrate vyconf config session with CLI config session, as Resolved.
Thu, Nov 6, 3:57 PM · VyOS Rolling
jestabro closed T7910: Standardize vyconf session resource management across Python config modules as Resolved.
Thu, Nov 6, 3:57 PM · VyOS Rolling
jestabro closed T7915: Add compile time alerts for static exception analysis of vyos1x-config/vyconf as Resolved.
Thu, Nov 6, 3:56 PM · VyOS Rolling
jestabro closed T7969: Add value_exists to configtree as Resolved.
Thu, Nov 6, 3:56 PM · VyOS Rolling
jestabro closed T7980: Load active config on vyconfd restart as Resolved.
Thu, Nov 6, 3:55 PM · VyOS Rolling
jestabro committed rVYOSONEX128885203149: T7915: update commit hashes for exn-alert.
Thu, Nov 6, 3:31 PM
jestabro committed rVYOSONEX42015261ce2e: T7915: minor fixes for consistent exception handling and error messages.
Thu, Nov 6, 3:31 PM
jestabro committed rVYOSONEX47cc7ab10b9b: T7969: expose boolean test value_exists.
Thu, Nov 6, 3:31 PM

Nov 5 2025

jestabro committed rVYOSONEXcad2c08ee6f2: T7910: update auto-generated protobuf files for show_sessions.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEX47b36a3af0bd: T7910: switch keyword order pid/token for consistency and intuition.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEXa02b7d54c561: T7910: add call show_sessions.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEX4c391ed39c51: T7910: add keyword extant, for use by teardown script.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEXc414a7d55579: T7910: use weakref.finalize for reliable session teardown.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEXcbbfd427896d: T7910: op-mode init should always start a new session.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEX2a574f7e146a: T7910: call enter_config_mode only on new session.
Nov 5 2025, 6:21 PM

Nov 4 2025

jestabro renamed T7991: Fix regex in constraints interface-name.xml.i, interface-name-with-wildcard.xml.i from Fix regex in constriants interface-name.xml.i, interface-name-with-wildcard.xml.i to Fix regex in constraints interface-name.xml.i, interface-name-with-wildcard.xml.i.
Nov 4 2025, 7:47 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro created T7992: Remove references to OPAM in skel/.bashrc.
Nov 4 2025, 7:44 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro created T7991: Fix regex in constraints interface-name.xml.i, interface-name-with-wildcard.xml.i.
Nov 4 2025, 7:33 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling

Nov 3 2025

jestabro committed rVYOSONEXbad8393c730b: T7980: T7910: update libvyosconfig/Makefile for vyconfd restart/show_sessions.
Nov 3 2025, 4:21 PM
jestabro created T7988: Extend vyconf show command for parity with legacy show command.
Nov 3 2025, 3:33 PM · VyOS Rolling
jestabro committed rVYOSONEX75716e99f0bf: T7980: defer startup of vyconfd for consistent bookkeeping.
Nov 3 2025, 1:46 PM
jestabro committed rVYOSONEX018b6fd1275e: T7980: distinguish vyconfd initialization from restart.
Nov 3 2025, 1:46 PM

Nov 2 2025

jestabro added a comment to T7980: Load active config on vyconfd restart.

PRs:
https://github.com/vyos/vyconf/pull/34
https://github.com/vyos/vyos1x-config/pull/55
https://github.com/vyos/vyos-1x/pull/4827

Nov 2 2025, 5:21 AM · VyOS Rolling

Nov 1 2025

jestabro created T7980: Load active config on vyconfd restart.
Nov 1 2025, 1:38 AM · VyOS Rolling

Oct 29 2025

jestabro added a comment to T7969: Add value_exists to configtree.

Included in PRs:
https://github.com/vyos/vyos1x-config/pull/54
https://github.com/vyos/vyos-1x/pull/4814

Oct 29 2025, 3:58 PM · VyOS Rolling
jestabro created T7969: Add value_exists to configtree.
Oct 29 2025, 1:20 PM · VyOS Rolling

Oct 28 2025

jestabro added a comment to T7915: Add compile time alerts for static exception analysis of vyos1x-config/vyconf.

PRs:
https://github.com/vyos/vyos1x-config/pull/54
https://github.com/vyos/vyconf/pull/33
https://github.com/vyos/vyos-1x/pull/4814

Oct 28 2025, 11:42 PM · VyOS Rolling
jestabro committed rVYOSONEXd2a1bde262ed: dhcp-server: T3936: fix indent typo.
Oct 28 2025, 5:57 PM

Oct 26 2025

jestabro added a comment to T7307: Data added via vyos.utils.configfs.add_cli_node() not available when script is called via call_depends().

The assumption stated in the description is true, as discussed with @c-po at the time. The following invariant is fundamental to the operation of the commit algorithm (legacy and modern) and the config daemons: during a commit, the active and proposed configs are fixed --- no updates during the commit are reflected in any script's config dict, including those called by config dependencies. Evolution of this model will require a refinement of config dependencies, which is not possible until the legacy backend is retired.

Oct 26 2025, 5:52 PM · VyOS Rolling, VyOS 1.5 Circinus

Oct 23 2025

jestabro added a comment to T7910: Standardize vyconf session resource management across Python config modules.

PRs:
https://github.com/vyos/vyconf/pull/32
https://github.com/vyos/vyos-1x/pull/4807

Oct 23 2025, 1:41 AM · VyOS Rolling

Oct 21 2025

jestabro committed rVYOSONEX40c95fe290b0: T7946: log redirected stdout from FRRender.
Oct 21 2025, 2:27 PM

Oct 20 2025

jestabro added a comment to T7946: Log redirected stdout from FRRender under vyos-configd.

PR:
https://github.com/vyos/vyos-1x/pull/4802

Oct 20 2025, 3:39 PM · VyOS 1.5 Circinus (2025.11)
jestabro updated the task description for T7946: Log redirected stdout from FRRender under vyos-configd.
Oct 20 2025, 3:18 PM · VyOS 1.5 Circinus (2025.11)
jestabro added a parent task for T7946: Log redirected stdout from FRRender under vyos-configd: T7855: Redirect stdout and catch exceptions from FRRender under vyos-configd.
Oct 20 2025, 3:14 PM · VyOS 1.5 Circinus (2025.11)
jestabro added a subtask for T7855: Redirect stdout and catch exceptions from FRRender under vyos-configd: T7946: Log redirected stdout from FRRender under vyos-configd.
Oct 20 2025, 3:14 PM · VyOS 1.5 Circinus (2025.11)
jestabro created T7946: Log redirected stdout from FRRender under vyos-configd.
Oct 20 2025, 3:14 PM · VyOS 1.5 Circinus (2025.11)

Oct 8 2025

jestabro added a comment to T7250: Auto completion for op command show file is broken.

Some background: the scripts in question relate to the vyatta-image-tools.pl (not the image installer) and related scripts, cf. https://vyos.dev/T4038, for changes present in current but not 1.4.
On the other hand, the package vyatta-op was deprecated for versions > 1.4 in https://vyos.dev/T6527, and the file vyatta-image-complete was not included in vyos-1x: it would appear that the work above was to have provided a replacement, but that needs to be checked.
This will need a bit of analysis before a PR, but either we include the legacy script, or correct the errors in the possible replacement.

Oct 8 2025, 8:38 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro created T7915: Add compile time alerts for static exception analysis of vyos1x-config/vyconf.
Oct 8 2025, 1:57 PM · VyOS Rolling

Oct 7 2025

jestabro added a parent task for T7910: Standardize vyconf session resource management across Python config modules: T7374: Integrate vyconf config session with CLI config session.
Oct 7 2025, 12:28 AM · VyOS Rolling
jestabro added a subtask for T7374: Integrate vyconf config session with CLI config session: T7910: Standardize vyconf session resource management across Python config modules.
Oct 7 2025, 12:28 AM · VyOS Rolling
jestabro created T7910: Standardize vyconf session resource management across Python config modules.
Oct 7 2025, 12:11 AM · VyOS Rolling
jestabro moved T7709: Add file sync and atomic write to config save script from Need Triage to Completed on the VyOS Rolling board.
Oct 7 2025, 12:04 AM · VyOS 1.5 Circinus (2025.11)
jestabro moved T7709: Add file sync and atomic write to config save script from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.
Oct 7 2025, 12:04 AM · VyOS 1.5 Circinus (2025.11)
jestabro moved T7903: Set airbag enable to default log=False from Need Triage to Completed on the VyOS Rolling board.
Oct 7 2025, 12:03 AM · VyOS 1.5 Circinus (2025.11)
jestabro moved T7903: Set airbag enable to default log=False from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.
Oct 7 2025, 12:03 AM · VyOS 1.5 Circinus (2025.11)
jestabro moved T7907: config-mgmt: add baseline archived config file on first boot to avoid misleading error messages from Need Triage to Completed on the VyOS Rolling board.
Oct 7 2025, 12:03 AM · VyOS 1.5 Circinus (2025.11)
jestabro moved T7907: config-mgmt: add baseline archived config file on first boot to avoid misleading error messages from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.
Oct 7 2025, 12:02 AM · VyOS 1.5 Circinus (2025.11)

Oct 6 2025

jestabro reopened T7818: 'add system image' error if we choose not to copy an active config as "Open".

This was automatically closed; re-open until confirmed by testing.

Oct 6 2025, 7:59 PM · VyOS 1.5 Circinus (2025.11)
jestabro committed rVYOSONEXad5452c19e73: T7907: archive config file on first boot to avoid misleading log entry.
Oct 6 2025, 7:30 PM
jestabro closed T7818: 'add system image' error if we choose not to copy an active config as Resolved by committing rVYOSONEX3b5034b87303: T7818: remove unneeded calls of get_cli_kernel_options causing regression.
Oct 6 2025, 7:24 PM · VyOS 1.5 Circinus (2025.11)
jestabro committed rVYOSONEX3b5034b87303: T7818: remove unneeded calls of get_cli_kernel_options causing regression.
Oct 6 2025, 7:24 PM
jestabro added a reverting change for rVYOSONEXd871fe9c4c65: bgp: T7760: deprecate per bgp vrf instance system-as node: rVYOSONEXbc73a4f74524: Revert "bgp: T7760: deprecate per bgp vrf instance system-as node".
Oct 6 2025, 6:54 PM
jestabro committed rVYOSONEXbc73a4f74524: Revert "bgp: T7760: deprecate per bgp vrf instance system-as node".
Oct 6 2025, 6:54 PM
jestabro added a reverting change for rVYOSONEX3f8404ac78e1: migrator: T7760: remove debug print statement: rVYOSONEX58f0829ad41f: Revert "migrator: T7760: remove debug print statement".
Oct 6 2025, 6:54 PM
jestabro added a reverting change for rVYOSONEX85fe32f0e1a9: bgp: T7760: remove per vrf instance system-as node: rVYOSONEXd238a582e47e: Revert "bgp: T7760: remove per vrf instance system-as node".
Oct 6 2025, 6:54 PM
jestabro added a reverting change for rVYOSONEX7da3fcc9b730: bgp: T7760: improfe verify() logic on default VRF removal: rVYOSONEXb0102e534499: Revert "bgp: T7760: improfe verify() logic on default VRF removal".
Oct 6 2025, 6:54 PM
jestabro committed rVYOSONEX58f0829ad41f: Revert "migrator: T7760: remove debug print statement".
Oct 6 2025, 6:54 PM
jestabro committed rVYOSONEXd238a582e47e: Revert "bgp: T7760: remove per vrf instance system-as node".
Oct 6 2025, 6:54 PM
jestabro committed rVYOSONEXb0102e534499: Revert "bgp: T7760: improfe verify() logic on default VRF removal".
Oct 6 2025, 6:54 PM