Page MenuHomeVyOS Platform
People jestabro

jestabro (John Estabrook)
User

Projects (10)
View All

User Details

User Since
Apr 12 2019, 4:27 PM (312 w, 4 d)

Recent Activity
View All

Yesterday

jestabro added a parent task for T5528: Replace legacy loadFile with config_diff: T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error.
Tue, Apr 8, 6:52 PM · VyOS Rolling
jestabro added a subtask for T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error: T5528: Replace legacy loadFile with config_diff.
Tue, Apr 8, 6:52 PM · VyOS Rolling, Bugs
jestabro closed T5528: Replace legacy loadFile with config_diff, a subtask of T5317: configtree: remove mutable references, as Resolved.
Tue, Apr 8, 6:51 PM · VyOS 1.4 Sagitta
jestabro closed T5528: Replace legacy loadFile with config_diff, a subtask of T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py, as Resolved.
Tue, Apr 8, 6:51 PM · VyOS 1.4 Sagitta
jestabro closed T5528: Replace legacy loadFile with config_diff as Resolved.

Subsumed by the work beginning in T6717 and continuing in listed subtasks thereof.

Tue, Apr 8, 6:51 PM · VyOS Rolling
jestabro added a comment to T6717: Add hybrid Cstore manipulation library to replace set/delete/load_config functionality.

The use of a hybrid implementation was retired in favor of full vyconfd support (in development); cf. T6718 and subtasks.

Tue, Apr 8, 6:50 PM · VyOS Rolling
jestabro added a parent task for T6718: Use vyconf daemon for validation of set commands: T6717: Add hybrid Cstore manipulation library to replace set/delete/load_config functionality.
Tue, Apr 8, 6:48 PM · VyOS Rolling
jestabro added a subtask for T6717: Add hybrid Cstore manipulation library to replace set/delete/load_config functionality: T6718: Use vyconf daemon for validation of set commands.
Tue, Apr 8, 6:48 PM · VyOS Rolling
jestabro added a subtask for T5528: Replace legacy loadFile with config_diff: T6717: Add hybrid Cstore manipulation library to replace set/delete/load_config functionality.
Tue, Apr 8, 6:47 PM · VyOS Rolling
jestabro added a parent task for T6717: Add hybrid Cstore manipulation library to replace set/delete/load_config functionality: T5528: Replace legacy loadFile with config_diff.
Tue, Apr 8, 6:47 PM · VyOS Rolling
jestabro closed T7272: Vyconf: update in memory config tree on response from vyos-commitd, a subtask of T7121: Set up communication vyconfd <-> vyos-configd, as Resolved.
Tue, Apr 8, 6:40 PM · VyOS Rolling
jestabro closed T7272: Vyconf: update in memory config tree on response from vyos-commitd as Resolved.
Tue, Apr 8, 6:40 PM · VyOS Rolling
jestabro moved T7289: Add libvyosconfig as git submodule of vyos-1x for stream builds from Open to Finished on the VyOS 1.5 Circinus board.
Tue, Apr 8, 6:39 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T7289: Add libvyosconfig as git submodule of vyos-1x for stream builds as Resolved.
Tue, Apr 8, 6:39 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T7289: Add libvyosconfig as git submodule of vyos-1x for stream builds, a subtask of T5400: Move libvyosconfig build out of the Docker image, as Resolved.
Tue, Apr 8, 6:39 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T6929: Update Dockerfile for change in Opam install.sh as Resolved.
Tue, Apr 8, 6:38 PM · VyOS 1.4 Sagitta, VyOS 1.5 Circinus, VyOS Rolling
jestabro committed rVYOSONEX67a85ae7c532: T7292: update submodule for post commit update and set tag/leaf data.
Tue, Apr 8, 2:12 PM
jestabro committed rVYOSONEX09cb7801d790: T7272: drop test functions.
Tue, Apr 8, 2:12 PM
jestabro committed rVYOSONEXf6460364fada: T7292: add vyconfd client library functions.
Tue, Apr 8, 2:12 PM
jestabro committed rVYOSONEX51dadbaffc51: T7292: generate vyconfd client library dataclasses.
Tue, Apr 8, 2:12 PM
jestabro committed rVYOSONEXe165ca6a9d25: T7272: drop unneeded fields.
Tue, Apr 8, 2:12 PM

Sat, Apr 5

jestabro added a comment to T7323: Ability to load/merge from set commands.

@L0crian cf. https://vyos.dev/T6740, which provides a converter: set commands -> config

Sat, Apr 5, 4:56 PM · VyOS Rolling

Fri, Apr 4

jestabro added a comment to T7302: Implement commit dry-run for vyconfd/vyos-commitd.

PRs:
https://github.com/vyos/vyconf/pull/19
https://github.com/vyos/vyos-1x/pull/4435

Fri, Apr 4, 6:04 PM · VyOS Rolling
jestabro added a parent task for T7321: Replace legacy operations in configsession.py with vyconf client operations: T7292: Expose vyconf commit algorithm for CLI and ConfigSession instance.
Fri, Apr 4, 5:19 PM · VyOS Rolling
jestabro added a subtask for T7292: Expose vyconf commit algorithm for CLI and ConfigSession instance: T7321: Replace legacy operations in configsession.py with vyconf client operations.
Fri, Apr 4, 5:19 PM · VyOS Rolling
jestabro renamed T7321: Replace legacy operations in configsession.py with vyconf client operations from Replace legacy operations in configsession with vyconf client operations to Replace legacy operations in configsession.py with vyconf client operations.
Fri, Apr 4, 5:18 PM · VyOS Rolling
jestabro created T7321: Replace legacy operations in configsession.py with vyconf client operations.
Fri, Apr 4, 5:18 PM · VyOS Rolling
jestabro added a subtask for T7292: Expose vyconf commit algorithm for CLI and ConfigSession instance: T7302: Implement commit dry-run for vyconfd/vyos-commitd.
Fri, Apr 4, 5:07 PM · VyOS Rolling
jestabro added a parent task for T7302: Implement commit dry-run for vyconfd/vyos-commitd: T7292: Expose vyconf commit algorithm for CLI and ConfigSession instance.
Fri, Apr 4, 5:07 PM · VyOS Rolling

Thu, Apr 3

jestabro committed rVYOSONEXa0416e878600: T7289: fix relative path for git submodule url.
Thu, Apr 3, 5:31 AM
jestabro added a comment to T7292: Expose vyconf commit algorithm for CLI and ConfigSession instance.

Needed fix here:
https://github.com/vyos/vyos1x-config/pull/40
https://github.com/vyos/vyconf/pull/18

Thu, Apr 3, 4:16 AM · VyOS Rolling

Wed, Apr 2

jestabro added a comment to T7272: Vyconf: update in memory config tree on response from vyos-commitd.

PR
https://github.com/vyos/vyconf/pull/17
merged

Wed, Apr 2, 2:31 PM · VyOS Rolling

Mon, Mar 31

jestabro renamed T7302: Implement commit dry-run for vyconfd/vyos-commitd from Implemen commit dry-run for vyconfd to Implement commit dry-run for vyconfd/vyos-commitd.
Mon, Mar 31, 7:34 PM · VyOS Rolling
jestabro created T7302: Implement commit dry-run for vyconfd/vyos-commitd.
Mon, Mar 31, 7:34 PM · VyOS Rolling
jestabro added a comment to T7289: Add libvyosconfig as git submodule of vyos-1x for stream builds.

Regarding the failure of the PR integration tests, this may have been a result of a typo, now corrected in rolling here:
https://github.com/vyos/vyos-1x/pull/4425

Mon, Mar 31, 5:22 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro committed rVYOSONEXb55504a69473: T7289: fix typo in git submodule status check.
Mon, Mar 31, 3:58 PM
jestabro closed T7296: Require opam package ppx_deriving_yojson <= 3.9.1 as Resolved.
Mon, Mar 31, 3:31 PM · VyOS Rolling
jestabro committed rVYOSONEXfce85848e36d: T7296: update hash for restrict opam ppx_deriving_yojson <= v3.9.1.
Mon, Mar 31, 3:25 PM
jestabro moved T7294: image upgrade will replace symlinks with a copy from Open to Finished on the VyOS 1.4 Sagitta board.
Mon, Mar 31, 3:20 PM · VyOS 1.4 Sagitta (1.4.2), VyOS Rolling, VyOS 1.5 Circinus
jestabro moved T7294: image upgrade will replace symlinks with a copy from Open to Finished on the VyOS 1.5 Circinus board.
Mon, Mar 31, 3:19 PM · VyOS 1.4 Sagitta (1.4.2), VyOS Rolling, VyOS 1.5 Circinus
jestabro closed T7294: image upgrade will replace symlinks with a copy as Resolved.
Mon, Mar 31, 3:19 PM · VyOS 1.4 Sagitta (1.4.2), VyOS Rolling, VyOS 1.5 Circinus

Sat, Mar 29

jestabro committed rVYOSONEX856ab1106795: T7289: attempt to update submodule if status inconsistent.
Sat, Mar 29, 9:15 PM
jestabro committed rVYOSONEXe4d0f284ff3f: T7289: set url as relative path.
Sat, Mar 29, 9:15 PM
jestabro committed rVYOSONEXe5cc2004b4d2: T7289: update Makefile for libvyosconfig as git submodule.
Sat, Mar 29, 9:15 PM
jestabro committed rVYOSONEX3f0b370a3993: T7289: add libvyosconfig as git submodule.
Sat, Mar 29, 9:15 PM
jestabro committed rVYOSONEXe21b9658f057: T7294: preserve /config symlinks on image upgrade.
Sat, Mar 29, 9:42 AM
jestabro created T7296: Require opam package ppx_deriving_yojson <= 3.9.1.
Sat, Mar 29, 5:03 AM · VyOS Rolling
jestabro added a comment to T7294: image upgrade will replace symlinks with a copy.

PR:
https://github.com/vyos/vyos-1x/pull/4423

Sat, Mar 29, 3:19 AM · VyOS 1.4 Sagitta (1.4.2), VyOS Rolling, VyOS 1.5 Circinus

Fri, Mar 28

jestabro claimed T7294: image upgrade will replace symlinks with a copy.
Fri, Mar 28, 7:43 PM · VyOS 1.4 Sagitta (1.4.2), VyOS Rolling, VyOS 1.5 Circinus
jestabro added a subtask for T7272: Vyconf: update in memory config tree on response from vyos-commitd: T7292: Expose vyconf commit algorithm for CLI and ConfigSession instance.
Fri, Mar 28, 4:23 PM · VyOS Rolling
jestabro added a parent task for T7292: Expose vyconf commit algorithm for CLI and ConfigSession instance: T7272: Vyconf: update in memory config tree on response from vyos-commitd.
Fri, Mar 28, 4:23 PM · VyOS Rolling
jestabro created T7292: Expose vyconf commit algorithm for CLI and ConfigSession instance.
Fri, Mar 28, 4:22 PM · VyOS Rolling
jestabro closed T6946: Add initial commit algorithm to vyconf, a subtask of T6718: Use vyconf daemon for validation of set commands, as Resolved.
Fri, Mar 28, 4:17 PM · VyOS Rolling
jestabro closed T6946: Add initial commit algorithm to vyconf as Resolved.
Fri, Mar 28, 4:17 PM · VyOS Rolling
jestabro added a parent task for T7272: Vyconf: update in memory config tree on response from vyos-commitd: T7121: Set up communication vyconfd <-> vyos-configd.
Fri, Mar 28, 4:16 PM · VyOS Rolling
jestabro added a subtask for T7121: Set up communication vyconfd <-> vyos-configd: T7272: Vyconf: update in memory config tree on response from vyos-commitd.
Fri, Mar 28, 4:16 PM · VyOS Rolling
jestabro added a parent task for T7121: Set up communication vyconfd <-> vyos-configd: T6946: Add initial commit algorithm to vyconf.
Fri, Mar 28, 4:14 PM · VyOS Rolling
jestabro added a subtask for T6946: Add initial commit algorithm to vyconf: T7121: Set up communication vyconfd <-> vyos-configd.
Fri, Mar 28, 4:14 PM · VyOS Rolling

Wed, Mar 26

jestabro added a parent task for T7289: Add libvyosconfig as git submodule of vyos-1x for stream builds: T5400: Move libvyosconfig build out of the Docker image.
Wed, Mar 26, 10:00 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro added a subtask for T5400: Move libvyosconfig build out of the Docker image: T7289: Add libvyosconfig as git submodule of vyos-1x for stream builds.
Wed, Mar 26, 10:00 PM · VyOS 1.5 Circinus, VyOS Rolling
jestabro created T7289: Add libvyosconfig as git submodule of vyos-1x for stream builds.
Wed, Mar 26, 10:00 PM · VyOS 1.5 Circinus, VyOS Rolling

Tue, Mar 25

jestabro committed rVYOSONEX42bc671b1875: T7246: update hash for strip version on config load.
Tue, Mar 25, 7:38 PM

Fri, Mar 21

jestabro created T7272: Vyconf: update in memory config tree on response from vyos-commitd.
Fri, Mar 21, 8:48 PM · VyOS Rolling

Thu, Mar 20

jestabro committed rVYOSONEXfbf871b3cdbb: T7246: update libvyosconfig hash and add nosetest.
Thu, Mar 20, 4:59 PM
jestabro committed rVYOSONEX6dd7dbc2500d: T7246: do not pass unneeded version string to parser.
Thu, Mar 20, 2:20 PM

Tue, Mar 18

jestabro closed T7121: Set up communication vyconfd <-> vyos-configd as Resolved.
Tue, Mar 18, 11:14 PM · VyOS Rolling
jestabro added a comment to T7246: Wireguard: Traceback error received if the public-key starts with //.

PR's:
https://github.com/vyos/vyos-1x/pull/4406

Tue, Mar 18, 5:35 PM · VyOS 1.5 Circinus, VyOS Rolling, VyOS 1.4 Sagitta (1.4.3)
jestabro committed rVYOSONEXd8a6295a13a6: T7121: T6946: update hash for commit algorithm/commitd messaging.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEXb3427a6aa693: T7121: add defaults entry for vyconfd.conf.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEXb6df26f89df7: T7121: add test_commit wrapper and test script.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEX3078c7c97662: T7121: generate Python protobuf files at build.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEX21d960b34da2: T7121: add vyos-commitd service as emergent replacement for vyos-configd.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEX33394e41516a: T7121: add Config init from internal cache.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEX467811b32ba4: T7121: add protobuf and tomli dependencies.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEX4dc02b404311: T7121: use dunder equal instead of string rep comparison, where possible.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEXdefc2b665940: T7121: add configtree read/write to internal representation.
Tue, Mar 18, 3:48 PM
jestabro committed rVYOSONEXdbe09d4c3dac: T6946: add wrapper for show_commit_data and test function.
Tue, Mar 18, 3:48 PM
jestabro changed the status of T7246: Wireguard: Traceback error received if the public-key starts with // from Open to In progress.

The lexer is unnecessarily aggressive in disallowing strings following '//', originally added to ignore version string information. This has the side effect of ignoring legitimate values. Since the version string is now extracted before parsing, this restriction can be dropped. Fix in preparation.

Tue, Mar 18, 2:00 PM · VyOS 1.5 Circinus, VyOS Rolling, VyOS 1.4 Sagitta (1.4.3)
jestabro claimed T7246: Wireguard: Traceback error received if the public-key starts with //.
Tue, Mar 18, 12:57 PM · VyOS 1.5 Circinus, VyOS Rolling, VyOS 1.4 Sagitta (1.4.3)

Mon, Mar 17

jestabro added a project to T5976: Allow commit-confirm to use soft-rollback instead of reboot: VyOS 1.4 Sagitta (1.4.3).
Mon, Mar 17, 1:33 PM · VyOS 1.4 Sagitta (1.4.3), VyOS Rolling, VyOS 1.5 Circinus
jestabro moved T6925: Can not remove config-management from config - raises AttributeError from Open to Finished on the VyOS 1.5 Circinus board.
Mon, Mar 17, 1:33 PM · VyOS 1.4 Sagitta (1.4.3), VyOS Rolling, VyOS 1.5 Circinus
jestabro added a comment to T7121: Set up communication vyconfd <-> vyos-configd.

PR's:
https://github.com/vyos/vyos-build/pull/931
https://github.com/vyos/vyconf/pull/15
https://github.com/vyos/libvyosconfig/pull/26
https://github.com/vyos/vyos-1x/pull/4398

Mon, Mar 17, 5:40 AM · VyOS Rolling

Thu, Mar 13

jestabro closed T5400: Move libvyosconfig build out of the Docker image, a subtask of T5528: Replace legacy loadFile with config_diff, as Resolved.
Thu, Mar 13, 2:56 PM · VyOS Rolling
jestabro closed T5400: Move libvyosconfig build out of the Docker image as Resolved.
Thu, Mar 13, 2:56 PM · VyOS 1.5 Circinus, VyOS Rolling

Tue, Mar 11

jestabro committed rVYOSONEX755d440bf5bd: T5400: clean up directory as needed before local build of libvyosconfig.
Tue, Mar 11, 9:55 AM

Mar 5 2025

jestabro committed rVYOSONEX731195c7adb2: T5400: add local build of libvyosconfig to Makefile.
Mar 5 2025, 8:15 AM

Feb 20 2025

jestabro moved T7170: Fix sed pattern for change in OPAM install.sh from Need Triage to Completed on the VyOS Rolling board.
Feb 20 2025, 1:53 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling
jestabro moved T7170: Fix sed pattern for change in OPAM install.sh from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.2) board.
Feb 20 2025, 1:53 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T7170: Fix sed pattern for change in OPAM install.sh as Resolved.
Feb 20 2025, 1:52 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling

Feb 19 2025

jestabro moved T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery from Need Triage to Completed on the VyOS Rolling board.
Feb 19 2025, 7:36 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling
jestabro moved T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.2) board.
Feb 19 2025, 7:36 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery as Resolved.
Feb 19 2025, 7:36 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling
jestabro closed T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery, a subtask of T5103: DHCP default route duplicated when moving interface between VRFs, as Resolved.
Feb 19 2025, 7:36 PM · VyOS 1.4 Sagitta (1.4.2), VyOS Rolling, VyOS 1.5 Circinus
jestabro committed rVYOSONEX4a049c36bbc3: T7182: use Config instead of ConfigTreeQuery for get_interface_dict.
Feb 19 2025, 7:27 PM
jestabro committed rVYOSONEX1316b470886c: T7182: normalize formatting.
Feb 19 2025, 7:27 PM
jestabro added a subtask for T5103: DHCP default route duplicated when moving interface between VRFs: T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery.
Feb 19 2025, 5:56 PM · VyOS 1.4 Sagitta (1.4.2), VyOS Rolling, VyOS 1.5 Circinus
jestabro added a parent task for T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery: T5103: DHCP default route duplicated when moving interface between VRFs.
Feb 19 2025, 5:56 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling
jestabro created T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery.
Feb 19 2025, 5:56 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling

Feb 14 2025

jestabro created T7170: Fix sed pattern for change in OPAM install.sh.
Feb 14 2025, 6:58 PM · VyOS 1.4 Sagitta (1.4.2), VyOS 1.5 Circinus, VyOS Rolling

Feb 5 2025

jestabro closed T6718: Use vyconf daemon for validation of set commands as Resolved.
Feb 5 2025, 2:43 PM · VyOS Rolling