Page MenuHomeVyOS Platform
People jestabro

jestabro (John Estabrook)
User

Projects (11)
View All

User Details

User Since
Apr 12 2019, 4:27 PM (351 w, 5 d)

Recent Activity
View All

Yesterday

jestabro updated the task description for T8157: In the absence of an XML valueHelp element, use the help element for vyconf analogue of completion.
Wed, Jan 7, 3:13 PM · VyOS Rolling

Tue, Jan 6

jestabro renamed T8157: In the absence of an XML valueHelp element, use the help element for vyconf analogue of completion from In the absence of a valueHelp, use the help element for vyconf analogue of completion to In the absence of an XML valueHelp element, use the help element for vyconf analogue of completion.
Tue, Jan 6, 10:58 PM · VyOS Rolling
jestabro added a subtask for T8061: Add analogue of cli-shell-api getCompletionEnv: T8157: In the absence of an XML valueHelp element, use the help element for vyconf analogue of completion.
Tue, Jan 6, 10:52 PM · VyOS Rolling
jestabro added a parent task for T8157: In the absence of an XML valueHelp element, use the help element for vyconf analogue of completion: T8061: Add analogue of cli-shell-api getCompletionEnv.
Tue, Jan 6, 10:52 PM · VyOS Rolling
jestabro created T8157: In the absence of an XML valueHelp element, use the help element for vyconf analogue of completion.
Tue, Jan 6, 10:52 PM · VyOS Rolling
jestabro added a parent task for T8156: Fix misplaced check in vyconf analogue of get completion env: T8061: Add analogue of cli-shell-api getCompletionEnv.
Tue, Jan 6, 7:32 PM · VyOS Rolling
jestabro added a subtask for T8061: Add analogue of cli-shell-api getCompletionEnv: T8156: Fix misplaced check in vyconf analogue of get completion env.
Tue, Jan 6, 7:32 PM · VyOS Rolling
jestabro renamed T8156: Fix misplaced check in vyconf analogue of get completion env from Add misplaced check in vyconf analogue of get completion env to Fix misplaced check in vyconf analogue of get completion env.
Tue, Jan 6, 7:31 PM · VyOS Rolling
jestabro renamed T8156: Fix misplaced check in vyconf analogue of get completion env from Add missing check in vyconf analogue of get completion env to Add misplaced check in vyconf analogue of get completion env.
Tue, Jan 6, 7:26 PM · VyOS Rolling
jestabro created T8156: Fix misplaced check in vyconf analogue of get completion env.
Tue, Jan 6, 7:15 PM · VyOS Rolling

Mon, Jan 5

jestabro added a comment to T6625: Firewall group size limit API.

This is due to a hardcoded limit on the size of the underlying unionfs file in vyatta-cfg: as the value was set rather arbitrarily, we will increase the limit from 2^18 to 2^20. Note that limit is encountered irrespective of the use of the http api.

Mon, Jan 5, 2:06 PM · VyOS Rolling, Bugs

Fri, Jan 2

jestabro closed T8061: Add analogue of cli-shell-api getCompletionEnv as Resolved.
Fri, Jan 2, 3:02 PM · VyOS Rolling
jestabro closed T8109: Fix for vyconf show command on leaf nodes as Resolved.
Fri, Jan 2, 3:02 PM · VyOS Rolling
jestabro closed T8113: Fix typo in vyconf show command as Resolved.
Fri, Jan 2, 3:02 PM · VyOS Rolling
jestabro closed T8114: Fix check on vyconf allowed delete paths as Resolved.
Fri, Jan 2, 3:02 PM · VyOS Rolling

Tue, Dec 23

jestabro committed rVYOSONEXfb1788c3813d: T8061: add protobuf messages related to getCompletionEnv.
Tue, Dec 23, 2:55 AM
jestabro committed rVYOSONEX50163be161a5: T8061: T8109: T8113: T8114: update for completion and bug fixes.
Tue, Dec 23, 2:55 AM

Sun, Dec 21

jestabro created T8114: Fix check on vyconf allowed delete paths.
Sun, Dec 21, 3:05 PM · VyOS Rolling
jestabro updated the task description for T8113: Fix typo in vyconf show command.
Sun, Dec 21, 3:02 PM · VyOS Rolling
jestabro created T8113: Fix typo in vyconf show command.
Sun, Dec 21, 3:00 PM · VyOS Rolling

Fri, Dec 19

jestabro created T8109: Fix for vyconf show command on leaf nodes.
Fri, Dec 19, 3:38 PM · VyOS Rolling
jestabro closed T8074: Redistribute options from vyconf_cli to vyconf_cli_compat as Resolved.
Fri, Dec 19, 2:13 PM · VyOS Rolling

Thu, Dec 18

jestabro added a parent task for T8103: Fix regression in test in_session with vyos_op_run under http api: T7745: Implement command permission checks for local operator users.
Thu, Dec 18, 2:24 PM · VyOS Rolling
jestabro added a subtask for T7745: Implement command permission checks for local operator users: T8103: Fix regression in test in_session with vyos_op_run under http api.
Thu, Dec 18, 2:24 PM · VyOS Rolling

Tue, Dec 16

jestabro closed T8103: Fix regression in test in_session with vyos_op_run under http api as Resolved.
Tue, Dec 16, 2:08 PM · VyOS Rolling
jestabro committed rVYOSONEX766a868ebeaf: T8103: add root to those allowed to call op-run commands directly.
Tue, Dec 16, 2:06 PM

Mon, Dec 15

jestabro created T8103: Fix regression in test in_session with vyos_op_run under http api.
Mon, Dec 15, 5:53 PM · VyOS Rolling

Dec 5 2025

jestabro created T8074: Redistribute options from vyconf_cli to vyconf_cli_compat.
Dec 5 2025, 6:51 PM · VyOS Rolling

Dec 4 2025

jestabro closed T7319: Add warning message for unsaved changes in the dialog before initiating an upgrade as Resolved.
Dec 4 2025, 3:10 PM · VyOS 1.4 Sagitta (1.4.4), VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro closed T8032: Add analogue of cli-shell-api sessionUnsaved as Resolved.
Dec 4 2025, 3:09 PM · VyOS Rolling
jestabro reopened T8032: Add analogue of cli-shell-api sessionUnsaved as "Open".
Dec 4 2025, 2:32 PM · VyOS Rolling
jestabro closed T8031: Use a smarter file comparison in boolean test unsaved_commits() as Resolved.
Dec 4 2025, 2:31 PM · VyOS 1.4 Sagitta (1.4.4)
jestabro closed T8032: Add analogue of cli-shell-api sessionUnsaved as Resolved.
Dec 4 2025, 2:30 PM · VyOS Rolling

Dec 3 2025

jestabro committed rVYOSONEX9c850218b663: T8032: add protobuf files for analogue of sessionUnsaved.
Dec 3 2025, 12:07 AM
jestabro committed rVYOSONEXe71c5909cb98: T8032: update commit hashes for analogue of sessionUnsaved.
Dec 3 2025, 12:07 AM

Dec 2 2025

jestabro created T8062: Set default value for commit-revisions, making the commit archive mandatory.
Dec 2 2025, 7:01 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro updated the task description for T8032: Add analogue of cli-shell-api sessionUnsaved.
Dec 2 2025, 2:43 PM · VyOS Rolling
jestabro created T8061: Add analogue of cli-shell-api getCompletionEnv.
Dec 2 2025, 2:43 PM · VyOS Rolling

Nov 27 2025

jestabro committed rVYOSONEXaca852eb53dd: T8009: update commit hashes for vyconf edit-level aware session.
Nov 27 2025, 1:06 AM

Nov 26 2025

jestabro committed rVYOSONEX6943bdc5fc27: T8009: add vyconf_cli_compat for retained options of cli-shell-api.
Nov 26 2025, 7:52 PM
jestabro committed rVYOSONEXfd0104e0a48d: T8009: add generated protobuf files for edit_level.
Nov 26 2025, 7:52 PM
jestabro committed rVYOSONEX7ed7e7acf4f7: T7319: check unsaved_commits before upgrade.
Nov 26 2025, 7:34 PM
jestabro committed rVYOSONEX671210b3c0b8: T8041: update comments referring to deprecated priority.pl.
Nov 26 2025, 7:24 PM

Nov 24 2025

jestabro committed rVYOSONEX0bc7898a9651: T8031: use util file_compare for check unsaved_commits.
Nov 24 2025, 2:23 PM
jestabro committed rVYOSONEXb80bba65567c: T8031: add file comparison utility for comparison modulo empty lines.
Nov 24 2025, 2:23 PM
jestabro created T8032: Add analogue of cli-shell-api sessionUnsaved.
Nov 24 2025, 1:19 AM · VyOS Rolling
jestabro closed T7992: Remove references to OPAM in skel/.bashrc as Resolved.
Nov 24 2025, 1:14 AM · VyOS 1.4 Sagitta (1.4.4)
jestabro closed T7988: Extend vyconf show command for parity with legacy show command as Resolved.
Nov 24 2025, 1:10 AM · VyOS Rolling

Nov 21 2025

jestabro updated the task description for T8031: Use a smarter file comparison in boolean test unsaved_commits().
Nov 21 2025, 7:31 PM · VyOS 1.4 Sagitta (1.4.4)
jestabro created T8031: Use a smarter file comparison in boolean test unsaved_commits().
Nov 21 2025, 6:37 PM · VyOS 1.4 Sagitta (1.4.4)

Nov 20 2025

jestabro committed rVYOSONEXf26f737f0c58: T7988: adjust function name to distinguish compare from show config.
Nov 20 2025, 2:51 PM
jestabro committed rVYOSONEXe74b9a1b4d9d: T7988: update commit hashes for show config.
Nov 20 2025, 2:51 PM
jestabro triaged T8026: HTTPS API for /generate not working properly for wireguard interface as Normal priority.

A related issue is here: https://vyos.dev/T8000.

Nov 20 2025, 1:20 AM

Nov 19 2025

jestabro added a subtask for T7836: The /config bind mount does not respect inode updates: T7994: Image installer doesn't detect previous installation.
Nov 19 2025, 4:50 PM · VyOS 1.5 Circinus (2025.11)
jestabro added a parent task for T7994: Image installer doesn't detect previous installation: T7836: The /config bind mount does not respect inode updates.
Nov 19 2025, 4:50 PM · VyOS Rolling
jestabro closed T7994: Image installer doesn't detect previous installation as Resolved.
Nov 19 2025, 4:43 PM · VyOS Rolling

Nov 18 2025

jestabro committed rVYOSONEX6e7c62022a2a: T7992: remove unneeded references to OPAM in skel/.bashrc.
Nov 18 2025, 3:51 PM

Nov 17 2025

jestabro committed rVYOSONEXcf8f89262583: T7994: fix regression in check for previous installations on install.
Nov 17 2025, 3:25 PM

Nov 14 2025

jestabro added a comment to T7994: Image installer doesn't detect previous installation.

PR:
https://github.com/vyos/vyos-1x/pull/4849

Nov 14 2025, 3:50 PM · VyOS Rolling
jestabro claimed T7994: Image installer doesn't detect previous installation.
Nov 14 2025, 3:28 PM · VyOS Rolling

Nov 13 2025

jestabro created T8009: Extend vyconf session to be edit-level aware.
Nov 13 2025, 1:55 AM · VyOS Rolling

Nov 12 2025

jestabro closed T7711: config-sync: TypeError: 'coroutine' object is not iterable as Resolved.
Nov 12 2025, 6:31 PM · VyOS 1.5 Circinus (2025.11)
jestabro edited projects for T7321: Replace legacy operations in configsession.py with vyconf client operations, added: VyOS Rolling; removed VyOS 1.5 Circinus (2025.11).
Nov 12 2025, 5:54 PM · VyOS Rolling

Nov 11 2025

jestabro lowered the priority of T7307: Data added via vyos.utils.configfs.add_cli_node() not available when script is called via call_depends() from High to Wishlist.

Based on the comments above, I am moving this to 'wishlist' for consideration after the legacy backend is retired. My expectation is that we will not want to drop the invariant as such, however, we will be in a position to consider refinements of the model, radical or conservative, once freed from the legacy constraints.

Nov 11 2025, 5:05 PM · VyOS Rolling, VyOS 1.5 Circinus

Nov 6 2025

jestabro closed T7946: Log redirected stdout from FRRender under vyos-configd, a subtask of T7855: Redirect stdout and catch exceptions from FRRender under vyos-configd, as Resolved.
Nov 6 2025, 3:58 PM · VyOS 1.5 Circinus (2025.11)
jestabro closed T7946: Log redirected stdout from FRRender under vyos-configd as Resolved.
Nov 6 2025, 3:58 PM · VyOS 1.5 Circinus (2025.11)
jestabro moved T7946: Log redirected stdout from FRRender under vyos-configd from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q3) board.
Nov 6 2025, 3:57 PM · VyOS 1.5 Circinus (2025.11)
jestabro edited projects for T7946: Log redirected stdout from FRRender under vyos-configd, added: VyOS 1.5 Circinus (1.5-stream-2025-Q3); removed VyOS 1.5 Circinus (1.5-stream-2025-Q4).
Nov 6 2025, 3:57 PM · VyOS 1.5 Circinus (2025.11)
jestabro closed T7910: Standardize vyconf session resource management across Python config modules, a subtask of T7374: Integrate vyconf config session with CLI config session, as Resolved.
Nov 6 2025, 3:57 PM · VyOS Rolling
jestabro closed T7910: Standardize vyconf session resource management across Python config modules as Resolved.
Nov 6 2025, 3:57 PM · VyOS Rolling
jestabro closed T7915: Add compile time alerts for static exception analysis of vyos1x-config/vyconf as Resolved.
Nov 6 2025, 3:56 PM · VyOS Rolling
jestabro closed T7969: Add value_exists to configtree as Resolved.
Nov 6 2025, 3:56 PM · VyOS Rolling
jestabro closed T7980: Load active config on vyconfd restart as Resolved.
Nov 6 2025, 3:55 PM · VyOS Rolling
jestabro committed rVYOSONEX128885203149: T7915: update commit hashes for exn-alert.
Nov 6 2025, 3:31 PM
jestabro committed rVYOSONEX42015261ce2e: T7915: minor fixes for consistent exception handling and error messages.
Nov 6 2025, 3:31 PM
jestabro committed rVYOSONEX47cc7ab10b9b: T7969: expose boolean test value_exists.
Nov 6 2025, 3:31 PM

Nov 5 2025

jestabro committed rVYOSONEXcad2c08ee6f2: T7910: update auto-generated protobuf files for show_sessions.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEX47b36a3af0bd: T7910: switch keyword order pid/token for consistency and intuition.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEXa02b7d54c561: T7910: add call show_sessions.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEX4c391ed39c51: T7910: add keyword extant, for use by teardown script.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEXc414a7d55579: T7910: use weakref.finalize for reliable session teardown.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEXcbbfd427896d: T7910: op-mode init should always start a new session.
Nov 5 2025, 6:21 PM
jestabro committed rVYOSONEX2a574f7e146a: T7910: call enter_config_mode only on new session.
Nov 5 2025, 6:21 PM

Nov 4 2025

jestabro renamed T7991: Fix regex in constraints interface-name.xml.i, interface-name-with-wildcard.xml.i from Fix regex in constriants interface-name.xml.i, interface-name-with-wildcard.xml.i to Fix regex in constraints interface-name.xml.i, interface-name-with-wildcard.xml.i.
Nov 4 2025, 7:47 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling
jestabro created T7992: Remove references to OPAM in skel/.bashrc.
Nov 4 2025, 7:44 PM · VyOS 1.4 Sagitta (1.4.4)
jestabro created T7991: Fix regex in constraints interface-name.xml.i, interface-name-with-wildcard.xml.i.
Nov 4 2025, 7:33 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q4), VyOS Rolling

Nov 3 2025

jestabro committed rVYOSONEXbad8393c730b: T7980: T7910: update libvyosconfig/Makefile for vyconfd restart/show_sessions.
Nov 3 2025, 4:21 PM
jestabro created T7988: Extend vyconf show command for parity with legacy show command.
Nov 3 2025, 3:33 PM · VyOS Rolling
jestabro committed rVYOSONEX75716e99f0bf: T7980: defer startup of vyconfd for consistent bookkeeping.
Nov 3 2025, 1:46 PM
jestabro committed rVYOSONEX018b6fd1275e: T7980: distinguish vyconfd initialization from restart.
Nov 3 2025, 1:46 PM

Nov 2 2025

jestabro added a comment to T7980: Load active config on vyconfd restart.

PRs:
https://github.com/vyos/vyconf/pull/34
https://github.com/vyos/vyos1x-config/pull/55
https://github.com/vyos/vyos-1x/pull/4827

Nov 2 2025, 5:21 AM · VyOS Rolling

Nov 1 2025

jestabro created T7980: Load active config on vyconfd restart.
Nov 1 2025, 1:38 AM · VyOS Rolling

Oct 29 2025

jestabro added a comment to T7969: Add value_exists to configtree.

Included in PRs:
https://github.com/vyos/vyos1x-config/pull/54
https://github.com/vyos/vyos-1x/pull/4814

Oct 29 2025, 3:58 PM · VyOS Rolling
jestabro created T7969: Add value_exists to configtree.
Oct 29 2025, 1:20 PM · VyOS Rolling

Oct 28 2025

jestabro added a comment to T7915: Add compile time alerts for static exception analysis of vyos1x-config/vyconf.

PRs:
https://github.com/vyos/vyos1x-config/pull/54
https://github.com/vyos/vyconf/pull/33
https://github.com/vyos/vyos-1x/pull/4814

Oct 28 2025, 11:42 PM · VyOS Rolling
jestabro committed rVYOSONEXd2a1bde262ed: dhcp-server: T3936: fix indent typo.
Oct 28 2025, 5:57 PM

Oct 26 2025

jestabro added a comment to T7307: Data added via vyos.utils.configfs.add_cli_node() not available when script is called via call_depends().

The assumption stated in the description is true, as discussed with @c-po at the time. The following invariant is fundamental to the operation of the commit algorithm (legacy and modern) and the config daemons: during a commit, the active and proposed configs are fixed --- no updates during the commit are reflected in any script's config dict, including those called by config dependencies. Evolution of this model will require a refinement of config dependencies, which is not possible until the legacy backend is retired.

Oct 26 2025, 5:52 PM · VyOS Rolling, VyOS 1.5 Circinus

Oct 23 2025

jestabro added a comment to T7910: Standardize vyconf session resource management across Python config modules.

PRs:
https://github.com/vyos/vyconf/pull/32
https://github.com/vyos/vyos-1x/pull/4807

Oct 23 2025, 1:41 AM · VyOS Rolling

Oct 21 2025

jestabro committed rVYOSONEX40c95fe290b0: T7946: log redirected stdout from FRRender.
Oct 21 2025, 2:27 PM

Oct 20 2025

jestabro added a comment to T7946: Log redirected stdout from FRRender under vyos-configd.

PR:
https://github.com/vyos/vyos-1x/pull/4802

Oct 20 2025, 3:39 PM · VyOS 1.5 Circinus (2025.11)