Page MenuHomeVyOS Platform
Create Task
Maniphest T5103

DHCP default route duplicated when moving interface between VRFs
Closed, ResolvedPublicBUG
Actions

Description

When moving an interface with a DHCP default route between VRFs, the default route isn't removed from the old VRF.

Setup:

set interfaces ethernet eth0 address dhcp
commit
sleep 10
vtysh -c 'show running-config'
Building configuration...

Current configuration:
!
frr version 8.4.2
frr defaults traditional
hostname vyos
log syslog
log facility local7
service integrated-vtysh-config
!
ip route 0.0.0.0/0 192.168.128.1 eth0 tag 210 210
!
rpki
exit
!
end

Note the presence of a default route in the default VRF.

Bug:

set vrf name MGMT table 100
set interfaces ethernet eth0 vrf MGMT
commit
vtysh -c 'show running-config'
Building configuration...

Current configuration:
!
frr version 8.4.2
frr defaults traditional
hostname vyos
log syslog
log facility local7
service integrated-vtysh-config
!
ip route 0.0.0.0/0 192.168.128.1 eth0 tag 210 210
!
vrf MGMT
 ip route 0.0.0.0/0 192.168.128.1 eth0 tag 210 210
exit-vrf
!
rpki
exit
!
end

Note the default route wasn't removed from the default VRF.

Details

Version
1.4-rolling-202303170317
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

stepler created this task.Mar 21 2023, 6:18 PM
stepler mentioned this in T5104: DHCP default route issues with static routes in VRFs.
pasik subscribed.Mar 21 2023, 7:15 PM
Viacheslav changed the task status from Open to Needs testing.Jan 20 2024, 12:12 PM
Viacheslav triaged this task as Normal priority.
syncer edited projects, added VyOS 1.4 Sagitta (1.4.0-GA); removed VyOS 1.4 Sagitta.May 7 2024, 8:03 AM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.1); removed VyOS 1.4 Sagitta (1.4.0-GA).Jul 2 2024, 7:29 PM
dmbaturin added a project: Restricted Project.Sep 16 2024, 4:16 PM
dmbaturin edited projects, added VyOS 1.5 Circinus, VyOS Rolling; removed Restricted Project.Oct 14 2024, 9:21 AM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).
vyosbot added a project: Bugs.Oct 14 2024, 11:32 AM
syncer added a subscriber: Global Notifications.Nov 1 2024, 9:19 PM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.2); removed Bugs, VyOS 1.4 Sagitta (1.4.1).Dec 3 2024, 4:13 PM
dmbaturin subscribed.

Still reproducible in a sagitta build from 2024-12-02.

dmbaturin assigned this task to c-po.Jan 23 2025, 4:01 PM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.3); removed VyOS 1.4 Sagitta (1.4.2).
c-po changed the task status from Needs testing to In progress.Feb 4 2025, 6:53 PM
c-po added a comment.EditedFeb 5 2025, 7:30 PM

Confirmed for:

  • 1.4.1
  • 1.4-stable-202502050953
  • 1.5-stream-202502051856

Not affected:

  • 1.5-rolling-202502050918 (but it lacks the default route after interface move)
cpo@LR1.wue3# run show ip route vrf red
Codes: K - kernel route, C - connected, L - local, S - static,
       R - RIP, O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, F - PBR,
       f - OpenFabric, t - Table-Direct,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure

VRF red:
K>* 127.0.0.0/8 [0/0] is directly connected, red, weight 1, 00:00:16
C>* 172.16.33.0/24 is directly connected, eth0.10, weight 1, 00:00:16
L>* 172.16.33.102/32 is directly connected, eth0.10, weight 1, 00:00:16

cpo@LR1.wue3# run renew dhcp interface eth0.10
Restarting DHCP client on interface eth0.10...
[edit]
cpo@LR1.wue3# run show ip route vrf red
Codes: K - kernel route, C - connected, L - local, S - static,
       R - RIP, O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, F - PBR,
       f - OpenFabric, t - Table-Direct,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure

VRF red:
S>* 0.0.0.0/0 [210/0] via 172.16.33.254, eth0.10, weight 1, 00:00:01
K>* 127.0.0.0/8 [0/0] is directly connected, red, weight 1, 00:00:58
C>* 172.16.33.0/24 is directly connected, eth0.10, weight 1, 00:00:01
K * 172.16.33.0/24 [0/0] is directly connected, eth0.10, weight 1, 00:00:01
L>* 172.16.33.102/32 is directly connected, eth0.10, weight 1, 00:00:01

The reason for this issue (lacking default route after VRF move) is related to /sbin/dhclient not beeing restarted after it has been moved to a different VRF. It will complain about: dhclient[5843]: receive_packet failed on eth0.10: Network is down

https://github.com/vyos/vyos-1x/pull/4335

c-po moved this task from Need Triage to Backlog - Bug on the VyOS Rolling board.Feb 5 2025, 8:15 PM
c-po added a subtask: T7135: DHCPv6 client is restarted on every change to the interface.Feb 5 2025, 9:44 PM
c-po mentioned this in rVYOSONEX68002a3839d2: vyos.ifconfig: T5103: force dhclient restart on VRF change.Feb 6 2025, 5:36 PM
c-po mentioned this in rVYOSONEXa04bd4901b0a: vyos.ifconfig: T5103: revert change to del_addr() signature.
Restricted Repository Identity mentioned this in rVYOSONEXedda97d0aa9a: Merge pull request #4335 from c-po/T5103.Feb 6 2025, 5:36 PM
c-po moved this task from Backlog - Bug to Completed on the VyOS Rolling board.Feb 7 2025, 4:39 PM
c-po added a comment.Feb 8 2025, 1:31 PM

https://github.com/vyos/vyos-1x/pull/4340

c-po mentioned this in rVYOSONEX8faf67c1fab0: netplug: T5103: only execute helper scripts on physical interfaces.Feb 9 2025, 3:13 PM
c-po mentioned this in rVYOSONEX9e313faaef13: vyos.ifconfig: T5103: always stop the DHCP client process bevore changing VRF.
Restricted Repository Identity mentioned this in rVYOSONEX41e9b8b362fa: Merge pull request #4340 from c-po/T5103-vrf-dhcp.Feb 9 2025, 3:13 PM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.2); removed VyOS 1.4 Sagitta (1.4.3).Feb 11 2025, 3:43 PM
c-po moved this task from Open to Finished on the VyOS 1.5 Circinus board.Feb 11 2025, 8:55 PM
c-po closed this task as Resolved.Feb 13 2025, 3:11 PM
c-po moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.2) board.
c-po closed subtask T7135: DHCPv6 client is restarted on every change to the interface as Resolved.
jestabro mentioned this in T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery.Feb 19 2025, 5:56 PM
jestabro added a subtask: T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery.
jestabro closed subtask T7182: vyos-netplug-dhcp-client requires Config instead of ConfigTreeQuery as Resolved.Feb 19 2025, 7:36 PM
dmbaturin mentioned this in 1.4.2.Wed, Apr 2, 3:24 PM