Great addition, it has one minor bug.

The problem is that, comparing to command output on 1.3, it only show the leases granted by the router (and doesn't contain leases granted by the second router, regardless of states primary|secondary.
So user might think synchronization between routers defined in fail-over mode is broken.
But this is not the case. As explained in the description, all information about leases, granted by both routers, is present on lease files on both routers.

PR for 1.5 https://github.com/vyos/vyos-1x/pull/2544

PR:
https://github.com/vyos/vyos-1x/pull/2542

KeyboardInterrupt is caught with an appropriate error message now.

What is the difference between local router and failover router? It is not clear. My local router in failover mode ;) but state master.

Backport to 1.4?

And going further, we may create an extra column, in order to print if the lease was granted by Local-Router or by fail-over router..
Example:

Changing this line: https://github.com/vyos/vyos-1x/blob/current/src/op_mode/dhcp.py#L117C9-L117C107

Do you want to see leases state == backup?
What is the expected?

Pretty sure some preceding backports are pending. Please give me a couple of days. I plan to sync up 1.4 with 1.5 and update the docs.

Looks like this has been resolved using the latest 1.4 nftables. I am now able to specify local time without the use of UTC.

We'll discuss this internally, but for sure a fix should be applied.
Thanks for such a detailed bug-report.

PR https://github.com/vyos/vyos-build/pull/459

Agree with @Viacheslav and @GurliGebis comments above.

I agree, without it, you end up repeating yourself alot, with the established, related and invalid rules.
As long as they are applied before the zone specific rules (which is how I guess it used to work), it makes sense.

There are different commands

vyos@r1:~$ show bgp neighbors 192.168.122.14 advertised-routes 
% No such neighbor or address family
vyos@r1:~$ 
vyos@r1:~$ show ip  bgp neighbors 192.168.122.14 advertised-routes 
vyos@r1:~$

Should we return global state policy?
It was useful.