Page MenuHomeVyOS Platform
Create Task
Maniphest T5774

commit-archive to FTP server broken after update (VyOS 1.5-rolling)
Closed, ResolvedPublicBUG
Actions

Description

After upgrading from VyOS 1.5-rolling-202310120020 to 1.5-rolling-202311160736 I receive an error when committing any changes to archive location (FTP server).

Unable to upload “ftp://<…>/config.boot-vpn-hn-hh-01-02.20231117_100016”: str, bytes or bytearray expected, not int

Manually saving the config file to the FTP server is working without any issues.

save ftp://[..]/test.cfg

This is my forum entry for reference.

Details

Difficulty level
Unknown (require assessment)
Version
1.5-rolling-202311160736
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

I-n-d-y created this task.Nov 22 2023, 4:52 PM
I-n-d-y created this object in space S1 VyOS Public.
I-n-d-y raised the priority of this task from Low to Requires assessment.Nov 22 2023, 4:54 PM
Viacheslav triaged this task as Normal priority.Nov 22 2023, 4:56 PM
Viacheslav changed the subtype of this task from "Task" to "Bug".
Viacheslav assigned this task to erkin.Nov 22 2023, 5:06 PM
pasik added a subscriber: pasik.Nov 22 2023, 5:14 PM
erkin added a parent task: T5773: Unable to load config via HTTP.Nov 25 2023, 12:56 PM
naterator added a subscriber: naterator.Dec 7 2023, 1:43 PM
Viacheslav added a subscriber: Viacheslav.Dec 9 2023, 7:33 PM

@I-n-d-y Could you re-check?

I-n-d-y added a comment.EditedDec 10 2023, 10:03 AM

@Viacheslav I updated to the latest rolling version (VyOS 1.5-rolling-202312080024) in thr issue still persists but the error message ist different:

Archiving config...

ftp://nas-hn-hh-01.hn.int/backup/Config/Devices/vpn-hn-hh-01/02 FAILED!

 > upload() got an unexpected keyword argument 'raise_error'

The configured FTP URL contains username and password to access the FTP server.

jestabro added a subscriber: jestabro.Dec 13 2023, 5:16 PM

PR:
https://github.com/vyos/vyos-1x/pull/2628

jestabro added a project: VyOS 1.4 Sagitta.Dec 13 2023, 5:18 PM
jestabro changed the task status from Open to Backport pending.Dec 13 2023, 10:01 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
jestabro closed this task as Resolved.Dec 14 2023, 2:59 AM
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
erkin mentioned this in T5845: sftp/scp commit-archive error.Dec 28 2023, 3:43 PM