Page MenuHomeVyOS Platform
Feed All Stories

Mar 10 2023

c-po moved T4959: Add container registry authentication config for containers from Need Triage to Finished on the VyOS 1.4 Sagitta board.
Mar 10 2023, 8:19 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
c-po changed the status of T4959: Add container registry authentication config for containers from In progress to Needs testing.
Mar 10 2023, 8:19 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
c-po moved T5079: xml: schema extension to support defaultValues on tagNodes from Need Triage to Finished on the VyOS 1.4 Sagitta board.
Mar 10 2023, 8:19 PM · VyOS 1.4 Sagitta
c-po added a project to T5079: xml: schema extension to support defaultValues on tagNodes: VyOS 1.3 Equuleus (1.3.3).
Mar 10 2023, 8:18 PM · VyOS 1.4 Sagitta
c-po changed Difficulty level from unknown to easy on T5079: xml: schema extension to support defaultValues on tagNodes.
Mar 10 2023, 7:27 PM · VyOS 1.4 Sagitta
c-po changed the status of T5079: xml: schema extension to support defaultValues on tagNodes, a subtask of T4959: Add container registry authentication config for containers, from Open to In progress.
Mar 10 2023, 7:27 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
c-po changed the status of T5079: xml: schema extension to support defaultValues on tagNodes from Open to In progress.
Mar 10 2023, 7:27 PM · VyOS 1.4 Sagitta
c-po created T5079: xml: schema extension to support defaultValues on tagNodes.
Mar 10 2023, 7:27 PM · VyOS 1.4 Sagitta
MartB added a comment to T3316: Use Kea DHCP(v6) instead of ISC DHCP(v6).

@sdev just for clarification do you mean "deleted" as in only existing entries but new ones will work or completely deleted?
Im asking because I do use keas global, subnet, pool and class option-data support extensively outside of vyos.
If this would stay/become a part of vyos that would be great!

Mar 10 2023, 5:27 PM · VyOS 1.5 Circinus
Viacheslav added a comment to T5058: Extend template filter range_to_regex.

PR https://github.com/vyos/vyos-1x/pull/1884

>>> range_to_regex(['10-20', '22-35', '50'])
'(1\\d|20|2[2-9]|3[0-5]|50)'
>>>
Mar 10 2023, 2:05 PM · VyOS 1.4 Sagitta
Viacheslav changed the status of T5070: show bgp nexthop unavailable in VRF from Open to Needs testing.
Mar 10 2023, 1:02 PM · VyOS 1.4 Sagitta
Viacheslav changed the status of T5074: Show IPSEC SA failed if remote access IKEv2 vpn is used. from In progress to Needs testing.
Mar 10 2023, 12:40 PM · VyOS 1.4 Sagitta
Viacheslav changed the status of T4973: show dhcp server leases error for lease time 4294967295 from In progress to Needs testing.

Will be fixed in the next rolling release

Mar 10 2023, 12:02 PM · VyOS 1.4 Sagitta
tfiebig added a comment to T5078: VyOS BGP does not support 'show bgp neighbors $NB filtered-routes'.

Wanted to have the ticketid to write the right commit message right away. Diff is here: https://github.com/vyos/vyos-1x/compare/current...ichdasich:vyos-1x:filtered_routes

Mar 10 2023, 11:51 AM · VyOS 1.4 Sagitta
tfiebig created T5078: VyOS BGP does not support 'show bgp neighbors $NB filtered-routes'.
Mar 10 2023, 11:50 AM · VyOS 1.4 Sagitta
Viacheslav added a comment to T5058: Extend template filter range_to_regex.

If we add vlan to range we get error

set service ipoe-server authentication mode 'noauth'
set service ipoe-server client-ip-pool name POOL1 gateway-address '192.0.2.1'
set service ipoe-server client-ip-pool name POOL1 subnet '192.0.2.0/24'
set service ipoe-server interface eth1 vlan '2000-3000'
commit
set service ipoe-server interface eth1 vlan '50'
commit

The second commit:

Mar 10 2023, 10:18 AM · VyOS 1.4 Sagitta
Viacheslav reopened T5058: Extend template filter range_to_regex as "Needs testing".
Mar 10 2023, 10:16 AM · VyOS 1.4 Sagitta
a.apostoliuk changed the status of T4925: Need to add the possibility to configure Pseudo-Random Functions (PRF) in IKEv2 from Open to In progress.
Mar 10 2023, 9:35 AM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
a.apostoliuk added a project to T4925: Need to add the possibility to configure Pseudo-Random Functions (PRF) in IKEv2: VyOS 1.3 Equuleus (1.3.3).
Mar 10 2023, 9:35 AM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
a.apostoliuk reopened T4925: Need to add the possibility to configure Pseudo-Random Functions (PRF) in IKEv2 as "Open".
Mar 10 2023, 9:34 AM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
Viacheslav changed the status of T4973: show dhcp server leases error for lease time 4294967295 from Open to In progress.

PR https://github.com/vyos/vyos-1x/pull/1883

Mar 10 2023, 9:20 AM · VyOS 1.4 Sagitta
a.apostoliuk changed the status of T5074: Show IPSEC SA failed if remote access IKEv2 vpn is used. from Open to In progress.
Mar 10 2023, 8:18 AM · VyOS 1.4 Sagitta
a.apostoliuk claimed T5074: Show IPSEC SA failed if remote access IKEv2 vpn is used..
Mar 10 2023, 8:18 AM · VyOS 1.4 Sagitta
aserkin created T5077: routes completely dropped from the node while running L2TP LNS service.
Mar 10 2023, 7:44 AM · VyOS 1.4 Sagitta
Viacheslav renamed T4973: show dhcp server leases error for lease time 4294967295 from show dhcp server leases error for static entries to show dhcp server leases error for lease time 4294967295.
Mar 10 2023, 7:12 AM · VyOS 1.4 Sagitta

Mar 9 2023

klipz updated subscribers of T5055: Firewall - Add packet type matcher (pkttype).

@n.fort @Viacheslav
Here is an example of what I am after for DNAT rule, specifically, using meta pkttype:

Mar 9 2023, 7:31 PM · VyOS 1.4 Sagitta
c-po changed the status of T5076: CI/CD: Docker container is bloated by legacy and conflicting dependencies from Open to In progress.
Mar 9 2023, 7:06 PM · VyOS 1.4 Sagitta
c-po created T5076: CI/CD: Docker container is bloated by legacy and conflicting dependencies.
Mar 9 2023, 7:06 PM · VyOS 1.4 Sagitta
c-po closed T4952: Improve interface completion helper CLI experience as Resolved.
Mar 9 2023, 6:43 PM · VyOS 1.4 Sagitta
daniil added a comment to T4989: QoS Policy Limiter - classes for marked traffic do not work.

QoS Policy Limiter now works correctly.
But the shaper classes for tagged traffic don't work.

Mar 9 2023, 6:35 PM · vyatta-cfg-qos, VyOS 1.4 Sagitta
Jimz added a comment to T4973: show dhcp server leases error for lease time 4294967295.

I was able to get it to work as expected by reducing the lease below 4294967295 and removing the /config/dhcpd.leases file. It should work per the instruction to make the lease effectively static. It had worked in the past so at some point the check that the resultant lease end day is numeric.

Mar 9 2023, 5:59 PM · VyOS 1.4 Sagitta
Jimz added a comment to T4973: show dhcp server leases error for lease time 4294967295.

Example configuration:

Mar 9 2023, 5:25 PM · VyOS 1.4 Sagitta
sarthurdev added a comment to T5018: Redirect to IFB removed after change in qos policy.

PR: https://github.com/vyos/vyos-1x/pull/1881

Mar 9 2023, 5:09 PM · VyOS 1.4 Sagitta
sarthurdev changed the status of T5018: Redirect to IFB removed after change in qos policy from Confirmed to In progress.
Mar 9 2023, 4:26 PM · VyOS 1.4 Sagitta
Viacheslav awarded T5046: CLI for password complexity enforcement PAM module a Like token.
Mar 9 2023, 4:18 PM · VyOS 1.4 Sagitta
Viacheslav closed T5066: Different GRE tunnel but same tunnel keys error as Resolved.
Mar 9 2023, 4:02 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
Viacheslav changed the status of T5073: IPoE-server interface option failed to parse from In progress to Needs testing.
Mar 9 2023, 3:58 PM · VyOS 1.4 Sagitta
sarthurdev closed T5075: QoS removes interface mirror/redirect rules as Invalid.

My bad

Mar 9 2023, 3:23 PM · VyOS 1.4 Sagitta
rayzilt added a comment to T5075: QoS removes interface mirror/redirect rules.

Seems to be the same task -> https://vyos.dev/T5018

Mar 9 2023, 3:22 PM · VyOS 1.4 Sagitta
sarthurdev changed the status of T5075: QoS removes interface mirror/redirect rules from Open to In progress.
Mar 9 2023, 3:15 PM · VyOS 1.4 Sagitta
sarthurdev created T5075: QoS removes interface mirror/redirect rules.
Mar 9 2023, 3:15 PM · VyOS 1.4 Sagitta
tfiebig added a comment to T5069: bgp large-community-list regex validation incomplete.

Just put this on a live system, and it behaves as intended (so far). Special meaning of _ would certainly have to be added to the check, i guess, but that needs further delving into bgp-regex syntax.

Mar 9 2023, 2:45 PM · VyOS 1.4 Sagitta (1.4.0-epa), Restricted Project, VyOS 1.5 Circinus
erkin changed the status of T5046: CLI for password complexity enforcement PAM module, a subtask of T4712: Collaborative Protection Profile cPP for Network Devices root task, from Open to In progress.
Mar 9 2023, 2:42 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta
erkin changed the status of T5046: CLI for password complexity enforcement PAM module from Open to In progress.
Mar 9 2023, 2:42 PM · VyOS 1.4 Sagitta
erkin updated the task description for T5046: CLI for password complexity enforcement PAM module.
Mar 9 2023, 2:41 PM · VyOS 1.4 Sagitta
tfiebig added a comment to T5070: show bgp nexthop unavailable in VRF.

https://github.com/vyos/vyos-1x/pull/1880

Mar 9 2023, 2:07 PM · VyOS 1.4 Sagitta
Viacheslav added a comment to T4973: show dhcp server leases error for lease time 4294967295.

@Jimz could you share an example of configuration?
I can't reproduce it with

set service dhcp-server shared-network-name Lan01 authoritative
set service dhcp-server shared-network-name Lan01 name-server '1.1.1.1'
set service dhcp-server shared-network-name Lan01 subnet 192.0.2.0/24 default-router '192.0.2.1'
set service dhcp-server shared-network-name Lan01 subnet 192.0.2.0/24 range R1 start '192.0.2.10'
set service dhcp-server shared-network-name Lan01 subnet 192.0.2.0/24 range R1 stop '192.0.2.254'
set service dhcp-server shared-network-name Lan01 subnet 192.0.2.0/24 static-mapping myhost ip-address '192.0.2.5'
set service dhcp-server shared-network-name Lan01 subnet 192.0.2.0/24 static-mapping myhost mac-address '02:a6:0c:88:3e:a2'
Mar 9 2023, 1:43 PM · VyOS 1.4 Sagitta
tfiebig added a comment to T5070: show bgp nexthop unavailable in VRF.

Let me give it another test-run in a bit and then i'll issue a PR.

Mar 9 2023, 12:56 PM · VyOS 1.4 Sagitta
Viacheslav added a comment to T5070: show bgp nexthop unavailable in VRF.

Could you create a PR?

Mar 9 2023, 12:52 PM · VyOS 1.4 Sagitta
sarthurdev added a comment to T3008: Migrate from ntpd to chronyd.

Discovered a couple of problems with chrony using the existing CLI.

Mar 9 2023, 12:25 PM · VyOS 1.4 Sagitta
Viacheslav added a comment to T5063: IPoE-server ethX vlan must not be used with client-subnet.

PR https://github.com/vyos/vyos-1x/pull/1879

Mar 9 2023, 11:00 AM · VyOS 1.4 Sagitta
a.apostoliuk created T5074: Show IPSEC SA failed if remote access IKEv2 vpn is used..
Mar 9 2023, 9:25 AM · VyOS 1.4 Sagitta
Viacheslav added a comment to T5066: Different GRE tunnel but same tunnel keys error.

PR for 1.3 https://github.com/vyos/vyos-1x/pull/1878

Mar 9 2023, 9:21 AM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
Viacheslav edited projects for T5066: Different GRE tunnel but same tunnel keys error, added: VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.2).
Mar 9 2023, 8:53 AM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
Viacheslav moved T5066: Different GRE tunnel but same tunnel keys error from Need Triage to Finished on the VyOS 1.4 Sagitta board.
Mar 9 2023, 8:52 AM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
Viacheslav added a comment to T5073: IPoE-server interface option failed to parse.

PR https://github.com/vyos/vyos-1x/pull/1877

Mar 9 2023, 8:15 AM · VyOS 1.4 Sagitta
Viacheslav changed the status of T5073: IPoE-server interface option failed to parse from Open to In progress.
Mar 9 2023, 7:29 AM · VyOS 1.4 Sagitta
Viacheslav created T5073: IPoE-server interface option failed to parse.
Mar 9 2023, 7:29 AM · VyOS 1.4 Sagitta
Viacheslav changed the subtype of T5071: QOS-Rewrite: DSCP match missing from "Task" to "Bug".
Mar 9 2023, 3:56 AM · VyOS 1.4 Sagitta
MartB created T5072: QOS-Rewrite: protocol name used literally.
Mar 9 2023, 1:35 AM · VyOS 1.4 Sagitta
MartB created T5071: QOS-Rewrite: DSCP match missing.
Mar 9 2023, 1:31 AM · VyOS 1.4 Sagitta
MartB added a comment to T4989: QoS Policy Limiter - classes for marked traffic do not work.

@c-po Isnt this implementation wrong for "shaper" anyway?
The speed should only be taken from the interface as an last resort, if the default bandwidth is configured in a no percentage unit it should be used instead, no?

Mar 9 2023, 1:23 AM · vyatta-cfg-qos, VyOS 1.4 Sagitta

Mar 8 2023

tfiebig created T5070: show bgp nexthop unavailable in VRF.
Mar 8 2023, 8:30 PM · VyOS 1.4 Sagitta
tfiebig created T5069: bgp large-community-list regex validation incomplete.
Mar 8 2023, 7:39 PM · VyOS 1.4 Sagitta (1.4.0-epa), Restricted Project, VyOS 1.5 Circinus
jestabro triaged T5068: Generate op-mode API client requests along with schema generation as Normal priority.
Mar 8 2023, 7:39 PM · VyOS 1.4 Sagitta
jestabro edited projects for T4396: HTTP API no response after several days restarted, added: VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus (1.3.3).
Mar 8 2023, 7:16 PM · VyOS 1.4 Sagitta
jestabro closed T4396: HTTP API no response after several days restarted as Resolved N/A.

This was never reproduced; user will report if recurrence and we will reopen as needed.

Mar 8 2023, 7:15 PM · VyOS 1.4 Sagitta
jestabro edited projects for T4318: Add delete_tag to configtree.py, added: VyOS 1.4 Sagitta, VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).

Lower priority and will need testing when implemented.

Mar 8 2023, 7:10 PM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.4 Sagitta
jestabro closed T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command as Resolved.
Mar 8 2023, 3:17 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T4872: Op-mode show openvpn misses a case when parsing for tunnel IP, a subtask of T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command, as Resolved.
Mar 8 2023, 3:16 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T4872: Op-mode show openvpn misses a case when parsing for tunnel IP as Resolved.
Mar 8 2023, 3:16 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
dex created T5067: Recursively change group names in firewall rules.
Mar 8 2023, 2:13 PM · VyOS 1.4 Sagitta
dex added a comment to T5064: Value validation for domain-groups seems to be broken.

Looking at the regex it seems that . (dot) is also allowed. Is that right? If so, the error message should be altered accordingly.

Mar 8 2023, 1:35 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta
Viacheslav added a comment to T5066: Different GRE tunnel but same tunnel keys error.

PR https://github.com/vyos/vyos-1x/pull/1875

Mar 8 2023, 1:34 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
aserkin added a comment to T5045: BFD is not starting after upgrade to 1.4-rolling-202302150317.

As you can see LNS/MPLS-PE is being built on VyOS 1.4. MPLS-P are NSN (aka Alcatel Lucent) boxes as far as i know.

Mar 8 2023, 1:25 PM · VyOS 1.4 Sagitta
Viacheslav changed the status of T5066: Different GRE tunnel but same tunnel keys error from Open to In progress.
Mar 8 2023, 1:24 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
Viacheslav added a comment to T5064: Value validation for domain-groups seems to be broken.

There is the regex
It seems don't validate correctly if only one letter before the hyphen, underscores

vyos@r14# set firewall group domain-group a_aa
Mar 8 2023, 1:15 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta
fernando added a comment to T5045: BFD is not starting after upgrade to 1.4-rolling-202302150317.

Great project! As I understand it, you're using BGP label-unicast to transport labels, and I'm curious about the operating systems your PEs/Ps are running on - are they Cisco, Juniper, or other vendors? I'm particularly interested in learning about the interoperability between different vendors so that I can incorporate it into my testing. @aserkin

Mar 8 2023, 1:14 PM · VyOS 1.4 Sagitta
Viacheslav added a comment to T380: Add system service fail2ban.

For "SSH" we have dynamic-protection

vyos@r14# set service ssh dynamic-protection  
Possible completions:
+  allow-from           Always allow inbound connections from these systems
   block-time           Block source IP in seconds. Subsequent blocks increase by a
                        factor of 1.5 (default: 120)
   detect-time          Remember source IP in seconds before reset their score (default:
                        1800)
   threshold            Block source IP when their cumulative attack score exceeds
                        threshold (default: 30)
Mar 8 2023, 1:06 PM · Invalid
Viacheslav closed T5062: `set failed` after VRRP transition scripts as Invalid.
Mar 8 2023, 1:04 PM · VyOS 1.4 Sagitta
j.bordon created T5066: Different GRE tunnel but same tunnel keys error.
Mar 8 2023, 11:01 AM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
aserkin added a comment to T5045: BFD is not starting after upgrade to 1.4-rolling-202302150317.

BTW this configuration takes almost 20 minutes to load. I wonder if there's a way to speed up this process?

Mar 8 2023, 10:38 AM · VyOS 1.4 Sagitta
dex created T5065: Mixing `destination port xxx` and `destination group port-group yyy` in firewall rules doesn't work, but can be commited.
Mar 8 2023, 9:48 AM · VyOS 1.4 Sagitta
dex updated the task description for T5064: Value validation for domain-groups seems to be broken.
Mar 8 2023, 9:01 AM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta
dex created T5064: Value validation for domain-groups seems to be broken.
Mar 8 2023, 8:51 AM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta
hard added a comment to T380: Add system service fail2ban.

+1 for implementation

Mar 8 2023, 8:35 AM · Invalid
hard awarded T380: Add system service fail2ban a Like token.
Mar 8 2023, 8:34 AM · Invalid
aserkin added a comment to T5045: BFD is not starting after upgrade to 1.4-rolling-202302150317.

Thank you, @c-po. Will try raising limits to 4096.
Well in this project we're trying to implement L2TP network server with MPLE-PE functionality with our partner mobile operator. This is for b2b projects with a number of customers connecting their mobiles to corporate resources for some reasons.
So the config has three groups of BGP peers: four of ipv4-unicast peers (10.228.134.34, 10.228.134.36, 10.228.134.38, 10.228.134.40) for connection to L2TP LACs (actually they are mobile gateways - GGSN/PGW) and AAA servers, another pair is ipv4-vpn multihop peers (10.5.72.1,10.5.72.2) where customer's L3VPN connections are terminated, And one more peer connecting to 3d party carrier grade NAT solution for the customers who need Internet access.
The LNS and NAT nodes are implemented on a single server with KVM virtual machines interconnected with each other and with external world by OpenVSvitch/DPDK.
The VRF names are assigned by AAA server for each subscriber with Accel-VRF-Name attribute.
This is also where the defect https://github.com/FRRouting/frr/issues/12919 comes from. Just to spot on it)
Let me know if you nedd additional info.

Mar 8 2023, 8:20 AM · VyOS 1.4 Sagitta
a.apostoliuk changed the status of T5042: Command 'show vpn ipsec remote-access' does not work from Open to In progress.
Mar 8 2023, 8:14 AM · VyOS 1.4 Sagitta
dex added a comment to T5062: `set failed` after VRRP transition scripts.

I can confirm that after adding the aforementioned code block to my scripts everything works as expected.

Mar 8 2023, 7:56 AM · VyOS 1.4 Sagitta

Mar 7 2023

c-po added a comment to T5045: BFD is not starting after upgrade to 1.4-rolling-202302150317.

@aserkin WOW that is a huge VRF config. With that amount you definately reach the max FD limit.

Mar 7 2023, 9:36 PM · VyOS 1.4 Sagitta
jestabro closed T4900: Cache intermediary results of get_config_diff in Config instance as Resolved.
Mar 7 2023, 8:55 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T5051: Use Literal types to provide op-mode CLI choices and API enums as Resolved.
Mar 7 2023, 8:47 PM · VyOS 1.4 Sagitta
jestabro moved T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command from Need Triage to Backport Candidates on the VyOS 1.3 Equuleus (1.3.3) board.
Mar 7 2023, 8:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro moved T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command from Need Triage to Finished on the VyOS 1.4 Sagitta board.
Mar 7 2023, 8:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro moved T4872: Op-mode show openvpn misses a case when parsing for tunnel IP from Need Triage to Backport Candidates on the VyOS 1.3 Equuleus (1.3.3) board.
Mar 7 2023, 8:02 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro added a comment to T4872: Op-mode show openvpn misses a case when parsing for tunnel IP.

Backport PR:
https://github.com/vyos/vyos-1x/pull/1874

Mar 7 2023, 8:02 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro changed the status of T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command from Needs testing to Backport pending.

Backport PR for this and T4872:
https://github.com/vyos/vyos-1x/pull/1874

Mar 7 2023, 8:01 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro moved T2649: Ensure configration mode scripts conform to coding guidelines from Need Triage to Finished on the VyOS 1.3 Equuleus board.
Mar 7 2023, 6:36 PM · VyOS 1.3 Equuleus
jestabro closed T2649: Ensure configration mode scripts conform to coding guidelines, a subtask of T2582: Script daemon to offload processing during commit, as Resolved.
Mar 7 2023, 6:36 PM · VyOS 1.3 Equuleus (1.3.0)