Great addition, it has one minor bug.

The problem is that, comparing to command output on 1.3, it only show the leases granted by the router (and doesn't contain leases granted by the second router, regardless of states primary|secondary.
So user might think synchronization between routers defined in fail-over mode is broken.
But this is not the case. As explained in the description, all information about leases, granted by both routers, is present on lease files on both routers.

PR for 1.5 https://github.com/vyos/vyos-1x/pull/2544

PR:
https://github.com/vyos/vyos-1x/pull/2542

KeyboardInterrupt is caught with an appropriate error message now.

What is the difference between local router and failover router? It is not clear. My local router in failover mode ;) but state master.

Pretty sure some preceding backports are pending. Please give me a couple of days. I plan to sync up 1.4 with 1.5 and update the docs.

We'll discuss this internally, but for sure a fix should be applied.
Thanks for such a detailed bug-report.

PR https://github.com/vyos/vyos-build/pull/459

Agree with @Viacheslav and @GurliGebis comments above.

I agree, without it, you end up repeating yourself alot, with the established, related and invalid rules.
As long as they are applied before the zone specific rules (which is how I guess it used to work), it makes sense.

Should we return global state policy?
It was useful.

Backport to 1.4 has conflicts https://github.com/vyos/vyos-1x/pull/2533

PR:
https://github.com/vyos/vyos-1x/pull/2532

@Viacheslav
I missed running git pull on my ansible execution node. Works as it should. Thank you!

A fix that changes the behavior back to it was https://github.com/vyos/vyos-1x/pull/2527

PR for bridge: https://github.com/vyos/vyos-1x/pull/2528

Works fine

$ curl -k --location --request POST 'https://192.168.122.11/reboot'   --form data='{"op": "reboot", "path": ["now"]}'   --form key='foo'
{"success": true, "data": "Warning: there are unsaved configuration changes!\nRun 'save' command if you do not want to lose those changes after reboot/shutdown.\n\n", "error": null}

@a.apostoliuk will be available in the next rolling release.

I had the below set on the pppoe interface to allow for DHCPv6-PD. That part was working fine it was just the pppoe interface that wasn't picking up an address:

This is related to Kernel addr_gen_mode beeing globally disabled. It's actually on my "to refactor list" and with this bug it gainer priority!

PR2518 submitted

PR https://github.com/vyos/vyos-1x/pull/2516