Interface groups are sync to vyos_nat, so if interface group is defined, it's available in vyos_nat table to be use.
We need to extend cli in order to allow interface group on NAT configurations.
Description
Description
Details
Details
- Difficulty level
- Unknown (require assessment)
- Version
- 1.5-rolling-202310100022
- Why the issue appeared?
- Will be filled on close
- Is it a breaking change?
- Perfectly compatible
- Issue type
- Improvement (missing useful functionality)
Related Objects
Related Objects
Event Timeline
Comment Actions
This is causing smoketests on the nightly builds to fail
DEBUG - Traceback (most recent call last):
DEBUG - File "/usr/libexec/vyos/conf_mode/nat66.py", line 127, in <module>
DEBUG - generate(c)
DEBUG - File "/usr/libexec/vyos/conf_mode/nat66.py", line 101, in generate
DEBUG - render(nftables_nat66_config, 'firewall/nftables-nat66.j2', nat, permission=0o755)
DEBUG - File "/usr/lib/python3/dist-packages/vyos/template.py", line 142, in render
DEBUG - rendered = render_to_string(template, content, formater, location)
DEBUG - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
DEBUG - File "/usr/lib/python3/dist-packages/vyos/template.py", line 111, in render_to_string
DEBUG - rendered = template.render(content)
DEBUG - ^^^^^^^^^^^^^^^^^^^^^^^^
DEBUG - File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 1301, in render
DEBUG - self.environment.handle_exception()
DEBUG - File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 936, in handle_exception
DEBUG - raise rewrite_traceback_stack(source=source)
DEBUG - File "/usr/share/vyos/templates/firewall/nftables-nat66.j2", line 28, in top-level template code
DEBUG - {{ config | nat_rule(rule, 'source', ipv6=True) }}
DEBUG - ^^^^^^^^^^^^^^^^^^^^^^^^^
DEBUG - File "/usr/lib/python3/dist-packages/vyos/template.py", line 660, in nat_rule
DEBUG - return parse_nat_rule(rule_conf, rule_id, nat_type, ipv6)
DEBUG - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
DEBUG - File "/usr/lib/python3/dist-packages/vyos/nat.py", line 58, in parse_nat_rule
DEBUG - oiface = rule_conf['outbound_interface']['interface_group']
DEBUG - ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
DEBUG - TypeError: string indices must be integers, not 'str'