@twan Can we close it?

PR https://github.com/vyos/vyos-1x/pull/2129

Cherry-pick https://github.com/vyos/vyos-1x/pull/2125

@fernando Can we close it?

We are against "raw" options. As it is a bad design.
Specify which exactly options you want to configure. It is better to implement them separately.

@troggie Could you confirm that you expect "0"
Regarding documentation, it should be "-1" https://github.com/accel-ppp/accel-ppp-docs/blob/master/configuration/pppoe.rst

PR https://github.com/vyos/vyos-1x/pull/2124

Could you close the task if the issue is solved?

Virtio FS merged https://github.com/vyos/vyos-build/commit/adfd8a58c66adb6e5a61bc8a00ec1d183368a196

The same bug was with ipoe-server https://vyos.dev/T5283
It is the actual address x.x.x.0 for UNIX devices and PPP interfaces, but it could be issue work Windows clients
There is a simple fix https://github.com/vyos/vyos-1x/commit/8a79769bf447cb18d456f061afd6a7997b8264f8

Which version?
Which tested config? Which generated config?
It would be more clear if you provided tangible examples.

Duplicate of the task https://vyos.dev/T4502
And there also a PR https://github.com/vyos/vyos-1x/pull/2062
It is waiting for merging firewall refactoring

You skip this warning and delte version number line

// Warning: Do not remove the following line
// vyos-config-version: "bgp@4:broadcast-relay@1:cluster@1:config-management@1:conntrack@3:conntrack-sync@2:container@1:dhcp-relay@2:dhcp-server@6:dhcpv6-server@1:dns-dynamic@1:dns-forwarding@4:firewall@10:flow-accounting@1:https@4:ids@1:interfaces@29:ipoe-server@1:ipsec@12:isis@3:l2tp@4:lldp@1:mdns@1:monitoring@1:nat@5:nat66@1:ntp@2:openconnect@2:ospf@2:policy@5:pppoe-server@6:pptp@2:qos@2:quagga@11:rip@1:rpki@1:salt@1:snmp@3:ssh@2:sstp@4:system@26:vrf@3:vrrp@4:vyos-accel-ppp@2:wanloadbalance@3:webproxy@2"
// Release version: 1.4-rolling-202307090317

Conntrack should be disabled by default https://vyos.dev/T5080

It is not a bug.
It is the implementation of TACACS authentication https://github.com/vyos/vyos-1x/pull/2038
https://github.com/vyos/vyos-1x/blob/fa07179ae7f1dc07e6ccc1b20d2b81384b6efe07/debian/vyos-1x.postinst#L47-L52

There is this line in the code https://github.com/vyos/vyos-1x/blob/688755a988e233e221bf920e391e35d5ddc9cb56/src/op_mode/show_ntp.sh#L21

@jvoss Add the PR, please
Thanks.

Try to add no_tag_node_value_mangle there https://github.com/vyos/vyos-1x/blob/20b7155f4140f54cf7669256160b6fedd8c1ab7a/src/conf_mode/protocols_static.py#L50

@dongjunbo It requires more tests and reviews

Do you have any idea for the CLI?

Proposed syntax one of them

set system option time-format 12|24
set system option time-format 12-hour|24-hour
set system option time-format us|gb

Actually, it should configure:

sudo localectl set-locale LC_TIME="en_GB.UTF-8"
sudo localectl set-locale LC_TIME="en_US.UTF-8"

Maybe it is the wrong way. I think it shouldn't touch anything in the disable state.

PR https://github.com/vyos/vyos-1x/pull/2105

set system sflow interface 'eth0'
set system sflow interface 'eth1'
set system sflow server 127.0.0.1

Actualy is just exports TMOUT option per login

In T5364#153398, @troggie wrote:

In T5364#153397, @Viacheslav wrote:

I'm wondering about the syntax
Will it be enough?

set service pppoe-server pado-delay 0

I think we should include the sessions incase there multiple PPPOE services and people want to spread the load across multiple devices?
Or maybe an option to allow without sessions as well as allow with sessions - make the system versatile ?

I'm wondering about the syntax
Will it be enough?

set service pppoe-server pado-delay 0

Will be fixed in the next rolling release.

PR https://github.com/vyos/vyos-1x/pull/2102

In T5363#153177, @Apachez wrote:

I think this should be configured through a config option if bash-history should be retained or not (by default it shouldnt for regular users and equal to root).

It can for security reasons be argued that history should only exist in current session but when user logs out it should be removed.

This way in a multiuser environment one user cannot steal potential sensitive data from another user.

If security logging (what a particular user have done to the system when logged in) is needed this should be done remotely through syslog or similar.

Something wrong with this template https://github.com/vyos/vyos-1x/blob/d2540ac4c6fc05991b18cf0e2434fbb6d5f3c2cf/data/templates/lldp/vyos.conf.j2#L7

It should be configurable as an option but not by default.

It is not fully implemented.
You have to set the URL to a JSON file with System versions, which not exists for now (there is no permanent URL for it), so it will be in the future developments.

FRR does not support it
Allows only full multicast table

r11# clear ip 
...
  mroute       IP multicast routing table

https://github.com/vyos/vyos-1x/blob/d2540ac4c6fc05991b18cf0e2434fbb6d5f3c2cf/src/init/vyos-router#L327
https://github.com/vyos/vyos-1x/blob/d2540ac4c6fc05991b18cf0e2434fbb6d5f3c2cf/src/conf_mode/system-login.py#L392-L393

PR https://github.com/vyos/vyos-1x/pull/2101

Fixed with enabling offloads https://vyos.dev/T3619

vyos@r14# set interfaces ethernet eth0 offload 
Possible completions:
   gro                  Enable Generic Receive Offload
   gso                  Enable Generic Segmentation Offload
   lro                  Enable Large Receive Offload
   rfs                  Enable Receive Flow Steering
   rps                  Enable Receive Packet Steering
   sg                   Enable Scatter-Gather
   tso                  Enable TCP Segmentation Offloading

It possible with

set protocols bgp 65001 parameters default no-ipv4-unicast

It seems to work fine (VyOS 1.4-rolling-202307120317).

vyos@r14# set interfaces ethernet eth1 description 123
[edit]
vyos@r14# commit
[edit]
vyos@r14# compare 1
[interfaces ethernet eth1]
+ description "123"

Updated link https://github.com/vyos/vyatta-cfg-quagga/blob/2fa0f52e45f4491b760cf03e72c871020492dfb7/templates/protocols/ospf/passive-interface/node.def#L29-L35

We will not update FRR to 8.x for 1.3 LTS releases.