Page MenuHomeVyOS Platform

Allow arbitrary subnets in PPPoE client IP pools
Closed, ResolvedPublicBUG

Description

I found it weird that when defining the IP pool for clients in the pppoe-server service, the subnet is restricted to a /24 subnet, so i decided to run a few tests and the service in fact does not have such a restriction.

Details

Version
-
Is it a breaking change?
Perfectly compatible

Event Timeline

RFigas created this object in space S1 VyOS Public.
RFigas changed the task status from Open to In progress.Jul 29 2023, 10:40 PM

Which version?
Which tested config? Which generated config?
It would be more clear if you provided tangible examples.

I'm sorry.
I tested this is VyOS 1.3.3.
I tested mutliple configurations, from subnet /23 all the way up to /32 with the command "set service pppoe-server client-ip-pool subnet <x.x.x.x/x>"
After setting the subnet i'd connect multiple clients to VyOS and check wether all the available IP addresses were used, and they were.

Another oddity i discovered since then, VyOS will assign the network address to a client, in my case 192.168.0.0, and in this case VyOS will not respond to pings made by it.

The same bug was with ipoe-server https://vyos.dev/T5283
It is the actual address x.x.x.0 for UNIX devices and PPP interfaces, but it could be issue work Windows clients
There is a simple fix https://github.com/vyos/vyos-1x/commit/8a79769bf447cb18d456f061afd6a7997b8264f8

Viacheslav changed the subtype of this task from "Task" to "Bug".

Not a bug for 1.5/1.4 anymore.

vyos@r11# set service pppoe-server client-ip-pool POOL range 100.64.24.1/24
[edit]
vyos@r11# run show ver
Version:          VyOS 1.4.0-rc3
Release train:    sagitta

Still bug for 1.3

vyos@r15# set service pppoe-server client-ip-pool name POOL subnet  100.64.24.1/24

  
  
  
  Not a valid CIDR formatted prefix
  Value validation failed
  Set failed

[edit]
vyos@r15#
dmbaturin renamed this task from PPPoE-Server Client IP pool Subnet to Allow arbitrary subnets in PPPoE client IP pools.May 10 2024, 7:29 PM
dmbaturin removed a project: Restricted Project.
dmbaturin changed Issue type from Documentation update to improvement.May 10 2024, 8:10 PM