Page MenuHomeVyOS Platform

Execute VRRP transition script when `set high-availability disable` is commited
Open, WishlistPublicFEATURE REQUEST

Description

In T5060 I suggested to implement something like a "VRRP maintenance mode". Thank you again for implementing this feature!

Part of the VRRP configuration in one of our testing environments looks like this:

sync-group main {
    member com
    member mgmt
    member adm
    member apm
    member byod
    member dflt
    member gst
    member gyod
    member prn
    member rol
    member srv01
    member stdnt
    member stf
    member tchr
    member tr_scl
    member prs
    transition-script {
        backup /config/scripts/ha/vrrp-backup.sh
        fault /config/scripts/ha/vrrp-fault.sh
        master /config/scripts/ha/vrrp-master.sh
        stop /config/scripts/ha/vrrp-stop.sh
    }
}

Transition scripts work perfectly fine when transitioning from MASTER to BACKUP and vice-versa. However, no transition script is executed when disabling keepalived through set high-availability disable.

It would be nice if committing set high-availability disable would also execute the stop transition script.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Improvement (missing useful functionality)

Event Timeline

Maybe it is the wrong way. I think it shouldn't touch anything in the disable state.

Hmm, fair enough. Maybe just executing the stop script and then committing set high-availability disable is enough for maintenance periods.
One general question though out of curiosity: What are the circumstances in which the stop script is executed in the first place?

dmbaturin triaged this task as Wishlist priority.Jan 11 2024, 11:51 AM
dmbaturin added a project: VyOS 1.5 Circinus.