https://github.com/vyos/vyos.vyos/pull/395 for OSPFv2 fixes - both unit and integration

Follow-up https://github.com/vyos/vyos.vyos/pull/394 is for ospfv3 integration tests

found the bug in ospf_interfaces bug. This code (both for 1.3- and 1.4+) does not cut it:

https://github.com/vyos/vyos.vyos/pull/387

https://github.com/vyos/vyos.vyos/pull/379

should be fixed by https://github.com/vyos/vyos.vyos/pull/382

https://github.com/vyos/vyos.vyos/pull/381

https://github.com/vyos/vyos.vyos/pull/380

• Raised https://github.com/vyos/vyos.vyos/pull/379
• Completed integration tests for 1.3- but 1.4+ fails - need to workaround unsupported commands in tests setup (e..g 'config-trap' and look into module code as new stanzas are not handled correctly (e.g. log vs log 'enable')
• Unit tests are failing after the parser regex change - need to fix them too

https://github.com/vyos/vyos.vyos/pull/378

Confirmed - 1.2-1.5 are failing

Confirmed that 1.4 and 1.5 is no cigar

Confirmed - integration tests are failing for the 1.2-1.5 version

This issue should have been resolved by a number of already implemented PRs - e.g. https://github.com/vyos/vyos.vyos/pull/354 or https://github.com/vyos/vyos.vyos/pull/368, therefore I am closing this ticket now. Please feel free to re-open if I am wrong

https://github.com/vyos/vyos.vyos/pull/373

I can see the tests are NOK for all the versions - working in a separate branch to fix

Are we closing this? Or we have some glowing example of the wrong processing?

Almost done - just looking at failing overriden before dict issue - other integration tests seem to be working now

Started to put the patches together in https://github.com/vyos/vyos.vyos/pull/368

Going to need to fix testing for fw_rules as a part of my current work - so picking this up...

Raised a Draft PR https://github.com/vyos/vyos.vyos/pull/368

The fix is now a part of https://github.com/vyos/vyos.vyos/pull/367

the PR to fix this is https://github.com/vyos/vyos.vyos/pull/367

The PR tp fix this https://github.com/vyos/vyos.vyos/pull/367

The PR# is re-submitted for review and testing

Raised https://github.com/vyos/vyos.vyos/pull/365

It appears that path-limit GBP network options is deprecated

I did some investigation - apparently the plugin cannot match the full command pattern (including optional attributes) and silently refuses to generate a resultant set of commands - I will be looking into this - most likely the issue is related to rm_templates regex patterns for getval

Update - I cloned the current vyo.vyos changes, created a branch and made the changes that Maxime proposed.

sure, ok - I will do needful for it to be tests ready
It does not appear a huge change to me

I believe it was forked a while ago (in March this year) and never refreshed after that - so the fork (and PK) is using older version of the repo

Sanity tests are failing pretty much all:
FATAL: The 5 sanity test(s) listed below (out of 34) failed. See error output above for details.
action-plugin-docs
import --python 3.12
pep8
pylint
validate-modules

Or I may just re-introduce the changes into the working current branch given they are all straight forward

Started to look into this - but it seems to be based on older version of collection (57 commits behind) and failing all the sanity checks.
I will try and refresh that branch and re-test

On it, @syncer

I raised a draft PR (https://github.com/vyos/vyos.vyos/pull/357) to tackle some of the compatibility issues. I will try and finalise it in coming days