Page MenuHomeVyOS Platform
Create Task
Maniphest T5316

configtree: use a single pass of the diff algorithm
Closed, ResolvedPublicENHANCEMENT
Actions

Description

For clarity of the code, the diff algorithm is called twice: firstly to produce full difference trees, and secondly to produce the truncated tree of 'delete' commands. For the purpose of purity (remove mutable references) and generalization (manipulation of CStore data structure), it is useful to combine these in a single pass.

Details

Difficulty level
Easy (less than an hour)
Version
vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedENHANCEMENTjestabroT5316 configtree: use a single pass of the diff algorithm
 ResolvedENHANCEMENTjestabroT5317 configtree: remove mutable references
 In progressENHANCEMENTjestabroT5528 Replace legacy loadFile with config_diff
 ResolvedENHANCEMENTjestabroT5815 Add load_config module

Event Timeline

jestabro triaged this task as Normal priority.Jun 27 2023, 1:32 PM
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro added a subtask: T5317: configtree: remove mutable references.Jun 27 2023, 1:37 PM
jestabro changed Issue type from Improvement (missing useful functionality) to Internal change (not visible to end users).
pasik added a subscriber: pasik.Jun 27 2023, 1:42 PM
jestabro added a comment.Jul 17 2023, 7:04 PM

The following will be in the PR for T5317:
https://github.com/vyos/vyos1x-config/compare/master...jestabro:single-pass

jestabro added a comment.Jul 24 2023, 3:12 AM

PR:
https://github.com/vyos/vyos1x-config/pull/19

jestabro closed this task as Resolved.Jul 28 2023, 4:49 PM
jestabro claimed this task.
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
jestabro closed subtask T5317: configtree: remove mutable references as Resolved.