Page MenuHomeVyOS Platform
Create Task
Maniphest T5316

configtree: use a single pass of the diff algorithm
Closed, ResolvedPublicENHANCEMENT
Actions

Description

For clarity of the code, the diff algorithm is called twice: firstly to produce full difference trees, and secondly to produce the truncated tree of 'delete' commands. For the purpose of purity (remove mutable references) and generalization (manipulation of CStore data structure), it is useful to combine these in a single pass.

Details

Version
vyos-1.4
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedENHANCEMENTjestabroT5316 configtree: use a single pass of the diff algorithm
 ResolvedENHANCEMENTjestabroT5317 configtree: remove mutable references
 ResolvedENHANCEMENTjestabroT5528 Replace legacy loadFile with config_diff
 ResolvedENHANCEMENTjestabroT5815 Add load_config module
 ResolvedENHANCEMENTjestabroT5400 Move libvyosconfig build out of the Docker image
 ResolvedBUGjestabroT7289 Add libvyosconfig as git submodule of vyos-1x for stream builds
 ResolvedENHANCEMENTjestabroT6717 Add hybrid Cstore manipulation library to replace set/delete/load_config functionality
 ResolvedENHANCEMENTjestabroT6718 Use vyconf daemon for validation of set commands
 ResolvedENHANCEMENTjestabroT6946 Add initial commit algorithm to vyconf
 ResolvedENHANCEMENTjestabroT7121 Set up communication vyconfd <-> vyos-configd
 ResolvedENHANCEMENTjestabroT7272 Vyconf: update in memory config tree on response from vyos-commitd
 OpenENHANCEMENTjestabroT7292 Expose vyconf commit algorithm for CLI and ConfigSession instance
 ResolvedENHANCEMENTjestabroT7302 Implement commit dry-run for vyconfd/vyos-commitd
 ResolvedENHANCEMENTjestabroT7321 Replace legacy operations in configsession.py with vyconf client operations
 OpenENHANCEMENTjestabroT7374 Integrate vyconf config session with CLI config session
 ResolvedENHANCEMENTjestabroT7910 Standardize vyconf session resource management across Python config modules
 ResolvedBUGjestabroT7637 Fix typo in commit algorithm
 ResolvedBUGjestabroT7688 Correct the management of delete paths on vyconfd delete and commit requests
 OpenBUGjestabroT6959 Add support for addons after switch to internal reference tree
 ResolvedENHANCEMENTjestabroT7046 Add utilities for update of reference tree

Event Timeline

jestabro created this task.Jun 27 2023, 1:32 PM
jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
jestabro added a subtask: T5317: configtree: remove mutable references.Jun 27 2023, 1:37 PM
jestabro changed Issue type from improvement to Internal change (not visible to end users).
pasik subscribed.Jun 27 2023, 1:42 PM
jestabro added a comment.Jul 17 2023, 7:04 PM

The following will be in the PR for T5317:
https://github.com/vyos/vyos1x-config/compare/master...jestabro:single-pass

jestabro added a comment.Jul 24 2023, 3:12 AM

PR:
https://github.com/vyos/vyos1x-config/pull/19

jestabro mentioned this in rVYOSONEXe310cb6e194b: configtree: T5316: use single-pass to drop trim function.Jul 28 2023, 4:40 PM
jestabro closed this task as Resolved.Jul 28 2023, 4:49 PM
jestabro claimed this task.
jestabro moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
jestabro closed subtask T5317: configtree: remove mutable references as Resolved.
jestabro mentioned this in rVYOSONEX6ee292541161: T5316: drop trim function.Sep 10 2025, 1:16 PM
Restricted Repository Identity mentioned this in rVYOSONEX63175de45780: Merge pull request #12 from jestabro/immutable.Sep 10 2025, 1:16 PM