In T5249#174317, @jestabro wrote:

@adestis
https://vyos.dev/T5976

+1 on excluding disabled mappings

An initial implementation of this was put on hold, as there were several missing pieces, namely reload http-api withing an existing configession (T2612) and soft-rollback/soft-commit-confirm (T5249/T5976). With those in place, this can proceed.

@adestis
https://vyos.dev/T5976

In my eyes this could break many configs / setups, as there are a lot of people that like to "archive their past configs" just like this. (Essentially just disabling config parts instead of deleting)

Imo this shouldn't affect disabled mappings, but just if there are/going to be 2 active mapping with the same IP.

The cause could be due to wrong calculations for bandwidth/ceil class default T5974

Just as a temporary solution before a long term one is figured out, I did implement this as a post-boot script. For any one who stumbles on this

Looks good:

vyos@r1# tc class show dev eth1
class htb 1:1 root rate 1Gbit ceil 1Gbit burst 1375b cburst 1375b
class htb 1:64 parent 1:1 leaf 8005: prio 0 rate 100Mbit ceil 100Mbit burst 15337b cburst 1600b
class htb 1:65 parent 1:1 leaf 8006: prio 7 rate 750Mbit ceil 900Mbit burst 130968b cburst 1462b
[edit]
vyos@r1#

All you need to do to test it is set interfaces <ifaceClass> <iface> policy , commit, save, and then upgrade from 1.3.5 to 1.4, then this happens:

trae@cr01b-vyos:~$ configure
WARNING: There was a config error on boot: saving the configuration now could overwrite data.
You may want to check and reload the boot config
[edit]
trae@cr01b-vyos# comp saved
[interfaces bonding bond0]
- policy

I feel like maybe it would be a smart move to prune config structures:

1. when deleting configuration nodes (ex: If I had a traffic policy set, then ran delete interfaces bonding bond0 vif 123 policy route FOO, make sure to delete the policy section of the configuration assuming there is no route6, not just the route FOO part):
2. when upgrading major versions

PR: https://github.com/vyos/vyos-1x/pull/2873

In general for the whole world, it would be better to tell the ISP that this is bad practice and they should either assign customers a /56 prefix as minimum allocation.

@exp Add "set" of the commands to reproduce.

https://github.com/vyos/vyos-1x/pull/2871

Yeah I'm migrating everything to 1.4, so I don't need this.

Just putting together a PR for vyos-build to integrate it.