Page MenuHomeVyOS Platform

QoS: rewrite to XML and Python
Closed, ResolvedPublicFEATURE REQUEST

Description

Migrate existing QoS code to XML and Python

Details

Difficulty level
Hard (possibly days)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Event Timeline

c-po changed the task status from Open to In progress.Mar 6 2022, 6:08 AM
c-po claimed this task.
c-po triaged this task as Low priority.
c-po created this task.
c-po added a subtask: T725: Cake and FQ-PIE.
c-po changed Difficulty level from Unknown (require assessment) to Hard (possibly days).
syncer changed the status of subtask T725: Cake and FQ-PIE from Open to In progress.Oct 18 2022, 2:52 PM
c-po changed the task status from In progress to Needs testing.Jan 2 2023, 6:52 PM
c-po closed subtask T725: Cake and FQ-PIE as Resolved.

Should debug be True by default?
https://github.com/vyos/vyos-1x/blob/f5af95be4f66380d213771b975c63361e27616ef/python/vyos/qos/base.py#L22

it cause:

vyos@r1# run show conf com | match qos
set qos interface eth0 egress 'qos-policy-eth0'
set qos policy random-detect qos-policy-eth0 bandwidth '5000'
commit


vyos@r1# commit
[ qos ]
DEBUG/QoS: tc qdisc add dev eth0 root handle 1:0 dsmark indices 8 set_tc_index
DEBUG/QoS: tc filter add dev eth0 parent 1:0 protocol ip prio 1 tcindex mask 0xe0 shift 5
DEBUG/QoS: tc qdisc add dev eth0 parent 1:0 handle 2:0 gred setup DPs 8 default 0 grio
DEBUG/QoS: tc qdisc change dev eth0 handle 2:0 gred limit 73728 min 9216 max 18432 avpkt 1024 burst 12 bandwidth 5000000 probability 0.1 DP 0 prio 8
DEBUG/QoS: tc qdisc change dev eth0 handle 2:0 gred limit 73728 min 10240 max 18432 avpkt 1024 burst 12 bandwidth 5000000 probability 0.1 DP 1 prio 7
DEBUG/QoS: tc qdisc change dev eth0 handle 2:0 gred limit 73728 min 11264 max 18432 avpkt 1024 burst 13 bandwidth 5000000 probability 0.1 DP 2 prio 6
DEBUG/QoS: tc qdisc change dev eth0 handle 2:0 gred limit 73728 min 12288 max 18432 avpkt 1024 burst 14 bandwidth 5000000 probability 0.1 DP 3 prio 5
DEBUG/QoS: tc qdisc change dev eth0 handle 2:0 gred limit 73728 min 13312 max 18432 avpkt 1024 burst 14 bandwidth 5000000 probability 0.1 DP 4 prio 4
DEBUG/QoS: tc qdisc change dev eth0 handle 2:0 gred limit 73728 min 14336 max 18432 avpkt 1024 burst 15 bandwidth 5000000 probability 0.1 DP 5 prio 3
DEBUG/QoS: tc qdisc change dev eth0 handle 2:0 gred limit 73728 min 15360 max 18432 avpkt 1024 burst 16 bandwidth 5000000 probability 0.1 DP 6 prio 2
DEBUG/QoS: tc qdisc change dev eth0 handle 2:0 gred limit 73728 min 16384 max 18432 avpkt 1024 burst 16 bandwidth 5000000 probability 0.1 DP 7 prio 1

[edit]
vyos@r1#

Parent task is completed - Bugs will get their own subtask and linked to this parent if possible.