Page MenuHomeVyOS Platform
Create Task
Maniphest T5941

[1.3.5 -> 1.4.0-RC1 Migration] Orphaned Configuration Nodes Cause Issues
Closed, ResolvedPublicBUG
Actions

Description

It looks like the move of PBR interface configuration was not migrated:

image.png (48×370 px, 14 KB)

I believe this needs to be migrated to the policy route <ROUTE> interface location.

I think what happened here is that I had previously configured PBR, but I didn't delete the configuration node above the name of the policy itself, so that part of it remained, but no longer exists in 1.4. This also happened with traffic-policy. This doesn't actually cause an issue per se, but it causes the saved configuration on boot to not match the running configuration, which would trigger a warning when entering configuration mode.

Details

Difficulty level
Unknown (require assessment)
Version
1.4.0-rc1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects
Search...

Event Timeline

trae32566 created this task.Jan 14 2024, 11:27 AM
trae32566 updated the task description. (Show Details)Jan 14 2024, 11:30 AM
trae32566 added a parent task: T5938: Migration fail root task for 1.4-rc.
trae32566 renamed this task from [1.3.5 -> 1.4.0-RC1 Migration] PBR Configuration is Not Migrated to [1.3.5 -> 1.4.0-RC1 Migration] Orphaned Configuration Nodes Cause Issues.Jan 14 2024, 11:56 AM
trae32566 updated the task description. (Show Details)
trae32566 updated the task description. (Show Details)
Viacheslav changed the task status from Open to Needs testing.Jan 17 2024, 6:03 PM
Viacheslav triaged this task as Normal priority.
Viacheslav added a subscriber: Viacheslav.
This comment was removed by Viacheslav.
pasik added a subscriber: pasik.Jan 17 2024, 6:32 PM
trae32566 added a comment.EditedJan 22 2024, 1:42 PM

All you need to do to test it is set interfaces <ifaceClass> <iface> policy , commit, save, and then upgrade from 1.3.5 to 1.4, then this happens:

trae@cr01b-vyos:~$ configure
WARNING: There was a config error on boot: saving the configuration now could overwrite data.
You may want to check and reload the boot config
[edit]
trae@cr01b-vyos# comp saved
[interfaces bonding bond0]
- policy

I feel like maybe it would be a smart move to prune config structures:

  1. when deleting configuration nodes (ex: If I had a traffic policy set, then ran delete interfaces bonding bond0 vif 123 policy route FOO, make sure to delete the policy section of the configuration assuming there is no route6, not just the route FOO part):
  2. when upgrading major versions

With both of these, we would need to keep in mind that some sections can be empty but still necessary (ex: set service ssh).

Viacheslav added a comment.EditedJan 24 2024, 2:03 PM

PR for policy https://github.com/vyos/vyos-1x/pull/2890
PR for traffic-policy https://github.com/vyos/vyos-1x/pull/2892

Viacheslav closed this task as Resolved.Feb 2 2024, 3:36 PM
Viacheslav claimed this task.
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.