Done for 1.4/1.5 https://github.com/vyos/vyos-1x/tree/current/python/vyos/utils
It won't be implemented for 1.3 as we risk breaking something.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Dec 20 2023
I finally got a chance to dive into this some more.
PR for 1.5: https://github.com/vyos/vyos-build/pull/476
Also while at it, the smoketests regarding UPnP should probably be updated by this task aswell since they claim everything is OK:
configuration for dhcp reservation with just mac address doesn't give configuration exception, but cause an error to kea directly as ERROR [kea-dhcp4.dhcp4/49022.140176366361024] DHCP4_PARSER_FAIL failed to create or run parser for configuration element shared-networks: specified reservation for DUID: hwtype=1 xx:xx:xx:xx:xx:xx must include at least one resource, i.e. hostname, IPv4 address, IPv6 address/prefix, options (/run/kea/kea-dhcp4.conf:59:5)
Dec 19 2023
Thanks for that heads-up @Viacheslav - My bigger concern with this task was the failure-mode of the configuration problem being so unexpected and hard to troubleshoot.
@Viacheslav I upgraded to the latest rolling release and this seems to work perfectly.
So, I tested the version 1.5-rolling-202312191154
Firstly, this bug should be fixed T5837
@zsdc Can we close it?
It won't fix due the old backend
Fixed in 1.4/1.5
We agree not to use raw options anymore.
If some options are required, it should be a separate PR per configured option.
Most of the changes are not supported by reload accel-cmd/systemctl unit.
Accel-ppp cannot apply some features/changes without the daemon restarting. In other words, there are only several features that could be applied by reload.
The current FRR 7.5
There are no reports with this bug.
Close it. Re-open if you still have issues or create a new bug report.
Dec 18 2023
In T5775#168092, @marvin wrote:Excellent; thanks @GurliGebis! I built 1.4 today and confirmed it's working as expected.
As far as I'm concerned, this issue is now resolved and the ticket can now be closed.
Excellent; thanks @GurliGebis! I built 1.4 today and confirmed it's working as expected.
Yes it should trigger to recreate container but it doesn’t get a dictionary key for recreating
In my case, the container is created and running using IPv4 only. The network it is in has a defined prefix for IPv4 and IPv6. Then, the only thing I try to do is add an IPv6 address to the container. The network it is connected to already has the IPv6 prefix defined. That is when it dies.
The mentioned file that missing is located upstream in https://github.com/miniupnp/miniupnp/tree/miniupnpd_2_3_1/miniupnpd/netfilter_nft/scripts
and the upstream configuration options that we think are missing to match vyos chains is https://github.com/miniupnp/miniupnp/blob/miniupnpd_2_3_1/miniupnpd/miniupnpd.conf#L77
Could you point out some documentation/examples on which scripts are missing?
It seems it has never been tested since @jack9603301 implemented it in task T3420. It seems he also didn't test it.