Page MenuHomeVyOS Platform
Create Task
Maniphest T5660

Remove redundant calls to config dependency scripts
Closed, ResolvedPublicBUG
Actions

Description

Multiple calls to set_dependents may lead to repeated calls to the functions wrapping config-mode script execution; remove redundancies. Implementation is simple, however, this will follow after resolving T5644, which will inform the modifications. Listed as difficulty 'normal' to allow for that investigation. More details will be added to the task when implementation is ready for PR.

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Performance optimization

Related Objects
Search...

Event Timeline

jestabro created this task.Oct 16 2023, 7:19 PM
jestabro triaged this task as Normal priority.
jestabro created this object in space S1 VyOS Public.
jestabro added a parent task: T5644: Firewall groups deletion can break config.
pasik subscribed.Oct 17 2023, 10:44 AM
jestabro mentioned this in T5666: Provide list of config-mode scripts scheduled for proposed commit.Oct 18 2023, 5:34 PM
jestabro added a subtask: T5666: Provide list of config-mode scripts scheduled for proposed commit.
jestabro mentioned this in T5731: Add ability to call config dependencies by canonical function instead of whole script.Nov 10 2023, 5:25 PM
jestabro added a subtask: T5731: Add ability to call config dependencies by canonical function instead of whole script.
jestabro added a parent task: T4820: Support for inter-config-mode script dependencies.Dec 19 2023, 4:08 AM
jestabro mentioned this in T5839: Remove trivial redundancies in calls to config dependency scripts.Dec 19 2023, 7:59 PM
jestabro added a subtask: T5839: Remove trivial redundancies in calls to config dependency scripts.
jestabro added a comment.Feb 28 2024, 5:27 PM

PR for global solution extends the local solution in T5839:
https://github.com/vyos/vyos-1x/pull/2659

jestabro moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.Feb 29 2024, 1:07 PM
jestabro changed the task status from Open to Needs testing.Feb 29 2024, 1:09 PM
jestabro changed the status of subtask T5839: Remove trivial redundancies in calls to config dependency scripts from Open to Needs testing.
jestabro changed the status of subtask T5666: Provide list of config-mode scripts scheduled for proposed commit from Open to On hold.Mar 1 2024, 2:49 PM
jestabro changed the task status from Needs testing to Backport candidate.Apr 25 2024, 2:48 PM
jestabro changed the status of subtask T5839: Remove trivial redundancies in calls to config dependency scripts from Needs testing to Backport candidate.
jestabro edited projects, added VyOS 1.4 Sagitta (1.4.0-epa3); removed VyOS 1.4 Sagitta.
jestabro added a subtask: T6276: Do not call config dependencies on script error.Apr 28 2024, 7:43 PM
jestabro mentioned this in T6276: Do not call config dependencies on script error.Apr 28 2024, 11:59 PM
jestabro closed this task as Resolved.Apr 29 2024, 12:16 PM
jestabro closed subtask T6276: Do not call config dependencies on script error as Resolved.
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0-epa3) board.
jestabro closed subtask T5839: Remove trivial redundancies in calls to config dependency scripts as Resolved.
dmbaturin removed a project: VyOS 1.5 Circinus.May 11 2024, 7:59 PM
dmbaturin changed Issue type from Bug (incorrect behavior) to Performance optimization.
jestabro mentioned this in T6569: Cache results of config script stages under configd, for use by configdep.Jul 11 2024, 5:17 PM
jestabro changed the status of subtask T5666: Provide list of config-mode scripts scheduled for proposed commit from On hold to In progress.Fri, Aug 23, 7:35 PM
jestabro closed subtask T5666: Provide list of config-mode scripts scheduled for proposed commit as Resolved.Mon, Aug 26, 4:47 PM