PR https://github.com/vyos/vyos-1x/pull/1657

vyos@r14:~$ show vpn ipsec connections 
Connection         State        Type    Remote address    Local TS        Remote TS    Proposal
-----------------  -----------  ------  ----------------  --------------  -----------  ---------------------------------------
OFFICE-B           established  IKEv1   192.0.2.2         -               -            AES_CBC/256/HMAC_SHA2_256_128/MODP_1024
OFFICE-B-tunnel-0  up           IPsec   192.0.2.2         192.168.0.0/24  10.0.0.0/21  AES_CBC/256/HMAC_SHA2_256_128/MODP_1024
OFFICE-B-tunnel-1  down         IPsec   192.0.2.2         192.168.1.0/24  10.0.0.0/21  -
OFFICE-B-tunnel-2  down         IPsec   192.0.2.2         192.168.2.0/24  10.0.0.0/21  -
OFFICE-C           down         IKEv1   192.0.2.2         -               -            -
OFFICE-C-tunnel-0  down         IPsec   192.0.2.2         192.168.5.0/24  10.0.0.0/21  -
vyos@r14:~$

@rcit I can assure you were never planned to explicitly disallow embedded IPv4 notation. Moreover, I thought the current validator supports it, even though we didn't have tests for it. I'll take a look!

Created PR to fix this: https://github.com/vyos/vyos-1x/pull/1656
This issue also exists in 1.3 though I didn't backport it.

https://github.com/vyos/vyos-1x/pull/1655

I seem to have jumped the gun a bit as the issue seems to have been resolved via:

@c-po I think the reason you're seeing the old name of 'pdns-r/worker' is due to a packaging regression described in T4814. All the latest builds of vyos 1.4 seem to be providing powerdns 4.4 instead of the expected 4.8. Since this issue and corresponding bugfix only pertains to powerdns >= 4.8, the issue would not be visible if powerdns is downgraded to 4.4.

Just as a point of additional reference, I've bisected the PowerDNS source code to see where the change from 'pdns-r/worker' to something else occurred and successfully found that commit 69b39198 in the repository changes the thread names away from the prefix of 'pdns-r'. Since that change, the string pdns-r/ no longer exists in the source code. The aforementioned commit is included in the following tags:

PR for policy route refactor updates to vyos_mangle: https://github.com/vyos/vyos-1x/pull/1654

or maybe better add this subsection in firewall section?

Relevant PR:

Hmm, I can't seem to reproduce that name with "pdns-recursor/now 4.8.0~beta1-1pdns.bullseye amd64" or "pdns-recursor/now 4.8.0~beta2-1pdns.bullseye amd64" both in a live bare-metal system or in a VM. Both versions return pdns_recursor for me when printed from p.name(). The worker thread names (as listed from ps or htop) also don't match: "rec/web+stat" and "rec/taskThread", not that either of these are returned by p.name().

We use p.name from process_iter and it returns pdns-r/worker. That‘s why I have reverted the commits as in the latest 1.4 VyOS iso with PDNS 4.8 beta it‘s how they names the worker thread

list/lists in config and op-mode now moved to external-list

task-scheduler logic was moved into vyos.task_scheduler so it can be imported properly and used by other modules

@c-po I noticed you've reverted the commit, may I ask how you're able to reproduce the process name of 'pdns-r/worker'? Just doing the testing again with the latest build as of writing (vyos-1.4-rolling-202211060813-amd64.iso), I get:

In the PR it was requested to change the group category from lists to external-list which I'm fine with, but before I do the work to rename files and fields, does everyone agree with this change?

I've added PR https://github.com/vyos/vyos-1x/pull/1649 for review. Not tested yet, I want to know if I'm on the right path.

PR was added, I'm just trying to learn the documentation system now. Though to be frank documentation has never been my strong suit.

To be a PR, after discussion with @sdev :
https://github.com/vyos/vyos-1x/compare/current...jestabro:trace-migration

TLDR; confirmed fixed for 1.3, please backport.

FRRouting Release 8.4 Available for Download
November 7, 2022

One miracle at a time :)

PR https://github.com/vyos/vyos-1x/pull/1643

https://github.com/vyos/vyos-build/pull/277

i see it like that

I'm not sure if wildcard-address fits. The address and the mask together combine to create the wildcard.

Note: this requires https://phabricator.vyos.net/T4800 to be completed.

https://github.com/vyos/vyos-build/pull/277

See https://github.com/vyos/vyos-build/pull/276

Well, after a better code reading, the var should be named chroot_includes_dir instead of includes_chroot_dir.

Thanks for catching this

Relevant PRs: